* [PATCH -next] crypto: allwinner - remove redundant platform_get_irq error message
@ 2020-02-05 14:01 Chen Zhou
2020-02-13 9:25 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-02-05 14:01 UTC (permalink / raw)
To: clabbe.montjoie, herbert, davem, mripard, wens
Cc: linux-crypto, linux-arm-kernel, linux-kernel, chenzhou10
Function dev_err() after platform_get_irq() is redundant because
platform_get_irq() already prints an error.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
index f72346a..3e4e4bb 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
@@ -565,10 +565,8 @@ static int sun8i_ce_probe(struct platform_device *pdev)
/* Get Non Secure IRQ */
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(ce->dev, "Cannot get CryptoEngine Non-secure IRQ\n");
+ if (irq < 0)
return irq;
- }
ce->reset = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(ce->reset)) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] crypto: allwinner - remove redundant platform_get_irq error message
2020-02-05 14:01 [PATCH -next] crypto: allwinner - remove redundant platform_get_irq error message Chen Zhou
@ 2020-02-13 9:25 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-02-13 9:25 UTC (permalink / raw)
To: Chen Zhou
Cc: clabbe.montjoie, davem, mripard, wens, linux-crypto,
linux-arm-kernel, linux-kernel
On Wed, Feb 05, 2020 at 10:01:30PM +0800, Chen Zhou wrote:
> Function dev_err() after platform_get_irq() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-13 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 14:01 [PATCH -next] crypto: allwinner - remove redundant platform_get_irq error message Chen Zhou
2020-02-13 9:25 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).