From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andrei Botila <andrei.botila@oss.nxp.com>
Cc: Horia Geanta <horia.geanta@nxp.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrei Botila <andrei.botila@nxp.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] crypto: caam - update xts sector size for large input length
Date: Fri, 6 Mar 2020 12:52:09 +1100 [thread overview]
Message-ID: <20200306015209.GL30653@gondor.apana.org.au> (raw)
In-Reply-To: <20200228104648.18898-1-andrei.botila@oss.nxp.com>
On Fri, Feb 28, 2020 at 12:46:48PM +0200, Andrei Botila wrote:
> From: Andrei Botila <andrei.botila@nxp.com>
>
> Since in the software implementation of XTS-AES there is
> no notion of sector every input length is processed the same way.
> CAAM implementation has the notion of sector which causes different
> results between the software implementation and the one in CAAM
> for input lengths bigger than 512 bytes.
> Increase sector size to maximum value on 16 bits.
>
> Fixes: c6415a6016bf ("crypto: caam - add support for acipher xts(aes)")
> Cc: <stable@vger.kernel.org> # v4.12+
> Signed-off-by: Andrei Botila <andrei.botila@nxp.com>
> ---
> This patch needs to be applied from v4.12+ because dm-crypt has added support
> for 4K sector size at that version. The commit was
> 8f0009a225171 ("dm-crypt: optionally support larger encryption sector size").
>
> drivers/crypto/caam/caamalg_desc.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-03-06 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 10:46 [PATCH] crypto: caam - update xts sector size for large input length Andrei Botila
2020-03-02 9:36 ` Horia Geanta
2020-03-06 1:52 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306015209.GL30653@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andrei.botila@nxp.com \
--cc=andrei.botila@oss.nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).