linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Kim, David" <david.kim@ncipher.com>
Cc: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"Magee, Tim" <tim.magee@ncipher.com>
Subject: Re: nCipher HSM kernel driver submission feedback request
Date: Fri, 13 Mar 2020 11:09:22 +0100	[thread overview]
Message-ID: <20200313100922.GB2161605@kroah.com> (raw)
In-Reply-To: <1584092894266.92323@ncipher.com>

On Fri, Mar 13, 2020 at 09:48:14AM +0000, Kim, David wrote:
> Hi Herbert,
> 
> We've been working on getting this driver code upstreamed into drivers/misc since the end of last
> year but things stalled a bit on our end. However, we are still interested in getting our submission
> approved and would please like your assistance and feedback on this.
> 
> The driver code for the hardware is straightforward and does not contain any cryptographic
> components as the cryptography is handled within the hardware's secure boundary. We have no
> plans to use the linux kernel crypto APIs as our customers require compliance to the FIPS 140
> standard or the eIDAS regulations.

But what I said was, you NEED to use the linux kernel crypto apis as you
need to not try to create your own.

Just because this is the way you did it before, does not mean it is the
correct thing to do.

So what is wrong if you do use the existing apis?  What is preventing
you from doing that?

thanks,

greg k-h

  reply	other threads:[~2020-03-13 10:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  9:48 nCipher HSM kernel driver submission feedback request Kim, David
2020-03-13 10:09 ` Greg KH [this message]
2020-03-16 10:44   ` Kim, David
2020-03-16 11:23     ` Greg KH
2020-03-23  6:49 ` Jason A. Donenfeld
2020-03-23 13:32   ` Kim, David
2020-03-23 13:59     ` Greg KH
2020-04-17 15:12       ` Kim, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313100922.GB2161605@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=david.kim@ncipher.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=tim.magee@ncipher.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).