* [PATCH v4]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()
@ 2020-04-03 9:13 Tang Bin
0 siblings, 0 replies; only message in thread
From: Tang Bin @ 2020-04-03 9:13 UTC (permalink / raw)
To: narmstrong, clabbe, herbert, davem
Cc: linux-crypto, linux-amlogic, linux-kernel, Tang Bin
When something goes wrong, platform_get_irq() will print an error message,
so in order to avoid the situation of repeat output,we should remove
dev_err here.
Changes form v3:
- fix the theme writing error.
Changes from v2:
- modify the theme format and content description.
- reformat the patch, it's the wrong way to resubmit a new patch that
should be modified on top of the original. The original piece is:
https://lore.kernel.org/patchwork/patch/1219611/
Changes from v1:
- the title has changed, because the description is not very detailed.
- the code has been modified, because it needs to match the theme.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 37901bd81..c2fa442c5 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -253,10 +253,8 @@ static int meson_crypto_probe(struct platform_device *pdev)
mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);
for (i = 0; i < MAXFLOW; i++) {
mc->irqs[i] = platform_get_irq_optional(pdev, i);
- if (mc->irqs[i] < 0) {
- dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i);
+ if (mc->irqs[i] < 0)
return mc->irqs[i];
- }
err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0,
"gxl-crypto", mc);
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-03 9:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 9:13 [PATCH v4]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe() Tang Bin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).