* [cryptodev:master 7/26] cctrng.c:undefined reference to `devm_ioremap_resource'
@ 2020-04-20 13:56 kbuild test robot
2020-04-21 5:42 ` hwrng: cctrng - Add dependency on HAS_IOMEM Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-04-20 13:56 UTC (permalink / raw)
To: Hadar Gat; +Cc: kbuild-all, linux-crypto, Herbert Xu
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 3357b61177a7f34267256098b29a7f4992af40f3
commit: a583ed310bb6b514e717c11a30b5a7bc3a65d1b1 [7/26] hwrng: cctrng - introduce Arm CryptoCell driver
config: um-kunit_defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
git checkout a583ed310bb6b514e717c11a30b5a7bc3a65d1b1
# save the attached .config to linux build tree
make ARCH=um
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
/usr/bin/ld: drivers/char/hw_random/cctrng.o: in function `cctrng_probe':
>> cctrng.c:(.text+0x36f): undefined reference to `devm_ioremap_resource'
collect2: error: ld returned 1 exit status
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 5154 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* hwrng: cctrng - Add dependency on HAS_IOMEM
2020-04-20 13:56 [cryptodev:master 7/26] cctrng.c:undefined reference to `devm_ioremap_resource' kbuild test robot
@ 2020-04-21 5:42 ` Herbert Xu
2020-04-21 7:57 ` Hadar Gat
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2020-04-21 5:42 UTC (permalink / raw)
To: kbuild test robot; +Cc: Hadar Gat, kbuild-all, linux-crypto
On Mon, Apr 20, 2020 at 09:56:47PM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: 3357b61177a7f34267256098b29a7f4992af40f3
> commit: a583ed310bb6b514e717c11a30b5a7bc3a65d1b1 [7/26] hwrng: cctrng - introduce Arm CryptoCell driver
> config: um-kunit_defconfig (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce:
> git checkout a583ed310bb6b514e717c11a30b5a7bc3a65d1b1
> # save the attached .config to linux build tree
> make ARCH=um
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> /usr/bin/ld: drivers/char/hw_random/cctrng.o: in function `cctrng_probe':
> >> cctrng.c:(.text+0x36f): undefined reference to `devm_ioremap_resource'
> collect2: error: ld returned 1 exit status
This should fix the problem:
---8<---
The cctrng doesn't compile without HAS_IOMEM so we should depend
on it.
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 848f26f78dc1..0c99735df694 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -476,6 +476,7 @@ config HW_RANDOM_KEYSTONE
config HW_RANDOM_CCTRNG
tristate "Arm CryptoCell True Random Number Generator support"
+ depends on HAS_IOMEM
default HW_RANDOM
help
This driver provides support for the True Random Number
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: hwrng: cctrng - Add dependency on HAS_IOMEM
2020-04-21 5:42 ` hwrng: cctrng - Add dependency on HAS_IOMEM Herbert Xu
@ 2020-04-21 7:57 ` Hadar Gat
0 siblings, 0 replies; 3+ messages in thread
From: Hadar Gat @ 2020-04-21 7:57 UTC (permalink / raw)
To: Herbert Xu, kbuild test robot; +Cc: nd, kbuild-all, linux-crypto
> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Tuesday, 21 April 2020 8:42
>
> On Mon, Apr 20, 2020 at 09:56:47PM +0800, kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-
> 2.6.git master
> > head: 3357b61177a7f34267256098b29a7f4992af40f3
> > commit: a583ed310bb6b514e717c11a30b5a7bc3a65d1b1 [7/26] hwrng:
> cctrng
> > - introduce Arm CryptoCell driver
> > config: um-kunit_defconfig (attached as .config)
> > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> > reproduce:
> > git checkout a583ed310bb6b514e717c11a30b5a7bc3a65d1b1
> > # save the attached .config to linux build tree
> > make ARCH=um
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > /usr/bin/ld: drivers/char/hw_random/cctrng.o: in function `cctrng_probe':
> > >> cctrng.c:(.text+0x36f): undefined reference to
> `devm_ioremap_resource'
> > collect2: error: ld returned 1 exit status
>
> This should fix the problem:
>
> ---8<---
> The cctrng doesn't compile without HAS_IOMEM so we should depend on it.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/char/hw_random/Kconfig
> b/drivers/char/hw_random/Kconfig index 848f26f78dc1..0c99735df694
> 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -476,6 +476,7 @@ config HW_RANDOM_KEYSTONE
>
> config HW_RANDOM_CCTRNG
> tristate "Arm CryptoCell True Random Number Generator support"
> + depends on HAS_IOMEM
> default HW_RANDOM
> help
> This driver provides support for the True Random Number
> --
Thank you Herbert.
Acked-by: Hadar Gat <hadar.gat@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 13:56 [cryptodev:master 7/26] cctrng.c:undefined reference to `devm_ioremap_resource' kbuild test robot
2020-04-21 5:42 ` hwrng: cctrng - Add dependency on HAS_IOMEM Herbert Xu
2020-04-21 7:57 ` Hadar Gat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).