From: Herbert Xu <herbert@gondor.apana.org.au>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
wangzhou1 <wangzhou1@hisilicon.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
kbuild-all@lists.01.org
Subject: Re: [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy
Date: Fri, 5 Jun 2020 22:17:03 +1000 [thread overview]
Message-ID: <20200605121703.GA3792@gondor.apana.org.au> (raw)
In-Reply-To: <f8dceec5-6835-c064-bb43-fd12668c2dbb@linaro.org>
On Fri, Jun 05, 2020 at 05:34:32PM +0800, Zhangfei Gao wrote:
> Will add a check after the copy.
>
> strlcpy(interface.name, pdev->driver->name, sizeof(interface.name));
> if (strlen(pdev->driver->name) != strlen(interface.name))
> return -EINVAL;
You don't need to do strlen. The function strlcpy returns the
length of the source string.
Better yet use strscpy which will even return an error for you.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-06-05 12:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202006032110.BEbKqovX%lkp@intel.com>
2020-06-04 3:32 ` [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy Zhangfei Gao
2020-06-04 3:39 ` Herbert Xu
2020-06-04 6:10 ` Zhangfei Gao
2020-06-04 6:18 ` Herbert Xu
2020-06-04 6:44 ` Zhangfei Gao
2020-06-04 6:50 ` Herbert Xu
2020-06-04 13:52 ` Zhou Wang
2020-06-05 9:34 ` Zhangfei Gao
2020-06-05 12:17 ` Herbert Xu [this message]
2020-06-05 15:26 ` Zhangfei Gao
2020-06-05 15:49 ` Eric Biggers
2020-06-06 1:42 ` Zhangfei Gao
2020-06-07 13:03 ` David Laight
2020-06-10 6:56 ` Eric Biggers
2020-06-15 3:38 ` [PATCH v2] crypto: hisilicon - fix strncpy warning with strscpy Zhangfei Gao
2020-06-26 6:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605121703.GA3792@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jonathan.Cameron@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).