From: David Laight <David.Laight@ACULAB.COM>
To: 'Herbert Xu' <herbert@gondor.apana.org.au>,
Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
wangzhou1 <wangzhou1@hisilicon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>
Subject: RE: [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy
Date: Sun, 7 Jun 2020 13:03:45 +0000 [thread overview]
Message-ID: <8c0d8f4e21794d8b80d0a3852830debb@AcuMS.aculab.com> (raw)
In-Reply-To: <20200605121703.GA3792@gondor.apana.org.au>
From: Herbert Xu
> Sent: 05 June 2020 13:17
...
> Better yet use strscpy which will even return an error for you.
It really ought to return the buffer length on truncation.
Then you can loop:
while(...)
buf += strxxxcpy(buf, src, buf_end - buf);
and only check right at the end.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-06-07 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202006032110.BEbKqovX%lkp@intel.com>
2020-06-04 3:32 ` [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy Zhangfei Gao
2020-06-04 3:39 ` Herbert Xu
2020-06-04 6:10 ` Zhangfei Gao
2020-06-04 6:18 ` Herbert Xu
2020-06-04 6:44 ` Zhangfei Gao
2020-06-04 6:50 ` Herbert Xu
2020-06-04 13:52 ` Zhou Wang
2020-06-05 9:34 ` Zhangfei Gao
2020-06-05 12:17 ` Herbert Xu
2020-06-05 15:26 ` Zhangfei Gao
2020-06-05 15:49 ` Eric Biggers
2020-06-06 1:42 ` Zhangfei Gao
2020-06-07 13:03 ` David Laight [this message]
2020-06-10 6:56 ` Eric Biggers
2020-06-15 3:38 ` [PATCH v2] crypto: hisilicon - fix strncpy warning with strscpy Zhangfei Gao
2020-06-26 6:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0d8f4e21794d8b80d0a3852830debb@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).