* [PATCH] crypto: virtio - don't use 'default m'
@ 2020-08-12 19:20 Eric Biggers
2020-08-21 8:01 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2020-08-12 19:20 UTC (permalink / raw)
To: Gonglei, Michael S . Tsirkin, Jason Wang, virtualization
Cc: linux-crypto, Ram Muthiah
From: Ram Muthiah <rammuthiah@google.com>
Drivers shouldn't be enabled by default unless there is a very good
reason to do so. There doesn't seem to be any such reason for the
virtio crypto driver, so change it to the default of 'n'.
Signed-off-by: Ram Muthiah <rammuthiah@google.com>
[EB: adjusted commit message]
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
drivers/crypto/virtio/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig
index fb294174e408..b894e3a8be4f 100644
--- a/drivers/crypto/virtio/Kconfig
+++ b/drivers/crypto/virtio/Kconfig
@@ -5,7 +5,6 @@ config CRYPTO_DEV_VIRTIO
select CRYPTO_AEAD
select CRYPTO_SKCIPHER
select CRYPTO_ENGINE
- default m
help
This driver provides support for virtio crypto device. If you
choose 'M' here, this module will be called virtio_crypto.
--
2.28.0.236.gb10cc79966-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: virtio - don't use 'default m'
2020-08-12 19:20 [PATCH] crypto: virtio - don't use 'default m' Eric Biggers
@ 2020-08-21 8:01 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-08-21 8:01 UTC (permalink / raw)
To: Eric Biggers
Cc: arei.gonglei, mst, jasowang, virtualization, linux-crypto, rammuthiah
Eric Biggers <ebiggers@kernel.org> wrote:
> From: Ram Muthiah <rammuthiah@google.com>
>
> Drivers shouldn't be enabled by default unless there is a very good
> reason to do so. There doesn't seem to be any such reason for the
> virtio crypto driver, so change it to the default of 'n'.
>
> Signed-off-by: Ram Muthiah <rammuthiah@google.com>
> [EB: adjusted commit message]
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> drivers/crypto/virtio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-21 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 19:20 [PATCH] crypto: virtio - don't use 'default m' Eric Biggers
2020-08-21 8:01 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).