From: Herbert Xu <herbert@gondor.apana.org.au>
To: Denis Kenzior <denkenz@gmail.com>
Cc: Andrew Zaborowski <andrew.zaborowski@intel.com>,
Ard Biesheuvel <ardb@kernel.org>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Caleb Jorden <caljorden@hotmail.com>,
Sasha Levin <sashal@kernel.org>,
iwd@lists.01.org, "# 3.4.x" <stable@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise
Date: Thu, 27 Aug 2020 00:19:08 +1000 [thread overview]
Message-ID: <20200826141907.GA5111@gondor.apana.org.au> (raw)
In-Reply-To: <c27e5303-48d9-04a4-4e73-cfea5470f357@gmail.com>
On Wed, Aug 26, 2020 at 08:57:17AM -0500, Denis Kenzior wrote:
>
> I'm just waking up now, so I might seem dense, but for my education, can you
> tell me why we need to set MSG_MORE when we issue just a single sendmsg
> followed immediately by recv/recvmsg? ell/iwd operates on small buffers, so
> we don't really feed the kernel data in multiple send operations. You can
> see this in the ell git tree link referenced in Andrew's reply.
You obviously don't need MSG_MORE if you're doing a single sendmsg.
The problematic code is in l_cipher_set_iv. It does a sendmsg(2)
that expects to be followed by more sendmsg(2) calls before a
recvmsg(2). That's the one that needs a MSG_MORE.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-08-26 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200826055150.2753.90553@ml01.vlan13.01.org>
2020-08-26 6:18 ` Issue with iwd + Linux 5.8.3 + WPA Enterprise Paul Menzel
2020-08-26 10:40 ` Ard Biesheuvel
2020-08-26 11:49 ` Herbert Xu
2020-08-26 11:59 ` Ard Biesheuvel
2020-08-26 12:08 ` Herbert Xu
2020-08-26 12:58 ` Andrew Zaborowski
2020-08-26 13:00 ` Herbert Xu
2020-08-26 13:57 ` Denis Kenzior
2020-08-26 14:19 ` Herbert Xu [this message]
2020-08-26 15:25 ` Denis Kenzior
2020-08-26 15:42 ` Ard Biesheuvel
2020-08-26 22:19 ` Herbert Xu
2020-08-27 6:40 ` Ard Biesheuvel
2020-08-27 7:14 ` [v2 PATCH] crypto: af_alg - Work around empty control messages without MSG_MORE Herbert Xu
2020-08-27 7:40 ` Ard Biesheuvel
[not found] ` <BL0PR11MB329980406FA0A14A8EF61A07B9550@BL0PR11MB3299.namprd11.prod.outlook.com>
2020-08-27 7:54 ` Issue with iwd + Linux 5.8.3 + WPA Enterprise Ard Biesheuvel
2020-08-26 13:29 ` [PATCH] crypto: af_alg - Work around empty control messages without MSG_MORE Herbert Xu
2020-08-26 13:56 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826141907.GA5111@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andrew.zaborowski@intel.com \
--cc=ardb@kernel.org \
--cc=caljorden@hotmail.com \
--cc=davem@davemloft.net \
--cc=denkenz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iwd@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).