* [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc
2020-09-03 18:03 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Krzysztof Kozlowski
@ 2020-09-03 18:03 ` Krzysztof Kozlowski
2020-09-04 9:07 ` Kamil Konieczny
2020-09-11 6:59 ` Herbert Xu
2020-09-03 18:04 ` [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-03 18:03 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vladimir Zapolskiy, Kamil Konieczny,
Herbert Xu, David S. Miller, Rob Herring, linux-crypto,
linux-samsung-soc, devicetree, linux-kernel
Add missing and fix existing kerneldoc to silence W=1 warnings:
drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'
drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'
drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'
drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'
drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/crypto/s5p-sss.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 341433fbcc4a..f67f1e22ecd1 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -260,6 +260,7 @@ struct s5p_aes_ctx {
* struct s5p_aes_dev - Crypto device state container
* @dev: Associated device
* @clk: Clock for accessing hardware
+ * @pclk: APB bus clock necessary to access the hardware
* @ioaddr: Mapped IO memory region
* @aes_ioaddr: Per-varian offset for AES block IO memory
* @irq_fc: Feed control interrupt line
@@ -342,13 +343,13 @@ struct s5p_aes_dev {
* @engine: Bits for selecting type of HASH in SSS block
* @sg: sg for DMA transfer
* @sg_len: Length of sg for DMA transfer
- * @sgl[]: sg for joining buffer and req->src scatterlist
+ * @sgl: sg for joining buffer and req->src scatterlist
* @skip: Skip offset in req->src for current op
* @total: Total number of bytes for current request
* @finup: Keep state for finup or final.
* @error: Keep track of error.
* @bufcnt: Number of bytes holded in buffer[]
- * @buffer[]: For byte(s) from end of req->src in UPDATE op
+ * @buffer: For byte(s) from end of req->src in UPDATE op
*/
struct s5p_hash_reqctx {
struct s5p_aes_dev *dd;
@@ -1125,7 +1126,7 @@ static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx,
* s5p_hash_prepare_sgs() - prepare sg for processing
* @ctx: request context
* @sg: source scatterlist request
- * @nbytes: number of bytes to process from sg
+ * @new_len: number of bytes to process from sg
* @final: final flag
*
* Check two conditions: (1) if buffers in sg have len aligned data, and (2)
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc
2020-09-03 18:03 ` [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc Krzysztof Kozlowski
@ 2020-09-04 9:07 ` Kamil Konieczny
2020-09-11 6:59 ` Herbert Xu
1 sibling, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2020-09-04 9:07 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vladimir Zapolskiy, Herbert Xu,
David S. Miller, Rob Herring, linux-crypto, linux-samsung-soc,
devicetree, linux-kernel
On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> Add missing and fix existing kerneldoc to silence W=1 warnings:
>
> drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'
> drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'
> drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'
> drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'
> drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/crypto/s5p-sss.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 341433fbcc4a..f67f1e22ecd1 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -260,6 +260,7 @@ struct s5p_aes_ctx {
> * struct s5p_aes_dev - Crypto device state container
> * @dev: Associated device
> * @clk: Clock for accessing hardware
> + * @pclk: APB bus clock necessary to access the hardware
> * @ioaddr: Mapped IO memory region
> * @aes_ioaddr: Per-varian offset for AES block IO memory
> * @irq_fc: Feed control interrupt line
> @@ -342,13 +343,13 @@ struct s5p_aes_dev {
> * @engine: Bits for selecting type of HASH in SSS block
> * @sg: sg for DMA transfer
> * @sg_len: Length of sg for DMA transfer
> - * @sgl[]: sg for joining buffer and req->src scatterlist
> + * @sgl: sg for joining buffer and req->src scatterlist
> * @skip: Skip offset in req->src for current op
> * @total: Total number of bytes for current request
> * @finup: Keep state for finup or final.
> * @error: Keep track of error.
> * @bufcnt: Number of bytes holded in buffer[]
> - * @buffer[]: For byte(s) from end of req->src in UPDATE op
> + * @buffer: For byte(s) from end of req->src in UPDATE op
> */
> struct s5p_hash_reqctx {
> struct s5p_aes_dev *dd;
> @@ -1125,7 +1126,7 @@ static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx,
> * s5p_hash_prepare_sgs() - prepare sg for processing
> * @ctx: request context
> * @sg: source scatterlist request
> - * @nbytes: number of bytes to process from sg
> + * @new_len: number of bytes to process from sg
> * @final: final flag
> *
> * Check two conditions: (1) if buffers in sg have len aligned data, and (2)
>
Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc
2020-09-03 18:03 ` [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc Krzysztof Kozlowski
2020-09-04 9:07 ` Kamil Konieczny
@ 2020-09-11 6:59 ` Herbert Xu
1 sibling, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2020-09-11 6:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vladimir Zapolskiy, Kamil Konieczny, David S. Miller,
Rob Herring, linux-crypto, linux-samsung-soc, devicetree,
linux-kernel
On Thu, Sep 03, 2020 at 08:03:59PM +0200, Krzysztof Kozlowski wrote:
> Add missing and fix existing kerneldoc to silence W=1 warnings:
>
> drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'
> drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'
> drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'
> drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'
> drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/crypto/s5p-sss.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral
2020-09-03 18:03 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Krzysztof Kozlowski
2020-09-03 18:03 ` [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc Krzysztof Kozlowski
@ 2020-09-03 18:04 ` Krzysztof Kozlowski
2020-09-04 9:06 ` Kamil Konieczny
2020-09-11 6:59 ` Herbert Xu
2020-09-04 9:07 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Kamil Konieczny
2020-09-14 20:34 ` Rob Herring
3 siblings, 2 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-03 18:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vladimir Zapolskiy, Kamil Konieczny,
Herbert Xu, David S. Miller, Rob Herring, linux-crypto,
linux-samsung-soc, devicetree, linux-kernel
Pass the error directly from devm_clk_get() to describe the real reason,
instead of fixed ENOENT. Do not print error messages on deferred probe.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/crypto/s5p-sss.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index f67f1e22ecd1..e83145c43b18 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
}
pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
- if (IS_ERR(pdata->clk)) {
- dev_err(dev, "failed to find secss clock %s\n",
- variant->clk_names[0]);
- return -ENOENT;
- }
+ if (IS_ERR(pdata->clk))
+ return dev_err_probe(dev, PTR_ERR(pdata->clk),
+ "failed to find secss clock %s\n",
+ variant->clk_names[0]);
err = clk_prepare_enable(pdata->clk);
if (err < 0) {
@@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
if (variant->clk_names[1]) {
pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
if (IS_ERR(pdata->pclk)) {
- dev_err(dev, "failed to find clock %s\n",
- variant->clk_names[1]);
- err = -ENOENT;
+ err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
+ "failed to find clock %s\n",
+ variant->clk_names[1]);
goto err_clk;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral
2020-09-03 18:04 ` [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral Krzysztof Kozlowski
@ 2020-09-04 9:06 ` Kamil Konieczny
2020-09-11 6:59 ` Herbert Xu
1 sibling, 0 replies; 10+ messages in thread
From: Kamil Konieczny @ 2020-09-04 9:06 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vladimir Zapolskiy, Herbert Xu,
David S. Miller, Rob Herring, linux-crypto, linux-samsung-soc,
devicetree, linux-kernel
On 9/3/20 8:04 PM, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT. Do not print error messages on deferred probe.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/crypto/s5p-sss.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index f67f1e22ecd1..e83145c43b18 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
> }
>
> pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
> - if (IS_ERR(pdata->clk)) {
> - dev_err(dev, "failed to find secss clock %s\n",
> - variant->clk_names[0]);
> - return -ENOENT;
> - }
> + if (IS_ERR(pdata->clk))
> + return dev_err_probe(dev, PTR_ERR(pdata->clk),
> + "failed to find secss clock %s\n",
> + variant->clk_names[0]);
>
> err = clk_prepare_enable(pdata->clk);
> if (err < 0) {
> @@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
> if (variant->clk_names[1]) {
> pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
> if (IS_ERR(pdata->pclk)) {
> - dev_err(dev, "failed to find clock %s\n",
> - variant->clk_names[1]);
> - err = -ENOENT;
> + err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
> + "failed to find clock %s\n",
> + variant->clk_names[1]);
> goto err_clk;
> }
>
>
Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral
2020-09-03 18:04 ` [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral Krzysztof Kozlowski
2020-09-04 9:06 ` Kamil Konieczny
@ 2020-09-11 6:59 ` Herbert Xu
1 sibling, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2020-09-11 6:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vladimir Zapolskiy, Kamil Konieczny, David S. Miller,
Rob Herring, linux-crypto, linux-samsung-soc, devicetree,
linux-kernel
On Thu, Sep 03, 2020 at 08:04:00PM +0200, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT. Do not print error messages on deferred probe.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/crypto/s5p-sss.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible
2020-09-03 18:03 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Krzysztof Kozlowski
2020-09-03 18:03 ` [PATCH 2/3] crypto: s5p-sss - Add and fix kerneldoc Krzysztof Kozlowski
2020-09-03 18:04 ` [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral Krzysztof Kozlowski
@ 2020-09-04 9:07 ` Kamil Konieczny
2020-09-04 9:17 ` Krzysztof Kozlowski
2020-09-14 20:34 ` Rob Herring
3 siblings, 1 reply; 10+ messages in thread
From: Kamil Konieczny @ 2020-09-04 9:07 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vladimir Zapolskiy, Herbert Xu,
David S. Miller, Rob Herring, linux-crypto, linux-samsung-soc,
devicetree, linux-kernel
On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> Correct a typo in the compatible - missing trailing 's'.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> index 04fe5dfa794a..7743eae049ab 100644
> --- a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> +++ b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> @@ -19,7 +19,7 @@ description: |+
> properties:
> compatible:
> items:
> - - const: samsung,exynos5433-slim-ss
> + - const: samsung,exynos5433-slim-sss
>
> reg:
> maxItems: 1
>
Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible
2020-09-04 9:07 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Kamil Konieczny
@ 2020-09-04 9:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-04 9:17 UTC (permalink / raw)
To: Kamil Konieczny
Cc: Vladimir Zapolskiy, Herbert Xu, David S. Miller, Rob Herring,
linux-crypto, linux-samsung-soc, devicetree, linux-kernel
On Fri, 4 Sep 2020 at 11:07, Kamil Konieczny <k.konieczny@samsung.com> wrote:
>
>
>
> On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> > Correct a typo in the compatible - missing trailing 's'.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> > index 04fe5dfa794a..7743eae049ab 100644
> > --- a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> > @@ -19,7 +19,7 @@ description: |+
> > properties:
> > compatible:
> > items:
> > - - const: samsung,exynos5433-slim-ss
> > + - const: samsung,exynos5433-slim-sss
> >
> > reg:
> > maxItems: 1
> >
>
> Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
> Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
Thanks. In this case "Reviewed" is enough, it includes the meaning of Ack.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible
2020-09-03 18:03 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Krzysztof Kozlowski
` (2 preceding siblings ...)
2020-09-04 9:07 ` [PATCH 1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible Kamil Konieczny
@ 2020-09-14 20:34 ` Rob Herring
3 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-09-14 20:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, David S. Miller, Vladimir Zapolskiy, linux-kernel,
Kamil Konieczny, linux-crypto, Rob Herring, linux-samsung-soc,
Herbert Xu
On Thu, 03 Sep 2020 20:03:58 +0200, Krzysztof Kozlowski wrote:
> Correct a typo in the compatible - missing trailing 's'.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread