* [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device
@ 2020-10-16 9:05 Zhang Qilong
2020-10-30 6:51 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Zhang Qilong @ 2020-10-16 9:05 UTC (permalink / raw)
To: herbert, davem; +Cc: linux-crypto
pm_runtime_get_sync() will increment pm usage counter even
when it returns an error code. We should call put operation
in error handling paths of omap_aes_hw_init.
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/crypto/omap-aes.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 4fd14d90cc40..70ea5784a024 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -105,6 +105,7 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd)
err = pm_runtime_get_sync(dd->dev);
if (err < 0) {
+ pm_runtime_put_noidle(dd->dev);
dev_err(dd->dev, "failed to get sync: %d\n", err);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device
2020-10-16 9:05 [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device Zhang Qilong
@ 2020-10-30 6:51 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-10-30 6:51 UTC (permalink / raw)
To: Zhang Qilong; +Cc: davem, linux-crypto
On Fri, Oct 16, 2020 at 05:05:36PM +0800, Zhang Qilong wrote:
> pm_runtime_get_sync() will increment pm usage counter even
> when it returns an error code. We should call put operation
> in error handling paths of omap_aes_hw_init.
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/crypto/omap-aes.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device
2020-10-27 13:25 Zhang Qilong
@ 2020-11-06 3:30 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-11-06 3:30 UTC (permalink / raw)
To: Zhang Qilong; +Cc: davem, linux-crypto
On Tue, Oct 27, 2020 at 09:25:10PM +0800, Zhang Qilong wrote:
> pm_runtime_get_sync() will increment pm usage counter even
> when it returns an error code. We should call put operation
> in error handling paths of omap_aes_hw_init.
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/crypto/omap-aes.c | 1 +
> 1 file changed, 1 insertion(+)
Your patch has already been applied:
commit 383e8a823014532ffd81c787ef9009f1c2bd3b79
Author: Zhang Qilong <zhangqilong3@huawei.com>
Date: Fri Oct 16 17:05:36 2020 +0800
crypto: omap-aes - fix the reference count leak of omap device
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device
@ 2020-10-27 13:25 Zhang Qilong
2020-11-06 3:30 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Zhang Qilong @ 2020-10-27 13:25 UTC (permalink / raw)
To: herbert, davem; +Cc: linux-crypto
pm_runtime_get_sync() will increment pm usage counter even
when it returns an error code. We should call put operation
in error handling paths of omap_aes_hw_init.
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/crypto/omap-aes.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 4fd14d90cc40..70ea5784a024 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -105,6 +105,7 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd)
err = pm_runtime_get_sync(dd->dev);
if (err < 0) {
+ pm_runtime_put_noidle(dd->dev);
dev_err(dd->dev, "failed to get sync: %d\n", err);
return err;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-06 3:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 9:05 [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device Zhang Qilong
2020-10-30 6:51 ` Herbert Xu
2020-10-27 13:25 Zhang Qilong
2020-11-06 3:30 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).