* [PATCH -next] crypto: atmel-sha: discard unnecessary break
@ 2020-10-26 13:48 Zhang Qilong
2020-10-26 20:44 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Qilong @ 2020-10-26 13:48 UTC (permalink / raw)
To: herbert, davem
Cc: nicolas.ferre, alexandre.belloni, ludovic.desroches, linux-crypto
The 'break' is unnecessary because of previous
'return', discard it.
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/crypto/atmel-sha.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 75ccf41a7cb9..0eb6f54e3b66 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
break;
default:
return -EINVAL;
- break;
}
ctx->bufcnt = 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] crypto: atmel-sha: discard unnecessary break
2020-10-26 13:48 [PATCH -next] crypto: atmel-sha: discard unnecessary break Zhang Qilong
@ 2020-10-26 20:44 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-10-26 20:44 UTC (permalink / raw)
To: Zhang Qilong
Cc: herbert, davem, nicolas.ferre, ludovic.desroches, linux-crypto
Hi,
On 26/10/2020 21:48:07+0800, Zhang Qilong wrote:
> The 'break' is unnecessary because of previous
> 'return', discard it.
>
This is a duplicate of https://lore.kernel.org/linux-crypto/20201019193653.13757-1-trix@redhat.com/T/#u
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/crypto/atmel-sha.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 75ccf41a7cb9..0eb6f54e3b66 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
> break;
> default:
> return -EINVAL;
> - break;
> }
>
> ctx->bufcnt = 0;
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-26 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 13:48 [PATCH -next] crypto: atmel-sha: discard unnecessary break Zhang Qilong
2020-10-26 20:44 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).