* Re: problem with ccp-crypto module on apu
[not found] <em96a2a8ae-80a7-4608-905e-5d932c0cf9bb@domen1-pc>
@ 2020-12-28 15:22 ` John Allen
2021-01-04 14:36 ` Tom Lendacky
0 siblings, 1 reply; 7+ messages in thread
From: John Allen @ 2020-12-28 15:22 UTC (permalink / raw)
To: Domen Stangar; +Cc: linux-crypto, thomas.lendacky
On Thu, Dec 17, 2020 at 07:42:52AM +0000, Domen Stangar wrote:
> Hi,
> I would like to report issue with ccp-crypto.
> When I issue modprobe command, it would not continue, without SIGINT signal
> (ctrl+c).
> If module is compiled in kernel, boot doesn't finish.
> Looks like problem is that ecb(aes) selftest do not finish ?
Hi Domen,
Thanks for reporting this issue. I'll look into this as soon as
possible. Once I can track down some hardware, I'll reproduce and debug.
Thanks,
John
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: problem with ccp-crypto module on apu
2020-12-28 15:22 ` problem with ccp-crypto module on apu John Allen
@ 2021-01-04 14:36 ` Tom Lendacky
2021-01-04 16:10 ` Re[2]: " Domen Stangar
0 siblings, 1 reply; 7+ messages in thread
From: Tom Lendacky @ 2021-01-04 14:36 UTC (permalink / raw)
To: John Allen, Domen Stangar; +Cc: linux-crypto
On 12/28/20 9:22 AM, John Allen wrote:
> On Thu, Dec 17, 2020 at 07:42:52AM +0000, Domen Stangar wrote:
>> Hi,
>> I would like to report issue with ccp-crypto.
>> When I issue modprobe command, it would not continue, without SIGINT signal
>> (ctrl+c).
>> If module is compiled in kernel, boot doesn't finish.
>> Looks like problem is that ecb(aes) selftest do not finish ?
>
> Hi Domen,
>
> Thanks for reporting this issue. I'll look into this as soon as
> possible. Once I can track down some hardware, I'll reproduce and debug.
Domen, do you have the debugfs support enabled? Could you supply the
output from /sys/kernel/debug/ccp/ccp-X/info (where X is replaced with
each of the present ccp ordinal values)?
Thanks,
Tom
>
> Thanks,
> John
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re[2]: problem with ccp-crypto module on apu
2021-01-04 14:36 ` Tom Lendacky
@ 2021-01-04 16:10 ` Domen Stangar
2021-01-07 15:10 ` John Allen
0 siblings, 1 reply; 7+ messages in thread
From: Domen Stangar @ 2021-01-04 16:10 UTC (permalink / raw)
To: Tom Lendacky, John Allen; +Cc: linux-crypto
Device name: ccp-1
RNG name: ccp-1-rng
# Queues: 3
# Cmds: 0
Version: 5
Engines: AES 3DES SHA RSA ECC ZDE TRNG
Queues: 5
LSB Entries: 128
Let me know if you need anything else.
Domen
>Domen, do you have the debugfs support enabled? Could you supply the output from /sys/kernel/debug/ccp/ccp-X/info (where X is replaced with each of the present ccp ordinal values)?
>
>Thanks,
>Tom
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: problem with ccp-crypto module on apu
2021-01-04 16:10 ` Re[2]: " Domen Stangar
@ 2021-01-07 15:10 ` John Allen
2021-01-17 10:16 ` Re[2]: " Domen Stangar
0 siblings, 1 reply; 7+ messages in thread
From: John Allen @ 2021-01-07 15:10 UTC (permalink / raw)
To: Domen Stangar; +Cc: Tom Lendacky, linux-crypto
On Mon, Jan 04, 2021 at 04:10:26PM +0000, Domen Stangar wrote:
> Device name: ccp-1
> RNG name: ccp-1-rng
> # Queues: 3
> # Cmds: 0
> Version: 5
> Engines: AES 3DES SHA RSA ECC ZDE TRNG
> Queues: 5
> LSB Entries: 128
>
> Let me know if you need anything else.
Hi Domen,
Looks like we may have a lead on this problem.
Could you provide the following when you're loading the module?
dmesg
/proc/interrupts
/sys/kernel/debug/ccp/ccp-1/stats
Thanks,
John
> Domen
>
> > Domen, do you have the debugfs support enabled? Could you supply the output from /sys/kernel/debug/ccp/ccp-X/info (where X is replaced with each of the present ccp ordinal values)?
> >
> > Thanks,
> > Tom
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re[2]: problem with ccp-crypto module on apu
2021-01-07 15:10 ` John Allen
@ 2021-01-17 10:16 ` Domen Stangar
2021-01-20 15:25 ` Tom Lendacky
0 siblings, 1 reply; 7+ messages in thread
From: Domen Stangar @ 2021-01-17 10:16 UTC (permalink / raw)
To: John Allen; +Cc: Tom Lendacky, linux-crypto
[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]
Sorry for late answer, somewhat missed mail.
dmesg last lines that where added
[ 325.691756] ccp 0000:0a:00.2: enabling device (0000 -> 0002)
[ 325.692217] ccp 0000:0a:00.2: ccp enabled
[ 325.702401] ccp 0000:0a:00.2: tee enabled
[ 325.702405] ccp 0000:0a:00.2: psp enabled
/sys/kernel/debug/ccp/ccp-1/stats
Total Interrupts Handled: 0
Total Operations: 1
AES: 0
XTS AES: 0
SHA: 0
SHA: 0
RSA: 0
Pass-Thru: 1
ECC: 0
interrupts output attached.
Domen
------ Original Message ------
From: "John Allen" <john.allen@amd.com>
To: "Domen Stangar" <domen.stangar@gmail.com>
Cc: "Tom Lendacky" <thomas.lendacky@amd.com>;
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Sent: 07/01/2021 17:10:50
Subject: Re: problem with ccp-crypto module on apu
>On Mon, Jan 04, 2021 at 04:10:26PM +0000, Domen Stangar wrote:
>> Device name: ccp-1
>> RNG name: ccp-1-rng
>> # Queues: 3
>> # Cmds: 0
>> Version: 5
>> Engines: AES 3DES SHA RSA ECC ZDE TRNG
>> Queues: 5
>> LSB Entries: 128
>>
>> Let me know if you need anything else.
>
>Hi Domen,
>
>Looks like we may have a lead on this problem.
>
>Could you provide the following when you're loading the module?
>
>dmesg
>/proc/interrupts
>/sys/kernel/debug/ccp/ccp-1/stats
>
>Thanks,
>John
>
>> Domen
>>
>> > Domen, do you have the debugfs support enabled? Could you supply the output from /sys/kernel/debug/ccp/ccp-X/info (where X is replaced with each of the present ccp ordinal values)?
>> >
>> > Thanks,
>> > Tom
>> >
>>
[-- Attachment #2: interrupts --]
[-- Type: application/octet-stream, Size: 6266 bytes --]
CPU0 CPU1 CPU2 CPU3
0: 33 0 0 0 IR-IO-APIC 2-edge timer
8: 0 1 0 0 IR-IO-APIC 8-edge rtc0
9: 0 0 0 0 IR-IO-APIC 9-fasteoi acpi
25: 0 0 0 0 PCI-MSI 4096-edge AMD-Vi
26: 0 0 0 0 IR-PCI-MSI 20480-edge PCIe PME, aerdrv, PCIe BW notif
27: 0 0 0 0 IR-PCI-MSI 22528-edge PCIe PME, aerdrv, PCIe BW notif
28: 0 0 0 0 IR-PCI-MSI 133120-edge PCIe PME, PCIe BW notif
29: 0 0 0 0 IR-PCI-MSI 135168-edge PCIe PME, aerdrv, PCIe BW notif
33: 0 0 0 0 IR-PCI-MSI 1048576-edge PCIe BW notif
35: 0 0 0 0 IR-PCI-MSI 1064960-edge PCIe BW notif
36: 0 0 0 0 IR-PCI-MSI 1114112-edge PCIe BW notif
37: 0 0 0 0 IR-PCI-MSI 1130496-edge PCIe BW notif
38: 0 0 0 0 IR-PCI-MSI 1146880-edge PCIe BW notif
40: 0 0 0 0 IR-PCI-MSI 1163264-edge PCIe BW notif
42: 0 0 0 19 IR-PCI-MSI 4718592-edge nvme0q0
43: 0 0 0 0 IR-PCI-MSI 526336-edge ahci[0000:01:00.1]
45: 0 0 0 0 IR-PCI-MSI 5767168-edge ahci0
46: 0 0 0 0 IR-PCI-MSI 5767169-edge ahci1
47: 1 0 0 0 IR-PCI-MSI 4194304-edge eth0
48: 0 817 0 0 IR-PCI-MSI 4194305-edge eth0-rx-0
49: 0 0 190 0 IR-PCI-MSI 4194306-edge eth0-rx-1
50: 0 0 0 691 IR-PCI-MSI 4194307-edge eth0-tx-0
51: 223 0 0 0 IR-PCI-MSI 4194308-edge eth0-tx-1
52: 0 0 32 0 IR-PCI-MSI 524288-edge xhci_hcd
54: 0 0 0 0 IR-PCI-MSI 5249024-edge xhci_hcd
55: 0 0 0 0 IR-PCI-MSI 5249025-edge xhci_hcd
56: 0 0 0 0 IR-PCI-MSI 5249026-edge xhci_hcd
57: 0 0 0 0 IR-PCI-MSI 5249027-edge xhci_hcd
58: 0 0 0 0 IR-PCI-MSI 5249028-edge xhci_hcd
60: 0 0 0 0 IR-PCI-MSI 5251072-edge xhci_hcd
61: 0 0 0 0 IR-PCI-MSI 5251073-edge xhci_hcd
62: 0 0 0 0 IR-PCI-MSI 5251074-edge xhci_hcd
63: 0 0 0 0 IR-PCI-MSI 5251075-edge xhci_hcd
64: 0 0 0 0 IR-PCI-MSI 5251076-edge xhci_hcd
66: 0 0 84 0 IR-PCI-MSI 5244928-edge snd_hda_intel:card0
67: 0 0 0 726 IR-PCI-MSI 5255168-edge snd_hda_intel:card1
68: 332 0 0 0 IR-PCI-MSI 4718593-edge nvme0q1
69: 0 4268 0 0 IR-PCI-MSI 4718594-edge nvme0q2
70: 0 0 519 0 IR-PCI-MSI 4718595-edge nvme0q3
71: 0 0 0 18842 IR-PCI-MSI 4718596-edge nvme0q4
72: 0 0 0 0 IR-PCI-MSI 4718597-edge nvme0q5
73: 0 0 0 0 IR-PCI-MSI 4718598-edge nvme0q6
74: 0 0 0 0 IR-PCI-MSI 4718599-edge nvme0q7
75: 0 0 0 0 IR-PCI-MSI 4718600-edge nvme0q8
76: 0 509 0 0 IR-PCI-MSI 5242880-edge amdgpu
77: 0 0 29 0 IR-PCI-MSI 3145728-edge iwlwifi: default queue
78: 0 0 0 0 IR-PCI-MSI 3145729-edge iwlwifi: queue 1
79: 0 0 0 0 IR-PCI-MSI 3145730-edge iwlwifi: queue 2
80: 0 0 0 0 IR-PCI-MSI 3145731-edge iwlwifi: queue 3
81: 0 0 0 0 IR-PCI-MSI 3145732-edge iwlwifi: queue 4
82: 0 0 0 11 IR-PCI-MSI 3145733-edge iwlwifi: exception
83: 0 0 0 0 IR-PCI-MSI 5246976-edge psp-1
84: 0 0 0 0 IR-PCI-MSI 5246977-edge ccp-1
NMI: 0 0 0 0 Non-maskable interrupts
LOC: 295073 178415 228228 264451 Local timer interrupts
SPU: 0 0 0 0 Spurious interrupts
PMI: 0 0 0 0 Performance monitoring interrupts
IWI: 0 0 0 0 IRQ work interrupts
RTR: 0 0 0 0 APIC ICR read retries
RES: 13974 15689 13047 11545 Rescheduling interrupts
CAL: 373 380 277 257 Function call interrupts
TLB: 78 235 38 155 TLB shootdowns
TRM: 0 0 0 0 Thermal event interrupts
THR: 0 0 0 0 Threshold APIC interrupts
DFR: 0 0 0 0 Deferred Error APIC interrupts
MCE: 0 0 0 0 Machine check exceptions
MCP: 2 2 2 2 Machine check polls
ERR: 305
MIS: 0
PIN: 0 0 0 0 Posted-interrupt notification event
NPI: 0 0 0 0 Nested posted-interrupt event
PIW: 0 0 0 0 Posted-interrupt wakeup event
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: problem with ccp-crypto module on apu
2021-01-17 10:16 ` Re[2]: " Domen Stangar
@ 2021-01-20 15:25 ` Tom Lendacky
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lendacky @ 2021-01-20 15:25 UTC (permalink / raw)
To: Domen Stangar, John Allen; +Cc: linux-crypto
On 1/17/21 4:16 AM, Domen Stangar wrote:
> Sorry for late answer, somewhat missed mail.
>
> dmesg last lines that where added
>
> [ 325.691756] ccp 0000:0a:00.2: enabling device (0000 -> 0002)
> [ 325.692217] ccp 0000:0a:00.2: ccp enabled
> [ 325.702401] ccp 0000:0a:00.2: tee enabled
> [ 325.702405] ccp 0000:0a:00.2: psp enabled
>
> /sys/kernel/debug/ccp/ccp-1/stats
> Total Interrupts Handled: 0
> Total Operations: 1
> AES: 0
> XTS AES: 0
> SHA: 0
> SHA: 0
> RSA: 0
> Pass-Thru: 1
> ECC: 0
>
> interrupts output attached.
Ok, the interrupts are not being delivered from the CCP (running in the
AMD Secure Processor or psp) to the x86. This is a BIOS/AGESA issue that
will require a BIOS fix. I don't know what level of AGESA it will be
delivered in and when your BIOS supplier would incorporate it, so my only
suggestion is to not use the ccp and ccp-crypto modules for now.
Thanks,
Tom
>
> Domen
>
> ------ Original Message ------
> From: "John Allen" <john.allen@amd.com>
> To: "Domen Stangar" <domen.stangar@gmail.com>
> Cc: "Tom Lendacky" <thomas.lendacky@amd.com>;
> "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
> Sent: 07/01/2021 17:10:50
> Subject: Re: problem with ccp-crypto module on apu
>
>> On Mon, Jan 04, 2021 at 04:10:26PM +0000, Domen Stangar wrote:
>>> Device name: ccp-1
>>> RNG name: ccp-1-rng
>>> # Queues: 3
>>> # Cmds: 0
>>> Version: 5
>>> Engines: AES 3DES SHA RSA ECC ZDE TRNG
>>> Queues: 5
>>> LSB Entries: 128
>>>
>>> Let me know if you need anything else.
>>
>> Hi Domen,
>>
>> Looks like we may have a lead on this problem.
>>
>> Could you provide the following when you're loading the module?
>>
>> dmesg
>> /proc/interrupts
>> /sys/kernel/debug/ccp/ccp-1/stats
>>
>> Thanks,
>> John
>>
>>> Domen
>>>
>>> > Domen, do you have the debugfs support enabled? Could you supply the
>>> output from /sys/kernel/debug/ccp/ccp-X/info (where X is replaced with
>>> each of the present ccp ordinal values)?
>>> >
>>> > Thanks,
>>> > Tom
>>> >
>>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* problem with ccp-crypto module on apu
@ 2020-12-17 7:52 Domen Stangar
0 siblings, 0 replies; 7+ messages in thread
From: Domen Stangar @ 2020-12-17 7:52 UTC (permalink / raw)
To: linux-crypto
Hi,
I would like to report issue with ccp-crypto.
When I issue modprobe command, it would not continue, without SIGINT
signal (ctrl+c).
If module is compiled in kernel, boot doesn't finish.
Looks like problem is that ecb(aes) selftest do not finish ?
kernel 5.10.1
smpboot: CPU0: AMD Athlon PRO 200GE w/ Radeon Vega Graphics (family:
0x17, model: 0x11, stepping: 0x0)
part of /proc/crypto
name : cfb(aes)
driver : cfb-aes-ccp
module : ccp_crypto
priority : 300
refcnt : 1
selftest : passed
internal : no
type : skcipher
async : yes
blocksize : 1
min keysize : 16
max keysize : 32
ivsize : 16
chunksize : 1
walksize : 1
name : cbc(aes)
driver : cbc-aes-ccp
module : ccp_crypto
priority : 300
refcnt : 1
selftest : passed
internal : no
type : skcipher
async : yes
blocksize : 16
min keysize : 16
max keysize : 32
ivsize : 16
chunksize : 16
walksize : 16
name : ecb(aes)
driver : ecb-aes-ccp
module : ccp_crypto
priority : 300
refcnt : 2
selftest : unknown
internal : no
type : skcipher
async : yes
blocksize : 16
min keysize : 16
max keysize : 32
ivsize : 0
chunksize : 16
walksize : 16
ccp-1/info
Device name: ccp-1
RNG name: ccp-1-rng
# Queues: 3
# Cmds: 0
Version: 5
Engines: AES 3DES SHA RSA ECC ZDE TRNG
Queues: 5
LSB Entries: 128
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-20 15:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <em96a2a8ae-80a7-4608-905e-5d932c0cf9bb@domen1-pc>
2020-12-28 15:22 ` problem with ccp-crypto module on apu John Allen
2021-01-04 14:36 ` Tom Lendacky
2021-01-04 16:10 ` Re[2]: " Domen Stangar
2021-01-07 15:10 ` John Allen
2021-01-17 10:16 ` Re[2]: " Domen Stangar
2021-01-20 15:25 ` Tom Lendacky
2020-12-17 7:52 Domen Stangar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).