From: Herbert Xu <herbert@gondor.apana.org.au>
To: matthias.bgg@kernel.org
Cc: mpm@selenic.com, rjui@broadcom.com, sbranden@broadcom.com,
f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
Julia.Lawall@inria.fr, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-crypto@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v2 2/2] hwrng: iproc-rng200: Move enable/disable in separate function
Date: Sun, 3 Jan 2021 09:08:42 +1100 [thread overview]
Message-ID: <20210102220842.GP12767@gondor.apana.org.au> (raw)
In-Reply-To: <20201218105708.28480-2-matthias.bgg@kernel.org>
On Fri, Dec 18, 2020 at 11:57:08AM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> We are calling the same code for enable and disable the block in various
> parts of the driver. Put that code into a new function to reduce code
> duplication.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
> ---
>
> Changes in v2:
> - rename function to iproc_rng200_enable_set()
> - use u32 value instead of uint32_t
>
> drivers/char/hw_random/iproc-rng200.c | 35 ++++++++++++---------------
> 1 file changed, 16 insertions(+), 19 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-01-02 22:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 10:57 [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block matthias.bgg
2020-12-18 10:57 ` [PATCH v2 2/2] hwrng: iproc-rng200: Move enable/disable in separate function matthias.bgg
2020-12-18 17:32 ` Scott Branden
2021-01-02 22:08 ` Herbert Xu [this message]
2020-12-18 17:30 ` [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block Scott Branden
2020-12-18 17:34 ` Florian Fainelli
2021-01-02 22:08 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210102220842.GP12767@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Julia.Lawall@inria.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mpm@selenic.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).