* [PATCH] crypto: octeontx2 - fix signedness bug in cptvf_register_interrupts()
@ 2021-01-27 5:25 Dan Carpenter
2021-02-05 3:38 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-01-27 5:25 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnaud Ebalard, Srujana Challa, Herbert Xu, David S. Miller,
Suheil Chandran, Lukasz Bartosik, linux-crypto, kernel-janitors
The "num_vec" has to be signed for the error handling to work.
Fixes: 19d8e8c7be15 ("crypto: octeontx2 - add virtual function driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c b/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c
index 9663be38ee40..47f378731024 100644
--- a/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c
@@ -34,7 +34,7 @@ static void cptvf_disable_pfvf_mbox_intrs(struct otx2_cptvf_dev *cptvf)
static int cptvf_register_interrupts(struct otx2_cptvf_dev *cptvf)
{
int ret, irq;
- u32 num_vec;
+ int num_vec;
num_vec = pci_msix_vec_count(cptvf->pdev);
if (num_vec <= 0)
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: octeontx2 - fix signedness bug in cptvf_register_interrupts()
2021-01-27 5:25 [PATCH] crypto: octeontx2 - fix signedness bug in cptvf_register_interrupts() Dan Carpenter
@ 2021-02-05 3:38 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-02-05 3:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Boris Brezillon, Arnaud Ebalard, Srujana Challa, David S. Miller,
Suheil Chandran, Lukasz Bartosik, linux-crypto, kernel-janitors
On Wed, Jan 27, 2021 at 08:25:59AM +0300, Dan Carpenter wrote:
> The "num_vec" has to be signed for the error handling to work.
>
> Fixes: 19d8e8c7be15 ("crypto: octeontx2 - add virtual function driver support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-05 3:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 5:25 [PATCH] crypto: octeontx2 - fix signedness bug in cptvf_register_interrupts() Dan Carpenter
2021-02-05 3:38 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).