* [PATCH] crypto: sun8i-ss: fix result memory leak on error path
@ 2021-02-12 8:46 Corentin Labbe
2021-03-04 6:44 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Corentin Labbe @ 2021-02-12 8:46 UTC (permalink / raw)
To: dan.carpenter, davem, herbert, jernej.skrabec, lkp, mripard, wens
Cc: linux-arm-kernel, linux-crypto, linux-kernel, linux-sunxi,
Corentin Labbe
This patch fixes a memory leak on an error path.
Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
index 11cbcbc83a7b..0b9aa24a5edd 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
@@ -438,8 +438,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
kfree(pad);
memcpy(areq->result, result, algt->alg.hash.halg.digestsize);
- kfree(result);
theend:
+ kfree(result);
crypto_finalize_hash_request(engine, breq, err);
return 0;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: sun8i-ss: fix result memory leak on error path
2021-02-12 8:46 [PATCH] crypto: sun8i-ss: fix result memory leak on error path Corentin Labbe
@ 2021-03-04 6:44 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-03-04 6:44 UTC (permalink / raw)
To: Corentin Labbe
Cc: dan.carpenter, davem, jernej.skrabec, lkp, mripard, wens,
linux-arm-kernel, linux-crypto, linux-kernel, linux-sunxi
On Fri, Feb 12, 2021 at 09:46:10AM +0100, Corentin Labbe wrote:
> This patch fixes a memory leak on an error path.
>
> Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] crypto: sun8i-ss: fix result memory leak on error path
@ 2021-03-02 16:41 Corentin Labbe
2021-03-12 9:31 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Corentin Labbe @ 2021-03-02 16:41 UTC (permalink / raw)
To: dan.carpenter, davem, herbert, jernej.skrabec, mripard, wens
Cc: linux-arm-kernel, linux-crypto, linux-kernel, linux-sunxi,
Corentin Labbe, kernel test robot
This patch fixes a memory leak on an error path.
Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
index 11cbcbc83a7b..0b9aa24a5edd 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
@@ -438,8 +438,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
kfree(pad);
memcpy(areq->result, result, algt->alg.hash.halg.digestsize);
- kfree(result);
theend:
+ kfree(result);
crypto_finalize_hash_request(engine, breq, err);
return 0;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: sun8i-ss: fix result memory leak on error path
2021-03-02 16:41 Corentin Labbe
@ 2021-03-12 9:31 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-03-12 9:31 UTC (permalink / raw)
To: Corentin Labbe
Cc: dan.carpenter, davem, jernej.skrabec, mripard, wens,
linux-arm-kernel, linux-crypto, linux-kernel, linux-sunxi,
kernel test robot
On Tue, Mar 02, 2021 at 05:41:45PM +0100, Corentin Labbe wrote:
> This patch fixes a memory leak on an error path.
>
> Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithms")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch was already merged a month ago:
commit 1dbc6a1e25be8575d6c4114d1d2b841a796507f7
Author: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Fri Feb 12 09:46:10 2021 +0100
crypto: sun8i-ss - fix result memory leak on error path
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-12 9:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-12 8:46 [PATCH] crypto: sun8i-ss: fix result memory leak on error path Corentin Labbe
2021-03-04 6:44 ` Herbert Xu
2021-03-02 16:41 Corentin Labbe
2021-03-12 9:31 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).