* [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG
@ 2023-08-28 8:04 Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 1/6] Revert "arm64: dts: qcom: sm8450: Add PRNG" Neil Armstrong
` (6 more replies)
0 siblings, 7 replies; 12+ messages in thread
From: Neil Armstrong @ 2023-08-28 8:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Neil Armstrong, Om Prakash Singh
Enable RNG on SM8550 by reverting the PRNG bindings & DT
for SM8450 and correctly document it as a True Random Number Generator.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v3:
- Removed invalid character in commit msg
- Added review tags
- Removed applied patch 1
- Link to v2: https://lore.kernel.org/r/20230824-topic-sm8550-rng-v2-0-dfcafbb16a3e@linaro.org
Changes in v2:
- Revert SM8450 DT & bindings
- Add new qcom,trng compatible and use it for SM8450 & SM8550
- Explicitly didn't collect the Reviewed-by tags due to the compatible change
- Link to v1: https://lore.kernel.org/r/20230822-topic-sm8550-rng-v1-0-8e10055165d1@linaro.org
---
Neil Armstrong (6):
Revert "arm64: dts: qcom: sm8450: Add PRNG"
dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG
crypto: qcom-rng - Add support for trng
dt-bindings: crypto: qcom,prng: document SM8550
arm64: dts: qcom: sm8550: add TRNG node
arm64: dts: qcom: sm8450: add TRNG node
.../devicetree/bindings/crypto/qcom,prng.yaml | 26 +++++++++++++++++-----
arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
drivers/crypto/qcom-rng.c | 1 +
4 files changed, 28 insertions(+), 6 deletions(-)
---
base-commit: 2ee82481c392eec06a7ef28df61b7f0d8e45be2e
change-id: 20230822-topic-sm8550-rng-c83142783e20
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 1/6] Revert "arm64: dts: qcom: sm8450: Add PRNG"
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
@ 2023-08-28 8:04 ` Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG Neil Armstrong
` (5 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2023-08-28 8:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Neil Armstrong, Om Prakash Singh
This reverts commit 76a6dd7bfcbb ("arm64: dts: qcom: sm8450: Add PRNG"),
since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
a more appropriate compatible should be instead as reported at [1].
[1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 2a60cf8bd891..6ae64059cea5 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1738,11 +1738,6 @@ spi14: spi@a98000 {
};
};
- rng: rng@10c3000 {
- compatible = "qcom,sm8450-prng-ee", "qcom,prng-ee";
- reg = <0 0x010c3000 0 0x1000>;
- };
-
pcie0: pci@1c00000 {
compatible = "qcom,pcie-sm8450-pcie0";
reg = <0 0x01c00000 0 0x3000>,
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 1/6] Revert "arm64: dts: qcom: sm8450: Add PRNG" Neil Armstrong
@ 2023-08-28 8:04 ` Neil Armstrong
2023-08-29 6:37 ` Krzysztof Kozlowski
2023-08-28 8:04 ` [PATCH v3 3/6] crypto: qcom-rng - Add support for trng Neil Armstrong
` (4 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Neil Armstrong @ 2023-08-28 8:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Neil Armstrong, Om Prakash Singh
It has been reported at [1] the RNG HW on SM8450 is in fact a True Random
Number Generator and no more Pseudo, document this by adding
a new qcom,trng and the corresponding SoC specific sm8450 compatible.
[1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../devicetree/bindings/crypto/qcom,prng.yaml | 24 +++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index bb42f4588b40..4245c9e424a3 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -11,9 +11,13 @@ maintainers:
properties:
compatible:
- enum:
- - qcom,prng # 8916 etc.
- - qcom,prng-ee # 8996 and later using EE
+ oneOf:
+ - enum:
+ - qcom,prng # 8916 etc.
+ - qcom,prng-ee # 8996 and later using EE
+ - items:
+ - const: qcom,sm8450-trng
+ - const: qcom,trng
reg:
maxItems: 1
@@ -28,8 +32,18 @@ properties:
required:
- compatible
- reg
- - clocks
- - clock-names
+
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: qcom,trng
+ then:
+ required:
+ - clocks
+ - clock-names
additionalProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 3/6] crypto: qcom-rng - Add support for trng
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 1/6] Revert "arm64: dts: qcom: sm8450: Add PRNG" Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG Neil Armstrong
@ 2023-08-28 8:04 ` Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550 Neil Armstrong
` (3 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2023-08-28 8:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Neil Armstrong, Om Prakash Singh
The SM8450 & later SoCs RNG HW is now a True Random Number Generator
and a new compatible has been introduced to handle the difference.
Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/crypto/qcom-rng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
index 825a729f205e..fb54b8cfc35f 100644
--- a/drivers/crypto/qcom-rng.c
+++ b/drivers/crypto/qcom-rng.c
@@ -207,6 +207,7 @@ MODULE_DEVICE_TABLE(acpi, qcom_rng_acpi_match);
static const struct of_device_id __maybe_unused qcom_rng_of_match[] = {
{ .compatible = "qcom,prng", .data = (void *)0},
{ .compatible = "qcom,prng-ee", .data = (void *)1},
+ { .compatible = "qcom,trng", .data = (void *)1},
{}
};
MODULE_DEVICE_TABLE(of, qcom_rng_of_match);
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
` (2 preceding siblings ...)
2023-08-28 8:04 ` [PATCH v3 3/6] crypto: qcom-rng - Add support for trng Neil Armstrong
@ 2023-08-28 8:04 ` Neil Armstrong
2023-08-28 21:36 ` Rob Herring
2023-08-28 8:04 ` [PATCH v3 5/6] arm64: dts: qcom: sm8550: add TRNG node Neil Armstrong
` (2 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: Neil Armstrong @ 2023-08-28 8:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Neil Armstrong, Om Prakash Singh
Document SM8550 compatible for the True Random Number Generator.
Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 4245c9e424a3..633993f801c6 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -16,7 +16,9 @@ properties:
- qcom,prng # 8916 etc.
- qcom,prng-ee # 8996 and later using EE
- items:
- - const: qcom,sm8450-trng
+ - enum:
+ - qcom,sm8450-trng
+ - qcom,sm8550-trng
- const: qcom,trng
reg:
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 5/6] arm64: dts: qcom: sm8550: add TRNG node
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
` (3 preceding siblings ...)
2023-08-28 8:04 ` [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550 Neil Armstrong
@ 2023-08-28 8:04 ` Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 6/6] arm64: dts: qcom: sm8450: " Neil Armstrong
2023-09-20 17:14 ` (subset) [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Bjorn Andersson
6 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2023-08-28 8:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Neil Armstrong
Add the Qualcomm True Random Number Generator node.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index d115960bdeec..c42c5bd03a37 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -1661,6 +1661,11 @@ mmss_noc: interconnect@1780000 {
qcom,bcm-voters = <&apps_bcm_voter>;
};
+ rng: rng@10c3000 {
+ compatible = "qcom,sm8550-trng", "qcom,trng";
+ reg = <0 0x010c3000 0 0x1000>;
+ };
+
pcie0: pci@1c00000 {
device_type = "pci";
compatible = "qcom,pcie-sm8550";
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 6/6] arm64: dts: qcom: sm8450: add TRNG node
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
` (4 preceding siblings ...)
2023-08-28 8:04 ` [PATCH v3 5/6] arm64: dts: qcom: sm8550: add TRNG node Neil Armstrong
@ 2023-08-28 8:04 ` Neil Armstrong
2023-09-20 17:14 ` (subset) [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Bjorn Andersson
6 siblings, 0 replies; 12+ messages in thread
From: Neil Armstrong @ 2023-08-28 8:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Neil Armstrong
The SM8450 SoC has a True Random Number Generator, add the node with
the correct compatible set.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 6ae64059cea5..e267c6286b1a 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1738,6 +1738,11 @@ spi14: spi@a98000 {
};
};
+ rng: rng@10c3000 {
+ compatible = "qcom,sm8450-trng", "qcom,trng";
+ reg = <0 0x010c3000 0 0x1000>;
+ };
+
pcie0: pci@1c00000 {
compatible = "qcom,pcie-sm8450-pcie0";
reg = <0 0x01c00000 0 0x3000>,
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550
2023-08-28 8:04 ` [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550 Neil Armstrong
@ 2023-08-28 21:36 ` Rob Herring
2023-08-29 6:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2023-08-28 21:36 UTC (permalink / raw)
To: Neil Armstrong
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Om Prakash Singh
On Mon, Aug 28, 2023 at 10:04:39AM +0200, Neil Armstrong wrote:
> Document SM8550 compatible for the True Random Number Generator.
>
> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Where's Krzysztof's tag?
> ---
> Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 4245c9e424a3..633993f801c6 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -16,7 +16,9 @@ properties:
> - qcom,prng # 8916 etc.
> - qcom,prng-ee # 8996 and later using EE
> - items:
> - - const: qcom,sm8450-trng
> + - enum:
> + - qcom,sm8450-trng
> + - qcom,sm8550-trng
> - const: qcom,trng
>
> reg:
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG
2023-08-28 8:04 ` [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG Neil Armstrong
@ 2023-08-29 6:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-29 6:37 UTC (permalink / raw)
To: Neil Armstrong, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vinod Koul
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Om Prakash Singh
On 28/08/2023 10:04, Neil Armstrong wrote:
> It has been reported at [1] the RNG HW on SM8450 is in fact a True Random
> Number Generator and no more Pseudo, document this by adding
> a new qcom,trng and the corresponding SoC specific sm8450 compatible.
>
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
>
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../devicetree/bindings/crypto/qcom,prng.yaml | 24 +++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index bb42f4588b40..4245c9e424a3 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -11,9 +11,13 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - qcom,prng # 8916 etc.
> - - qcom,prng-ee # 8996 and later using EE
> + oneOf:
> + - enum:
> + - qcom,prng # 8916 etc.
> + - qcom,prng-ee # 8996 and later using EE
> + - items:
> + - const: qcom,sm8450-trng
Make it already an enum, so you won't have to change same lines twice.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550
2023-08-28 21:36 ` Rob Herring
@ 2023-08-29 6:38 ` Krzysztof Kozlowski
2023-08-29 16:22 ` Rob Herring
0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-29 6:38 UTC (permalink / raw)
To: Rob Herring, Neil Armstrong
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Om Prakash Singh
On 28/08/2023 23:36, Rob Herring wrote:
> On Mon, Aug 28, 2023 at 10:04:39AM +0200, Neil Armstrong wrote:
>> Document SM8550 compatible for the True Random Number Generator.
>>
>> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> Where's Krzysztof's tag?
>
The patch evolved and Neil mentioned in cover letter changelog that he
did not collect Reviews because of that. Seems ok for me.
For the patch:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550
2023-08-29 6:38 ` Krzysztof Kozlowski
@ 2023-08-29 16:22 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2023-08-29 16:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Neil Armstrong
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Herbert Xu,
David S. Miller, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
linux-arm-msm, linux-crypto, devicetree, linux-kernel,
Om Prakash Singh
On Tue, Aug 29, 2023 at 08:38:48AM +0200, Krzysztof Kozlowski wrote:
> On 28/08/2023 23:36, Rob Herring wrote:
> > On Mon, Aug 28, 2023 at 10:04:39AM +0200, Neil Armstrong wrote:
> >> Document SM8550 compatible for the True Random Number Generator.
> >>
> >> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> >
> > Where's Krzysztof's tag?
> >
>
> The patch evolved and Neil mentioned in cover letter changelog that he
> did not collect Reviews because of that. Seems ok for me.
I did go look there and just saw 'Added review tags'. Not too helpful.
That's why changelogs for a patch belong in the patch.
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: (subset) [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
` (5 preceding siblings ...)
2023-08-28 8:04 ` [PATCH v3 6/6] arm64: dts: qcom: sm8450: " Neil Armstrong
@ 2023-09-20 17:14 ` Bjorn Andersson
6 siblings, 0 replies; 12+ messages in thread
From: Bjorn Andersson @ 2023-09-20 17:14 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Herbert Xu, David S. Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
Neil Armstrong
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Om Prakash Singh
On Mon, 28 Aug 2023 10:04:35 +0200, Neil Armstrong wrote:
> Enable RNG on SM8550 by reverting the PRNG bindings & DT
> for SM8450 and correctly document it as a True Random Number Generator.
>
>
Applied, thanks!
[1/6] Revert "arm64: dts: qcom: sm8450: Add PRNG"
commit: e735eab705cd0a9b3b98ffd746055c2c49e1572b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-09-20 17:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-28 8:04 [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 1/6] Revert "arm64: dts: qcom: sm8450: Add PRNG" Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG Neil Armstrong
2023-08-29 6:37 ` Krzysztof Kozlowski
2023-08-28 8:04 ` [PATCH v3 3/6] crypto: qcom-rng - Add support for trng Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 4/6] dt-bindings: crypto: qcom,prng: document SM8550 Neil Armstrong
2023-08-28 21:36 ` Rob Herring
2023-08-29 6:38 ` Krzysztof Kozlowski
2023-08-29 16:22 ` Rob Herring
2023-08-28 8:04 ` [PATCH v3 5/6] arm64: dts: qcom: sm8550: add TRNG node Neil Armstrong
2023-08-28 8:04 ` [PATCH v3 6/6] arm64: dts: qcom: sm8450: " Neil Armstrong
2023-09-20 17:14 ` (subset) [PATCH v3 0/6] arm64: qcom: sm8550: enable RNG Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).