* [PATCH RESEND] virtio_crypto: remove duplicate check if queue is broken
@ 2024-02-01 6:17 Li RongQing
2024-02-09 5:01 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Li RongQing @ 2024-02-01 6:17 UTC (permalink / raw)
To: linux-crypto; +Cc: Li RongQing
virtqueue_enable_cb() will call virtqueue_poll() which will check if
queue is broken at beginning, so remove the virtqueue_is_broken() call
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
drivers/crypto/virtio/virtio_crypto_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c
index b909c6a..6a67d70 100644
--- a/drivers/crypto/virtio/virtio_crypto_core.c
+++ b/drivers/crypto/virtio/virtio_crypto_core.c
@@ -42,8 +42,6 @@ static void virtcrypto_ctrlq_callback(struct virtqueue *vq)
virtio_crypto_ctrlq_callback(vc_ctrl_req);
spin_lock_irqsave(&vcrypto->ctrl_lock, flags);
}
- if (unlikely(virtqueue_is_broken(vq)))
- break;
} while (!virtqueue_enable_cb(vq));
spin_unlock_irqrestore(&vcrypto->ctrl_lock, flags);
}
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] virtio_crypto: remove duplicate check if queue is broken
2024-02-01 6:17 [PATCH RESEND] virtio_crypto: remove duplicate check if queue is broken Li RongQing
@ 2024-02-09 5:01 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2024-02-09 5:01 UTC (permalink / raw)
To: Li RongQing; +Cc: linux-crypto, lirongqing
Li RongQing <lirongqing@baidu.com> wrote:
> virtqueue_enable_cb() will call virtqueue_poll() which will check if
> queue is broken at beginning, so remove the virtqueue_is_broken() call
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> drivers/crypto/virtio/virtio_crypto_core.c | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-09 5:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-01 6:17 [PATCH RESEND] virtio_crypto: remove duplicate check if queue is broken Li RongQing
2024-02-09 5:01 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).