* [PATCH] crypto: hifn_795x: Remove unused hifn_*_command structs
@ 2024-05-11 14:54 linux
2024-05-25 0:08 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2024-05-11 14:54 UTC (permalink / raw)
To: herbert, davem; +Cc: linux-crypto, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
Remove 'hifn_mac_command' and 'hifn_comp_command' which are unused.
They're the same structure as 'hifn_crypt_command' which is used.
(I was tempted to remove
hifn_base_result
hifn_comp_result
hifn_mac_result and
hifn_crypt_result
which are also unused, but they vary, and perhaps they're telling
someone in the future what to look at.)
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/crypto/hifn_795x.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index b4a4ec35bce05..9259915267454 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -495,16 +495,6 @@ struct hifn_crypt_command {
#define HIFN_CRYPT_CMD_SRCLEN_M 0xc000
#define HIFN_CRYPT_CMD_SRCLEN_S 14
-/*
- * Structure to help build up the command data structure.
- */
-struct hifn_mac_command {
- volatile __le16 masks;
- volatile __le16 header_skip;
- volatile __le16 source_count;
- volatile __le16 reserved;
-};
-
#define HIFN_MAC_CMD_ALG_MASK 0x0001
#define HIFN_MAC_CMD_ALG_SHA1 0x0000
#define HIFN_MAC_CMD_ALG_MD5 0x0001
@@ -526,13 +516,6 @@ struct hifn_mac_command {
#define HIFN_MAC_CMD_POS_IPSEC 0x0200
#define HIFN_MAC_CMD_NEW_KEY 0x0800
-struct hifn_comp_command {
- volatile __le16 masks;
- volatile __le16 header_skip;
- volatile __le16 source_count;
- volatile __le16 reserved;
-};
-
#define HIFN_COMP_CMD_SRCLEN_M 0xc000
#define HIFN_COMP_CMD_SRCLEN_S 14
#define HIFN_COMP_CMD_ONE 0x0100 /* must be one */
--
2.45.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: hifn_795x: Remove unused hifn_*_command structs
2024-05-11 14:54 [PATCH] crypto: hifn_795x: Remove unused hifn_*_command structs linux
@ 2024-05-25 0:08 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 2+ messages in thread
From: Dr. David Alan Gilbert @ 2024-05-25 0:08 UTC (permalink / raw)
To: herbert, davem; +Cc: linux-crypto, linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> Remove 'hifn_mac_command' and 'hifn_comp_command' which are unused.
> They're the same structure as 'hifn_crypt_command' which is used.
>
> (I was tempted to remove
> hifn_base_result
> hifn_comp_result
> hifn_mac_result and
> hifn_crypt_result
> which are also unused, but they vary, and perhaps they're telling
> someone in the future what to look at.)
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping.
> ---
> drivers/crypto/hifn_795x.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
> index b4a4ec35bce05..9259915267454 100644
> --- a/drivers/crypto/hifn_795x.c
> +++ b/drivers/crypto/hifn_795x.c
> @@ -495,16 +495,6 @@ struct hifn_crypt_command {
> #define HIFN_CRYPT_CMD_SRCLEN_M 0xc000
> #define HIFN_CRYPT_CMD_SRCLEN_S 14
>
> -/*
> - * Structure to help build up the command data structure.
> - */
> -struct hifn_mac_command {
> - volatile __le16 masks;
> - volatile __le16 header_skip;
> - volatile __le16 source_count;
> - volatile __le16 reserved;
> -};
> -
> #define HIFN_MAC_CMD_ALG_MASK 0x0001
> #define HIFN_MAC_CMD_ALG_SHA1 0x0000
> #define HIFN_MAC_CMD_ALG_MD5 0x0001
> @@ -526,13 +516,6 @@ struct hifn_mac_command {
> #define HIFN_MAC_CMD_POS_IPSEC 0x0200
> #define HIFN_MAC_CMD_NEW_KEY 0x0800
>
> -struct hifn_comp_command {
> - volatile __le16 masks;
> - volatile __le16 header_skip;
> - volatile __le16 source_count;
> - volatile __le16 reserved;
> -};
> -
> #define HIFN_COMP_CMD_SRCLEN_M 0xc000
> #define HIFN_COMP_CMD_SRCLEN_S 14
> #define HIFN_COMP_CMD_ONE 0x0100 /* must be one */
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-25 0:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-11 14:54 [PATCH] crypto: hifn_795x: Remove unused hifn_*_command structs linux
2024-05-25 0:08 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).