* [PATCH v1] crypto: caam - use traditional error check pattern
@ 2020-08-31 7:58 Andy Shevchenko
2020-09-01 15:05 ` Iuliana Prodan
2020-09-11 6:57 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-08-31 7:58 UTC (permalink / raw)
To: Horia Geantă,
Aymen Sghaier, linux-crypto, David S. Miller, Andrey Smirnov
Cc: Andy Shevchenko
Use traditional error check pattern
ret = ...;
if (ret)
return ret;
...
instead of checking error code to be 0.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/crypto/caam/ctrl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 65de57f169d9..25785404a58e 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -333,11 +333,10 @@ static int instantiate_rng(struct device *ctrldev, int state_handle_mask,
kfree(desc);
- if (!ret)
- ret = devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng,
- ctrldev);
+ if (ret)
+ return ret;
- return ret;
+ return devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, ctrldev);
}
/*
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] crypto: caam - use traditional error check pattern
2020-08-31 7:58 [PATCH v1] crypto: caam - use traditional error check pattern Andy Shevchenko
@ 2020-09-01 15:05 ` Iuliana Prodan
2020-09-11 6:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Iuliana Prodan @ 2020-09-01 15:05 UTC (permalink / raw)
To: Andy Shevchenko, Horia Geantă,
Aymen Sghaier, linux-crypto, David S. Miller, Andrey Smirnov
On 8/31/2020 10:58 AM, Andy Shevchenko wrote:
> Use traditional error check pattern
> ret = ...;
> if (ret)
> return ret;
> ...
> instead of checking error code to be 0.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> ---
> drivers/crypto/caam/ctrl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index 65de57f169d9..25785404a58e 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -333,11 +333,10 @@ static int instantiate_rng(struct device *ctrldev, int state_handle_mask,
>
> kfree(desc);
>
> - if (!ret)
> - ret = devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng,
> - ctrldev);
> + if (ret)
> + return ret;
>
> - return ret;
> + return devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, ctrldev);
> }
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] crypto: caam - use traditional error check pattern
2020-08-31 7:58 [PATCH v1] crypto: caam - use traditional error check pattern Andy Shevchenko
2020-09-01 15:05 ` Iuliana Prodan
@ 2020-09-11 6:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-09-11 6:57 UTC (permalink / raw)
To: Andy Shevchenko
Cc: horia.geanta, aymen.sghaier, linux-crypto, davem, andrew.smirnov,
andriy.shevchenko
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Use traditional error check pattern
> ret = ...;
> if (ret)
> return ret;
> ...
> instead of checking error code to be 0.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/crypto/caam/ctrl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-11 6:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31 7:58 [PATCH v1] crypto: caam - use traditional error check pattern Andy Shevchenko
2020-09-01 15:05 ` Iuliana Prodan
2020-09-11 6:57 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).