From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: Hadar Gat <hadar.gat@arm.com>, Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tomer Maimon <tmaimon77@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Zaibo Xu <xuzaibo@huawei.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH v5 2/3] hw_random: cctrng: introduce Arm CryptoCell driver
Date: Mon, 23 Mar 2020 15:56:19 +0100 [thread overview]
Message-ID: <412a4da61063b8c8a72729f03c06480c5f1374fb.camel@pengutronix.de> (raw)
In-Reply-To: <1584891085-8963-3-git-send-email-hadar.gat@arm.com>
Hello Hadar,
On Sun, 2020-03-22 at 17:31 +0200, Hadar Gat wrote:
> Introduce low level Arm CryptoCell TRNG HW support.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> ---
> drivers/char/hw_random/Kconfig | 12 +
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/cctrng.c | 735
> ++++++++++++++++++++++++++++++++++++++++
> drivers/char/hw_random/cctrng.h | 69 ++++
> 4 files changed, 817 insertions(+)
> create mode 100644 drivers/char/hw_random/cctrng.c
> create mode 100644 drivers/char/hw_random/cctrng.h
>
> [...]
> +static int cctrng_probe(struct platform_device *pdev)
> +{
> + struct resource *req_mem_cc_regs = NULL;
> + struct cctrng_drvdata *drvdata;
> + struct device *dev = &pdev->dev;
> + int rc = 0;
> + u32 val;
> + int irq;
> +
> + drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
> + if (!drvdata)
> + return -ENOMEM;
> +
> + drvdata->rng.name = devm_kstrdup(dev, dev_name(dev),
> GFP_KERNEL);
> + if (!drvdata->rng.name)
> + return -ENOMEM;
> +
> + drvdata->rng.read = cctrng_read;
> + drvdata->rng.priv = (unsigned long)drvdata;
You are not initializing drvdata->rng.quality to a default value, which
results in the TRNG not being used by the kernel by default. If its a
perfect TRNG this should be set to 1024, i.e. 1024 bits of entropy per
1024 bits of input.
Regards,
Rouven Czerwinski
next prev parent reply other threads:[~2020-03-23 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 15:31 [PATCH v5 0/3] hw_random: introduce Arm CryptoCell TRNG driver Hadar Gat
2020-03-22 15:31 ` [PATCH v5 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine Hadar Gat
2020-03-22 15:31 ` [PATCH v5 2/3] hw_random: cctrng: introduce Arm CryptoCell driver Hadar Gat
2020-03-23 14:56 ` Rouven Czerwinski [this message]
2020-03-23 19:50 ` Hadar Gat
2020-03-22 15:31 ` [PATCH v5 3/3] MAINTAINERS: add HG as cctrng maintainer Hadar Gat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412a4da61063b8c8a72729f03c06480c5f1374fb.camel@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexander.sverdlin@nokia.com \
--cc=arnd@arndb.de \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadar.gat@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mpm@selenic.com \
--cc=ofir.drang@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmaimon77@gmail.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).