[PATCH] crypto: sha{256,512}_ssse3

* [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions
@ 2014-04-16 16:19 Jianyu Zhan
  2014-04-17 15:28 ` Marek Vasut
  0 siblings, 1 reply; 5+ messages in thread
From: Jianyu Zhan @ 2014-04-16 16:19 UTC (permalink / raw)
  To: herbert, davem, tglx, mingo, hpa
  Cc: x86, linux-crypto, linux-kernel, nasa4836

Commit 128ea04a9885("lto: Make asmlinkage __visible") restricts
asmlinkage to externally_visible, this causes compilation warnings:

    arch/x86/crypto/sha256_ssse3_glue.c:56:1:
    warning: ‘externally_visible’ attribute have effect only on public objects [-Wattributes]

    static asmlinkage void (*sha256_transform_asm)(const char *, u32 *, u64);
    ^

    arch/x86/crypto/sha512_ssse3_glue.c:55:1:
    warning: ‘externally_visible’ attribute have effect only on public objects [-Wattributes]
    static asmlinkage void (*sha512_transform_asm)(const char *, u64 *,
    ^

Drop asmlinkage here to avoid such warnings.

Also see Commit 8783dd3a37a5853689e1("irqchip: Remove asmlinkage from static functions")

Signed-off-by: Jianyu Zhan <nasa4836@gmail.com>
---
 arch/x86/crypto/sha256_ssse3_glue.c | 2 +-
 arch/x86/crypto/sha512_ssse3_glue.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/crypto/sha256_ssse3_glue.c b/arch/x86/crypto/sha256_ssse3_glue.c
index f248546..be35c31 100644
--- a/arch/x86/crypto/sha256_ssse3_glue.c
+++ b/arch/x86/crypto/sha256_ssse3_glue.c
@@ -53,7 +53,7 @@ asmlinkage void sha256_transform_rorx(const char *data, u32 *digest,
 				     u64 rounds);
 #endif
 
-static asmlinkage void (*sha256_transform_asm)(const char *, u32 *, u64);
+static void (*sha256_transform_asm)(const char *, u32 *, u64);
 
 
 static int sha256_ssse3_init(struct shash_desc *desc)
diff --git a/arch/x86/crypto/sha512_ssse3_glue.c b/arch/x86/crypto/sha512_ssse3_glue.c
index f30cd10..ddbc242 100644
--- a/arch/x86/crypto/sha512_ssse3_glue.c
+++ b/arch/x86/crypto/sha512_ssse3_glue.c
@@ -52,7 +52,7 @@ asmlinkage void sha512_transform_rorx(const char *data, u64 *digest,
 				     u64 rounds);
 #endif
 
-static asmlinkage void (*sha512_transform_asm)(const char *, u64 *, u64);
+static void (*sha512_transform_asm)(const char *, u64 *, u64);
 
 
 static int sha512_ssse3_init(struct shash_desc *desc)
-- 
1.9.0.GIT

^ permalink raw reply related	[flat|nested] 5+ messages in thread