* [PATCH v1] hwrng: Use UUID API for exporting the UUID
@ 2020-04-22 12:58 Andy Shevchenko
2020-04-23 5:20 ` Sumit Garg
2020-04-30 5:30 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-04-22 12:58 UTC (permalink / raw)
To: Sumit Garg, tee-dev, Matt Mackall, Herbert Xu, linux-crypto
Cc: Andy Shevchenko
There is export_uuid() function which exports uuid_t to the u8 array.
Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/char/hw_random/optee-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
index ddfbabaa5f8f6..49b2e02537ddb 100644
--- a/drivers/char/hw_random/optee-rng.c
+++ b/drivers/char/hw_random/optee-rng.c
@@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev)
return -ENODEV;
/* Open session with hwrng Trusted App */
- memcpy(sess_arg.uuid, rng_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
+ export_uuid(sess_arg.uuid, &rng_device->id.uuid);
sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
sess_arg.num_params = 0;
--
2.26.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] hwrng: Use UUID API for exporting the UUID
2020-04-22 12:58 [PATCH v1] hwrng: Use UUID API for exporting the UUID Andy Shevchenko
@ 2020-04-23 5:20 ` Sumit Garg
2020-04-30 5:30 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Sumit Garg @ 2020-04-23 5:20 UTC (permalink / raw)
To: Andy Shevchenko
Cc: tee-dev @ lists . linaro . org, Matt Mackall, Herbert Xu,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE
On Wed, 22 Apr 2020 at 18:28, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
>
> This allows to hide the uuid_t internals.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/char/hw_random/optee-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
> diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
> index ddfbabaa5f8f6..49b2e02537ddb 100644
> --- a/drivers/char/hw_random/optee-rng.c
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev)
> return -ENODEV;
>
> /* Open session with hwrng Trusted App */
> - memcpy(sess_arg.uuid, rng_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
> + export_uuid(sess_arg.uuid, &rng_device->id.uuid);
> sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
> sess_arg.num_params = 0;
>
> --
> 2.26.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] hwrng: Use UUID API for exporting the UUID
2020-04-22 12:58 [PATCH v1] hwrng: Use UUID API for exporting the UUID Andy Shevchenko
2020-04-23 5:20 ` Sumit Garg
@ 2020-04-30 5:30 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-04-30 5:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Sumit Garg, tee-dev, Matt Mackall, linux-crypto
On Wed, Apr 22, 2020 at 03:58:08PM +0300, Andy Shevchenko wrote:
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
>
> This allows to hide the uuid_t internals.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/char/hw_random/optee-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-30 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 12:58 [PATCH v1] hwrng: Use UUID API for exporting the UUID Andy Shevchenko
2020-04-23 5:20 ` Sumit Garg
2020-04-30 5:30 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).