* [PATCH] hwrng: omap3-rom fix pointer warning for omap3_rom_rng_idle
@ 2019-10-15 12:27 Ben Dooks
2019-10-15 12:48 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2019-10-15 12:27 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks, Arnd Bergmann, Greg Kroah-Hartman, linux-crypto, linux-kernel
The omap3_rom_rng_idle function takes a pointer, so give
it a pointer instead of a plain 0. This fixes the following
sparse warning:
drivers/char/hw_random/omap3-rom-rng.c:115:28: warning: Using plain integer as NULL pointer
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/char/hw_random/omap3-rom-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/omap3-rom-rng.c b/drivers/char/hw_random/omap3-rom-rng.c
index 38b719017186..75fe3dc83d28 100644
--- a/drivers/char/hw_random/omap3-rom-rng.c
+++ b/drivers/char/hw_random/omap3-rom-rng.c
@@ -112,7 +112,7 @@ static int omap3_rom_rng_probe(struct platform_device *pdev)
ret = clk_prepare_enable(rng_clk);
if (ret)
return ret;
- omap3_rom_rng_idle(0);
+ omap3_rom_rng_idle(NULL);
return hwrng_register(&omap3_rom_rng_ops);
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwrng: omap3-rom fix pointer warning for omap3_rom_rng_idle
2019-10-15 12:27 [PATCH] hwrng: omap3-rom fix pointer warning for omap3_rom_rng_idle Ben Dooks
@ 2019-10-15 12:48 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2019-10-15 12:48 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Greg Kroah-Hartman,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-kernel
On Tue, Oct 15, 2019 at 2:27 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The omap3_rom_rng_idle function takes a pointer, so give
> it a pointer instead of a plain 0. This fixes the following
> sparse warning:
>
> drivers/char/hw_random/omap3-rom-rng.c:115:28: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-15 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 12:27 [PATCH] hwrng: omap3-rom fix pointer warning for omap3_rom_rng_idle Ben Dooks
2019-10-15 12:48 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).