From: Ard Biesheuvel <ardb@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
TimGuo-oc@zhaoxin.com, CooperYan@zhaoxin.com,
QiyuanWang@zhaoxin.com, HerryYang@zhaoxin.com,
CobeChen@zhaoxin.com, SilviaZhao@zhaoxin.com
Subject: Re: [PATCH] crypto: x86/crc32c-intel - Don't match some Zhaoxin CPUs
Date: Sat, 12 Dec 2020 11:54:07 +0100 [thread overview]
Message-ID: <CAMj1kXH=u7+_DSEsUmFbtgGdPqCUs=AfTqX0mgL+DYvW2hAc8g@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXEDjQG_my5FWVY+b7Q43-_waW74sZyBAPCkd7EEdku+Rw@mail.gmail.com>
On Sat, 12 Dec 2020 at 10:36, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Fri, 11 Dec 2020 at 20:07, Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > On Fri, Dec 11, 2020 at 07:29:04PM +0800, Tony W Wang-oc wrote:
> > > The driver crc32c-intel match CPUs supporting X86_FEATURE_XMM4_2.
> > > On platforms with Zhaoxin CPUs supporting this X86 feature, When
> > > crc32c-intel and crc32c-generic are both registered, system will
> > > use crc32c-intel because its .cra_priority is greater than
> > > crc32c-generic. This case expect to use crc32c-generic driver for
> > > some Zhaoxin CPUs to get performance gain, So remove these Zhaoxin
> > > CPUs support from crc32c-intel.
> > >
> > > Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
> >
> > Does this mean that the performance of the crc32c instruction on those CPUs is
> > actually slower than a regular C implementation? That's very weird.
> >
>
> This driver does not use CRC instructions, but carryless
> multiplication and aggregation. So I suppose the pclmulqdq instruction
> triggers some pathological performance limitation here.
>
Just noticed it uses both crc instructions and pclmulqdq instructions.
Sorry for the noise.
> That means the crct10dif driver probably needs the same treatment.
Tony, can you confirm that the problem is in the CRC instructions and
not in the PCLMULQDQ code path that supersedes it when available?
next prev parent reply other threads:[~2020-12-12 10:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 11:29 [PATCH] crypto: x86/crc32c-intel - Don't match some Zhaoxin CPUs Tony W Wang-oc
2020-12-11 13:00 ` Peter Zijlstra
2020-12-12 4:32 ` Tony W Wang-oc
2020-12-11 17:43 ` Eric Biggers
2020-12-12 9:36 ` Ard Biesheuvel
2020-12-12 10:54 ` Ard Biesheuvel [this message]
2020-12-14 2:29 ` Tony W Wang-oc
2020-12-14 2:28 ` Tony W Wang-oc
2020-12-14 20:41 ` Eric Biggers
2020-12-15 2:15 ` Tony W Wang-oc
2020-12-15 17:56 ` Eric Biggers
2020-12-21 2:46 ` tonywwang-oc
2020-12-21 19:27 ` hpa
2020-12-22 3:01 ` tonywwang-oc
2020-12-22 4:54 ` hpa
2021-01-07 6:23 ` Tony W Wang-oc
2020-12-14 3:59 Tony W Wang-oc
2020-12-15 8:58 ` Peter Zijlstra
2020-12-15 10:02 ` Tony W Wang-oc
2020-12-15 10:28 Tony W Wang-oc
2021-01-02 21:12 ` Herbert Xu
2021-01-07 6:27 ` Tony W Wang-oc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXH=u7+_DSEsUmFbtgGdPqCUs=AfTqX0mgL+DYvW2hAc8g@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=CobeChen@zhaoxin.com \
--cc=CooperYan@zhaoxin.com \
--cc=HerryYang@zhaoxin.com \
--cc=QiyuanWang@zhaoxin.com \
--cc=SilviaZhao@zhaoxin.com \
--cc=TimGuo-oc@zhaoxin.com \
--cc=TonyWWang-oc@zhaoxin.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).