linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
@ 2019-08-06 12:54 Pascal van Leeuwen
  2019-08-15 11:32 ` Josh Boyer
  0 siblings, 1 reply; 5+ messages in thread
From: Pascal van Leeuwen @ 2019-08-06 12:54 UTC (permalink / raw)
  To: linux-firmware; +Cc: linux-crypto

The following changes since commit dff98c6c57383fe343407bcb7b6e775e0b87274f:

  Merge branch 'master' of git://github.com/skeggsb/linux-firmware
(2019-07-26 07:32:37 -0400)

are available in the git repository at:


  https://github.com/pvanleeuwen/linux-firmware-clean.git is_driver_fw

for you to fetch changes up to fbfe41f92f941d19b840ec0e282f422379982ccb:

  inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
(2019-08-06 13:19:44 +0200)

----------------------------------------------------------------
Pascal van Leeuwen (1):
      inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver

 WHENCE                               |  10 ++++++++++
 inside-secure/eip197_minifw/ifpp.bin | Bin 0 -> 100 bytes
 inside-secure/eip197_minifw/ipue.bin | Bin 0 -> 108 bytes
 3 files changed, 10 insertions(+)
 create mode 100644 inside-secure/eip197_minifw/ifpp.bin
 create mode 100644 inside-secure/eip197_minifw/ipue.bin

diff --git a/WHENCE b/WHENCE
index 31edbd4..fce2ef7 100644
--- a/WHENCE
+++ b/WHENCE
@@ -4514,3 +4514,13 @@ File: meson/vdec/gxl_mpeg4_5.bin
 File: meson/vdec/gxm_h264.bin

 Licence: Redistributable. See LICENSE.amlogic_vdec for details.
+
+--------------------------------------------------------------------------
+
+Driver: inside-secure -- Inside Secure EIP197 crypto driver
+
+File: inside-secure/eip197_minifw/ipue.bin
+File: inside-secure/eip197_minifw/ifpp.bin
+
+Licence: GPLv2. See GPL-2 for details.
+
diff --git a/inside-secure/eip197_minifw/ifpp.bin
b/inside-secure/eip197_minifw/ifpp.bin
new file mode 100644
index 0000000..b4a8322
Binary files /dev/null and b/inside-secure/eip197_minifw/ifpp.bin differ
diff --git a/inside-secure/eip197_minifw/ipue.bin
b/inside-secure/eip197_minifw/ipue.bin
new file mode 100644
index 0000000..2f54999
Binary files /dev/null and b/inside-secure/eip197_minifw/ipue.bin differ

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
  2019-08-06 12:54 [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver Pascal van Leeuwen
@ 2019-08-15 11:32 ` Josh Boyer
  2019-08-20 12:01   ` Pascal Van Leeuwen
  0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2019-08-15 11:32 UTC (permalink / raw)
  To: Pascal van Leeuwen; +Cc: Linux Firmware, linux-crypto

On Tue, Aug 6, 2019 at 8:54 AM Pascal van Leeuwen <pascalvanl@gmail.com> wrote:
>
> The following changes since commit dff98c6c57383fe343407bcb7b6e775e0b87274f:
>
>   Merge branch 'master' of git://github.com/skeggsb/linux-firmware
> (2019-07-26 07:32:37 -0400)
>
> are available in the git repository at:
>
>
>   https://github.com/pvanleeuwen/linux-firmware-clean.git is_driver_fw
>
> for you to fetch changes up to fbfe41f92f941d19b840ec0e282f422379982ccb:
>
>   inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> (2019-08-06 13:19:44 +0200)
>
> ----------------------------------------------------------------
> Pascal van Leeuwen (1):
>       inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
>
>  WHENCE                               |  10 ++++++++++
>  inside-secure/eip197_minifw/ifpp.bin | Bin 0 -> 100 bytes
>  inside-secure/eip197_minifw/ipue.bin | Bin 0 -> 108 bytes
>  3 files changed, 10 insertions(+)
>  create mode 100644 inside-secure/eip197_minifw/ifpp.bin
>  create mode 100644 inside-secure/eip197_minifw/ipue.bin

If this is GPLv2, where is the source code?

josh


> diff --git a/WHENCE b/WHENCE
> index 31edbd4..fce2ef7 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -4514,3 +4514,13 @@ File: meson/vdec/gxl_mpeg4_5.bin
>  File: meson/vdec/gxm_h264.bin
>
>  Licence: Redistributable. See LICENSE.amlogic_vdec for details.
> +
> +--------------------------------------------------------------------------
> +
> +Driver: inside-secure -- Inside Secure EIP197 crypto driver
> +
> +File: inside-secure/eip197_minifw/ipue.bin
> +File: inside-secure/eip197_minifw/ifpp.bin
> +
> +Licence: GPLv2. See GPL-2 for details.
> +
> diff --git a/inside-secure/eip197_minifw/ifpp.bin
> b/inside-secure/eip197_minifw/ifpp.bin
> new file mode 100644
> index 0000000..b4a8322
> Binary files /dev/null and b/inside-secure/eip197_minifw/ifpp.bin differ
> diff --git a/inside-secure/eip197_minifw/ipue.bin
> b/inside-secure/eip197_minifw/ipue.bin
> new file mode 100644
> index 0000000..2f54999
> Binary files /dev/null and b/inside-secure/eip197_minifw/ipue.bin differ

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
  2019-08-15 11:32 ` Josh Boyer
@ 2019-08-20 12:01   ` Pascal Van Leeuwen
  2019-08-20 13:09     ` Josh Boyer
  0 siblings, 1 reply; 5+ messages in thread
From: Pascal Van Leeuwen @ 2019-08-20 12:01 UTC (permalink / raw)
  To: Josh Boyer, Pascal van Leeuwen; +Cc: Linux Firmware, linux-crypto

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of
> Josh Boyer
> Sent: Thursday, August 15, 2019 1:33 PM
> To: Pascal van Leeuwen <pascalvanl@gmail.com>
> Cc: Linux Firmware <linux-firmware@kernel.org>; linux-crypto@vger.kernel.org
> Subject: Re: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> 
> On Tue, Aug 6, 2019 at 8:54 AM Pascal van Leeuwen <pascalvanl@gmail.com> wrote:
> >
> > The following changes since commit dff98c6c57383fe343407bcb7b6e775e0b87274f:
> >
> >   Merge branch 'master' of git://github.com/skeggsb/linux-firmware
> > (2019-07-26 07:32:37 -0400)
> >
> > are available in the git repository at:
> >
> >
> >   https://github.com/pvanleeuwen/linux-firmware-clean.git is_driver_fw
> >
> > for you to fetch changes up to fbfe41f92f941d19b840ec0e282f422379982ccb:
> >
> >   inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> > (2019-08-06 13:19:44 +0200)
> >
> > ----------------------------------------------------------------
> > Pascal van Leeuwen (1):
> >       inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> >
> >  WHENCE                               |  10 ++++++++++
> >  inside-secure/eip197_minifw/ifpp.bin | Bin 0 -> 100 bytes
> >  inside-secure/eip197_minifw/ipue.bin | Bin 0 -> 108 bytes
> >  3 files changed, 10 insertions(+)
> >  create mode 100644 inside-secure/eip197_minifw/ifpp.bin
> >  create mode 100644 inside-secure/eip197_minifw/ipue.bin
> 
> If this is GPLv2, where is the source code?
> 
Ok, I am not a lawyer so I don't know anything about this license stuff.
I just meant it is free to use and do whatever you want with.
GPLv2 was agreed with our lawyers for the driver source code, so I just
stuck that on the firmware as well (not looking forward to another time
consuming pass through the legal department!).

If GPLv2 implies that you have to provide source code, then what other 
license should I use that means freedom, but no source code?

Note that:

a) I actually *lost* the source code (no joke or excuse!)
b) This is for a proprietary in-house micro engine, so while we don't
   necessarily mind providing the source code, we don't want to provide
   any documentation or assembler for that. As we definitely don't want
   to *support* any other people messing with it. Making the source code 
   effectively useless anyway.

> josh
> 
> 
> > diff --git a/WHENCE b/WHENCE
> > index 31edbd4..fce2ef7 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -4514,3 +4514,13 @@ File: meson/vdec/gxl_mpeg4_5.bin
> >  File: meson/vdec/gxm_h264.bin
> >
> >  Licence: Redistributable. See LICENSE.amlogic_vdec for details.
> > +
> > +--------------------------------------------------------------------------
> > +
> > +Driver: inside-secure -- Inside Secure EIP197 crypto driver
> > +
> > +File: inside-secure/eip197_minifw/ipue.bin
> > +File: inside-secure/eip197_minifw/ifpp.bin
> > +
> > +Licence: GPLv2. See GPL-2 for details.
> > +
> > diff --git a/inside-secure/eip197_minifw/ifpp.bin
> > b/inside-secure/eip197_minifw/ifpp.bin
> > new file mode 100644
> > index 0000000..b4a8322
> > Binary files /dev/null and b/inside-secure/eip197_minifw/ifpp.bin differ
> > diff --git a/inside-secure/eip197_minifw/ipue.bin
> > b/inside-secure/eip197_minifw/ipue.bin
> > new file mode 100644
> > index 0000000..2f54999
> > Binary files /dev/null and b/inside-secure/eip197_minifw/ipue.bin differ

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
  2019-08-20 12:01   ` Pascal Van Leeuwen
@ 2019-08-20 13:09     ` Josh Boyer
  2019-08-21  8:44       ` Pascal Van Leeuwen
  0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2019-08-20 13:09 UTC (permalink / raw)
  To: Pascal Van Leeuwen; +Cc: Pascal van Leeuwen, Linux Firmware, linux-crypto

On Tue, Aug 20, 2019 at 8:01 AM Pascal Van Leeuwen
<pvanleeuwen@verimatrix.com> wrote:
>
> > -----Original Message-----
> > From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of
> > Josh Boyer
> > Sent: Thursday, August 15, 2019 1:33 PM
> > To: Pascal van Leeuwen <pascalvanl@gmail.com>
> > Cc: Linux Firmware <linux-firmware@kernel.org>; linux-crypto@vger.kernel.org
> > Subject: Re: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> >
> > On Tue, Aug 6, 2019 at 8:54 AM Pascal van Leeuwen <pascalvanl@gmail.com> wrote:
> > >
> > > The following changes since commit dff98c6c57383fe343407bcb7b6e775e0b87274f:
> > >
> > >   Merge branch 'master' of git://github.com/skeggsb/linux-firmware
> > > (2019-07-26 07:32:37 -0400)
> > >
> > > are available in the git repository at:
> > >
> > >
> > >   https://github.com/pvanleeuwen/linux-firmware-clean.git is_driver_fw
> > >
> > > for you to fetch changes up to fbfe41f92f941d19b840ec0e282f422379982ccb:
> > >
> > >   inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> > > (2019-08-06 13:19:44 +0200)
> > >
> > > ----------------------------------------------------------------
> > > Pascal van Leeuwen (1):
> > >       inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> > >
> > >  WHENCE                               |  10 ++++++++++
> > >  inside-secure/eip197_minifw/ifpp.bin | Bin 0 -> 100 bytes
> > >  inside-secure/eip197_minifw/ipue.bin | Bin 0 -> 108 bytes
> > >  3 files changed, 10 insertions(+)
> > >  create mode 100644 inside-secure/eip197_minifw/ifpp.bin
> > >  create mode 100644 inside-secure/eip197_minifw/ipue.bin
> >
> > If this is GPLv2, where is the source code?
> >
> Ok, I am not a lawyer so I don't know anything about this license stuff.
> I just meant it is free to use and do whatever you want with.
> GPLv2 was agreed with our lawyers for the driver source code, so I just
> stuck that on the firmware as well (not looking forward to another time
> consuming pass through the legal department!).
>
> If GPLv2 implies that you have to provide source code, then what other
> license should I use that means freedom, but no source code?

I understand that can be time consuming, but I am not a lawyer and not
going to give you legal advice, sorry.  I certainly can't tell you how
to license your own code.

> Note that:
>
> a) I actually *lost* the source code (no joke or excuse!)
> b) This is for a proprietary in-house micro engine, so while we don't
>    necessarily mind providing the source code, we don't want to provide
>    any documentation or assembler for that. As we definitely don't want
>    to *support* any other people messing with it. Making the source code
>    effectively useless anyway.

That doesn't sound like you want GPL at all, which is a strong
copyleft license that requires source and allows people to rebuild it.
Support is a different story and not really tied to the license.

josh

> > > diff --git a/WHENCE b/WHENCE
> > > index 31edbd4..fce2ef7 100644
> > > --- a/WHENCE
> > > +++ b/WHENCE
> > > @@ -4514,3 +4514,13 @@ File: meson/vdec/gxl_mpeg4_5.bin
> > >  File: meson/vdec/gxm_h264.bin
> > >
> > >  Licence: Redistributable. See LICENSE.amlogic_vdec for details.
> > > +
> > > +--------------------------------------------------------------------------
> > > +
> > > +Driver: inside-secure -- Inside Secure EIP197 crypto driver
> > > +
> > > +File: inside-secure/eip197_minifw/ipue.bin
> > > +File: inside-secure/eip197_minifw/ifpp.bin
> > > +
> > > +Licence: GPLv2. See GPL-2 for details.
> > > +
> > > diff --git a/inside-secure/eip197_minifw/ifpp.bin
> > > b/inside-secure/eip197_minifw/ifpp.bin
> > > new file mode 100644
> > > index 0000000..b4a8322
> > > Binary files /dev/null and b/inside-secure/eip197_minifw/ifpp.bin differ
> > > diff --git a/inside-secure/eip197_minifw/ipue.bin
> > > b/inside-secure/eip197_minifw/ipue.bin
> > > new file mode 100644
> > > index 0000000..2f54999
> > > Binary files /dev/null and b/inside-secure/eip197_minifw/ipue.bin differ
>
> Regards,
> Pascal van Leeuwen
> Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
> www.insidesecure.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
  2019-08-20 13:09     ` Josh Boyer
@ 2019-08-21  8:44       ` Pascal Van Leeuwen
  0 siblings, 0 replies; 5+ messages in thread
From: Pascal Van Leeuwen @ 2019-08-21  8:44 UTC (permalink / raw)
  To: Josh Boyer; +Cc: Pascal van Leeuwen, Linux Firmware, linux-crypto

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of
> Josh Boyer
> Sent: Tuesday, August 20, 2019 3:10 PM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> Cc: Pascal van Leeuwen <pascalvanl@gmail.com>; Linux Firmware <linux-firmware@kernel.org>;
> linux-crypto@vger.kernel.org
> Subject: Re: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> 
> On Tue, Aug 20, 2019 at 8:01 AM Pascal Van Leeuwen
> <pvanleeuwen@verimatrix.com> wrote:
> >
> > > -----Original Message-----
> > > From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On
> Behalf Of
> > > Josh Boyer
> > > Sent: Thursday, August 15, 2019 1:33 PM
> > > To: Pascal van Leeuwen <pascalvanl@gmail.com>
> > > Cc: Linux Firmware <linux-firmware@kernel.org>; linux-crypto@vger.kernel.org
> > > Subject: Re: [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197
> driver
> > >
> > > On Tue, Aug 6, 2019 at 8:54 AM Pascal van Leeuwen <pascalvanl@gmail.com> wrote:
> > > >
> > > > The following changes since commit dff98c6c57383fe343407bcb7b6e775e0b87274f:
> > > >
> > > >   Merge branch 'master' of git://github.com/skeggsb/linux-firmware
> > > > (2019-07-26 07:32:37 -0400)
> > > >
> > > > are available in the git repository at:
> > > >
> > > >
> > > >   https://github.com/pvanleeuwen/linux-firmware-clean.git is_driver_fw
> > > >
> > > > for you to fetch changes up to fbfe41f92f941d19b840ec0e282f422379982ccb:
> > > >
> > > >   inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> > > > (2019-08-06 13:19:44 +0200)
> > > >
> > > > ----------------------------------------------------------------
> > > > Pascal van Leeuwen (1):
> > > >       inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver
> > > >
> > > >  WHENCE                               |  10 ++++++++++
> > > >  inside-secure/eip197_minifw/ifpp.bin | Bin 0 -> 100 bytes
> > > >  inside-secure/eip197_minifw/ipue.bin | Bin 0 -> 108 bytes
> > > >  3 files changed, 10 insertions(+)
> > > >  create mode 100644 inside-secure/eip197_minifw/ifpp.bin
> > > >  create mode 100644 inside-secure/eip197_minifw/ipue.bin
> > >
> > > If this is GPLv2, where is the source code?
> > >
> > Ok, I am not a lawyer so I don't know anything about this license stuff.
> > I just meant it is free to use and do whatever you want with.
> > GPLv2 was agreed with our lawyers for the driver source code, so I just
> > stuck that on the firmware as well (not looking forward to another time
> > consuming pass through the legal department!).
> >
> > If GPLv2 implies that you have to provide source code, then what other
> > license should I use that means freedom, but no source code?
> 
> I understand that can be time consuming, but I am not a lawyer and not
> going to give you legal advice, sorry.  I certainly can't tell you how
> to license your own code.
> 
> > Note that:
> >
> > a) I actually *lost* the source code (no joke or excuse!)
> > b) This is for a proprietary in-house micro engine, so while we don't
> >    necessarily mind providing the source code, we don't want to provide
> >    any documentation or assembler for that. As we definitely don't want
> >    to *support* any other people messing with it. Making the source code
> >    effectively useless anyway.
> 
> That doesn't sound like you want GPL at all, which is a strong
> copyleft license that requires source and allows people to rebuild it.
> Support is a different story and not really tied to the license.
> 
Interestingly though, there are other firmwares in WHENCE alledgedly
being GPLv2 without providing sources, even stating "we prefer you not to
ask for the source". So it's certainly not enforced consistently.
(also, GPLv2 wise, you would be OK if you provide it on request only)

In any case, I can modify the license to "Redistributable" with some
copyright attached, that seems to be common practice as well. Since that
is actually more restrictive than GPLv2, it should be OK legally.

> josh
> 
> > > > diff --git a/WHENCE b/WHENCE
> > > > index 31edbd4..fce2ef7 100644
> > > > --- a/WHENCE
> > > > +++ b/WHENCE
> > > > @@ -4514,3 +4514,13 @@ File: meson/vdec/gxl_mpeg4_5.bin
> > > >  File: meson/vdec/gxm_h264.bin
> > > >
> > > >  Licence: Redistributable. See LICENSE.amlogic_vdec for details.
> > > > +
> > > > +--------------------------------------------------------------------------
> > > > +
> > > > +Driver: inside-secure -- Inside Secure EIP197 crypto driver
> > > > +
> > > > +File: inside-secure/eip197_minifw/ipue.bin
> > > > +File: inside-secure/eip197_minifw/ifpp.bin
> > > > +
> > > > +Licence: GPLv2. See GPL-2 for details.
> > > > +
> > > > diff --git a/inside-secure/eip197_minifw/ifpp.bin
> > > > b/inside-secure/eip197_minifw/ifpp.bin
> > > > new file mode 100644
> > > > index 0000000..b4a8322
> > > > Binary files /dev/null and b/inside-secure/eip197_minifw/ifpp.bin differ
> > > > diff --git a/inside-secure/eip197_minifw/ipue.bin
> > > > b/inside-secure/eip197_minifw/ipue.bin
> > > > new file mode 100644
> > > > index 0000000..2f54999
> > > > Binary files /dev/null and b/inside-secure/eip197_minifw/ipue.bin differ
> >
> > Regards,
> > Pascal van Leeuwen
> > Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
> > www.insidesecure.com



Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-08-21  8:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06 12:54 [GIT PULL] inside-secure: add new GPLv2 "mini" firmware for the EIP197 driver Pascal van Leeuwen
2019-08-15 11:32 ` Josh Boyer
2019-08-20 12:01   ` Pascal Van Leeuwen
2019-08-20 13:09     ` Josh Boyer
2019-08-21  8:44       ` Pascal Van Leeuwen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).