RE: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

RE: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Pascal Van Leeuwen]

Hi,

Just a gentle ping to remind people that this patch set - which incorporates the feedback I 
got on an earlier version thereof - has been pending for over a month now without 
receiving any feedback on it whatsoever ...

> -----Original Message-----
> From: Pascal van Leeuwen <pleeuwen@localhost.localdomain>
> Sent: Tuesday, June 25, 2019 3:37 PM
> To: linux-crypto@vger.kernel.org
> Cc: antoine.tenart@bootlin.com; herbert@gondor.apana.org.au; davem@davemloft.net; Pascal Van Leeuwen
> <pvanleeuwen@insidesecure.com>
> Subject: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope
> 
> From: Pascal van Leeuwen <pvanleeuwen@insidesecure.com>
> 
> This is a first baby step towards making the inside-secure crypto driver
> more broadly useful. The current driver only works for Marvell Armada HW
> and requires proprietary firmware, only available under NDA from Marvell,
> to be installed. This patch set allows the driver to be used with other
> hardware and removes the dependence on that proprietary firmware.
> 
> changes since v1:
> - changed dev_info's into dev_dbg to reduce normal verbosity
> - terminate all message strings with \n
> - use priv->version field strictly to enumerate device context
> - fixed some code & comment style issues
> - removed EIP97/197 references from messages
> - use #if(IS_ENABLED(CONFIG_PCI)) to remove all PCI related code
> - use #if(IS_ENABLED(CONFIG_OF)) to remove all device tree related code
> - do not inline the minifw but read it from /lib/firmware instead
> 
> Pascal van Leeuwen (3):
>   crypto: inside-secure - make driver selectable for non-Marvell
>     hardware
>   crypto: inside-secure - add support for PCI based FPGA development
>     board
>   crypto: inside-secure - add support for using the EIP197 without
>     vendor firmware
> 
>  drivers/crypto/Kconfig                         |  12 +-
>  drivers/crypto/inside-secure/safexcel.c        | 748 +++++++++++++++++--------
>  drivers/crypto/inside-secure/safexcel.h        |  36 +-
>  drivers/crypto/inside-secure/safexcel_cipher.c |  11 -
>  drivers/crypto/inside-secure/safexcel_hash.c   |  12 -
>  drivers/crypto/inside-secure/safexcel_ring.c   |   3 +-
>  6 files changed, 569 insertions(+), 253 deletions(-)
> 
> --
> 1.8.3.1

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com

Re: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[antoine.tenart]

Hi Pascal,

On Fri, Jul 26, 2019 at 11:33:07AM +0000, Pascal Van Leeuwen wrote:
> 
> Just a gentle ping to remind people that this patch set - which incorporates the feedback I 
> got on an earlier version thereof - has been pending for over a month now without 
> receiving any feedback on it whatsoever ...

I do not recall seeing this series and somehow I cannot find it in any
of my mailboxes or in patchwork. Would you care to send it again ?

I'm not sure if the issue with this series is on my side or if there was
an issue while sending it.

Thanks!
Antoine

> > From: Pascal van Leeuwen <pvanleeuwen@insidesecure.com>
> > 
> > This is a first baby step towards making the inside-secure crypto driver
> > more broadly useful. The current driver only works for Marvell Armada HW
> > and requires proprietary firmware, only available under NDA from Marvell,
> > to be installed. This patch set allows the driver to be used with other
> > hardware and removes the dependence on that proprietary firmware.
> > 
> > changes since v1:
> > - changed dev_info's into dev_dbg to reduce normal verbosity
> > - terminate all message strings with \n
> > - use priv->version field strictly to enumerate device context
> > - fixed some code & comment style issues
> > - removed EIP97/197 references from messages
> > - use #if(IS_ENABLED(CONFIG_PCI)) to remove all PCI related code
> > - use #if(IS_ENABLED(CONFIG_OF)) to remove all device tree related code
> > - do not inline the minifw but read it from /lib/firmware instead
> > 
> > Pascal van Leeuwen (3):
> >   crypto: inside-secure - make driver selectable for non-Marvell
> >     hardware
> >   crypto: inside-secure - add support for PCI based FPGA development
> >     board
> >   crypto: inside-secure - add support for using the EIP197 without
> >     vendor firmware
> > 
> >  drivers/crypto/Kconfig                         |  12 +-
> >  drivers/crypto/inside-secure/safexcel.c        | 748 +++++++++++++++++--------
> >  drivers/crypto/inside-secure/safexcel.h        |  36 +-
> >  drivers/crypto/inside-secure/safexcel_cipher.c |  11 -
> >  drivers/crypto/inside-secure/safexcel_hash.c   |  12 -
> >  drivers/crypto/inside-secure/safexcel_ring.c   |   3 +-
> >  6 files changed, 569 insertions(+), 253 deletions(-)
> > 
> > --
> > 1.8.3.1

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Herbert Xu]

On Fri, Jul 26, 2019 at 11:33:07AM +0000, Pascal Van Leeuwen wrote:
> Hi,
> 
> Just a gentle ping to remind people that this patch set - which incorporates the feedback I 
> got on an earlier version thereof - has been pending for over a month now without 
> receiving any feedback on it whatsoever ...

Your patches are not in patchwork.  If they're not there then
they won't be applied.  You need to find out why your emails
weren't accepted by the mailing list or patchwork.kernel.org.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

RE: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Pascal Van Leeuwen]

Herbert,

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of Herbert Xu
> Sent: Friday, July 26, 2019 2:03 PM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> Cc: linux-crypto@vger.kernel.org; antoine.tenart@bootlin.com; davem@davemloft.net
> Subject: Re: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope
> 
> On Fri, Jul 26, 2019 at 11:33:07AM +0000, Pascal Van Leeuwen wrote:
> > Hi,
> >
> > Just a gentle ping to remind people that this patch set - which incorporates the feedback I
> > got on an earlier version thereof - has been pending for over a month now without
> > receiving any feedback on it whatsoever ...
> 
> Your patches are not in patchwork.  If they're not there then
> they won't be applied.  You need to find out why your emails
> weren't accepted by the mailing list or patchwork.kernel.org.
> 

Actually, I did receive them back through the mailing list. In fact I depend
on the mailing list to get them into my own regular company mailbox as 
I have to send them through gmail from my Linux dev system ...
So I'm 100% confident they got sent out correctly.

I don't really know why they did not end up in patchwork? Is there
anything wrong with the formatting of the patches? If so, please
let me know so I can fix that prior to resending them(!) ...

> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com

Re: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Herbert Xu]

On Fri, Jul 26, 2019 at 12:21:40PM +0000, Pascal Van Leeuwen wrote:
>
> Actually, I did receive them back through the mailing list. In fact I depend
> on the mailing list to get them into my own regular company mailbox as 
> I have to send them through gmail from my Linux dev system ...
> So I'm 100% confident they got sent out correctly.

I just checked my linux-crypto archive and your patches are not
in there.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

RE: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Pascal Van Leeuwen]

Antoine,

> -----Original Message-----
> From: antoine.tenart@bootlin.com <antoine.tenart@bootlin.com>
> Sent: Friday, July 26, 2019 2:02 PM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> Cc: linux-crypto@vger.kernel.org; antoine.tenart@bootlin.com; herbert@gondor.apana.org.au; davem@davemloft.net
> Subject: Re: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope
> 
> Hi Pascal,
> 
> On Fri, Jul 26, 2019 at 11:33:07AM +0000, Pascal Van Leeuwen wrote:
> >
> > Just a gentle ping to remind people that this patch set - which incorporates the feedback I
> > got on an earlier version thereof - has been pending for over a month now without
> > receiving any feedback on it whatsoever ...
> 
> I do not recall seeing this series and somehow I cannot find it in any
> of my mailboxes or in patchwork. Would you care to send it again ?
> 
> I'm not sure if the issue with this series is on my side or if there was
> an issue while sending it.
> 
I can resend them as is, but I'm afraid I will then I will face the same problem of 
them not being added to patchwork ...

> Thanks!
> Antoine
> 
> > > From: Pascal van Leeuwen <pvanleeuwen@insidesecure.com>
> > >
> > > This is a first baby step towards making the inside-secure crypto driver
> > > more broadly useful. The current driver only works for Marvell Armada HW
> > > and requires proprietary firmware, only available under NDA from Marvell,
> > > to be installed. This patch set allows the driver to be used with other
> > > hardware and removes the dependence on that proprietary firmware.
> > >
> > > changes since v1:
> > > - changed dev_info's into dev_dbg to reduce normal verbosity
> > > - terminate all message strings with \n
> > > - use priv->version field strictly to enumerate device context
> > > - fixed some code & comment style issues
> > > - removed EIP97/197 references from messages
> > > - use #if(IS_ENABLED(CONFIG_PCI)) to remove all PCI related code
> > > - use #if(IS_ENABLED(CONFIG_OF)) to remove all device tree related code
> > > - do not inline the minifw but read it from /lib/firmware instead
> > >
> > > Pascal van Leeuwen (3):
> > >   crypto: inside-secure - make driver selectable for non-Marvell
> > >     hardware
> > >   crypto: inside-secure - add support for PCI based FPGA development
> > >     board
> > >   crypto: inside-secure - add support for using the EIP197 without
> > >     vendor firmware
> > >
> > >  drivers/crypto/Kconfig                         |  12 +-
> > >  drivers/crypto/inside-secure/safexcel.c        | 748 +++++++++++++++++--------
> > >  drivers/crypto/inside-secure/safexcel.h        |  36 +-
> > >  drivers/crypto/inside-secure/safexcel_cipher.c |  11 -
> > >  drivers/crypto/inside-secure/safexcel_hash.c   |  12 -
> > >  drivers/crypto/inside-secure/safexcel_ring.c   |   3 +-
> > >  6 files changed, 569 insertions(+), 253 deletions(-)
> > >
> > > --
> > > 1.8.3.1
> 
> --
> Antoine Ténart, Bootlin
> Embedded Linux and Kernel engineering
>

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com

RE: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Pascal Van Leeuwen]

Herbert,

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Friday, July 26, 2019 2:24 PM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> Cc: linux-crypto@vger.kernel.org; antoine.tenart@bootlin.com; davem@davemloft.net
> Subject: Re: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope
> 
> On Fri, Jul 26, 2019 at 12:21:40PM +0000, Pascal Van Leeuwen wrote:
> >
> > Actually, I did receive them back through the mailing list. In fact I depend
> > on the mailing list to get them into my own regular company mailbox as
> > I have to send them through gmail from my Linux dev system ...
> > So I'm 100% confident they got sent out correctly.
> 
> I just checked my linux-crypto archive and your patches are not
> in there.

On more careful observation, I noticed I also put my corporate e-mail on
the cc-list, so that's probably how I received them instead ...

They were sent to the mailing list, however. But I noticed that, for some
reason, they were sent from pleeuwen@localhost.localdomain instead
of my gmail, so I'm guessing the mailing list rejected them because of that?

Which now makes me wonder which of the patches I sent out ended up
on the mailing list at alll ...

> 
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com

Re: [PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Herbert Xu]

On Fri, Jul 26, 2019 at 12:34:06PM +0000, Pascal Van Leeuwen wrote:
>
> Which now makes me wonder which of the patches I sent out ended up
> on the mailing list at alll ...

Just check the patchwork list:

	https://patchwork.kernel.org/project/linux-crypto/list/

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCHv2 0/3] crypto: inside-secure - broaden driver scope

[Pascal van Leeuwen]

This is a first baby step towards making the inside-secure crypto driver
more broadly useful. The current driver only works for Marvell Armada HW
and requires proprietary firmware, only available under NDA from Marvell,
to be installed. This patch set allows the driver to be used with other
hardware and removes the dependence on that proprietary firmware.

changes since v1:
- changed dev_info's into dev_dbg to reduce normal verbosity
- terminate all message strings with \n
- use priv->version field strictly to enumerate device context
- fixed some code & comment style issues
- removed EIP97/197 references from messages
- use #if(IS_ENABLED(CONFIG_PCI)) to remove all PCI related code
- use #if(IS_ENABLED(CONFIG_OF)) to remove all device tree related code
- do not inline the minifw but read it from /lib/firmware instead

Pascal van Leeuwen (3):
  crypto: inside-secure - make driver selectable for non-Marvell
    hardware
  crypto: inside-secure - add support for PCI based FPGA development
    board
  crypto: inside-secure - add support for using the EIP197 without
    vendor firmware

 drivers/crypto/Kconfig                         |  12 +-
 drivers/crypto/inside-secure/safexcel.c        | 748 +++++++++++++++++--------
 drivers/crypto/inside-secure/safexcel.h        |  36 +-
 drivers/crypto/inside-secure/safexcel_cipher.c |  11 -
 drivers/crypto/inside-secure/safexcel_hash.c   |  12 -
 drivers/crypto/inside-secure/safexcel_ring.c   |   3 +-
 6 files changed, 569 insertions(+), 253 deletions(-)

-- 
1.8.3.1