From: Horia Geanta <horia.geanta@nxp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH] crypto: caam: print debugging hex dumps after unmapping
Date: Fri, 17 May 2019 06:11:09 +0000 [thread overview]
Message-ID: <VI1PR0402MB348565B9C2A68E7694B9B041980B0@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190516142442.32537-1-s.hauer@pengutronix.de
On 5/16/2019 5:24 PM, Sascha Hauer wrote:
> For encryption the destination pointer was still mapped, so the hex dump
> may be wrong. The IV still contained the input IV while printing instead
> of the output IV as intended.
>
> For decryption the destination pointer was still mapped, so the hex dump
> may be wrong. The IV dump was correct.
>
> Do the hex dumps consistenly after the buffers have been unmapped and
> in case of IV copied to their final destination.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Thanks,
Horia
next prev parent reply other threads:[~2019-05-17 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 14:24 [PATCH] crypto: caam: print debugging hex dumps after unmapping Sascha Hauer
2019-05-17 6:11 ` Horia Geanta [this message]
2019-05-23 6:52 ` [PATCH] crypto: caam - " Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2019-05-15 13:13 [PATCH] crypto: caam: " Sascha Hauer
2019-05-15 16:27 ` Horia Geanta
2019-05-16 14:25 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB348565B9C2A68E7694B9B041980B0@VI1PR0402MB3485.eurprd04.prod.outlook.com \
--to=horia.geanta@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).