From: Herbert Xu <herbert@gondor.apana.org.au>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-crypto@vger.kernel.org,
"Horia Geantă" <horia.geanta@nxp.com>,
kernel@pengutronix.de
Subject: Re: [PATCH] crypto: caam - print debugging hex dumps after unmapping
Date: Thu, 23 May 2019 14:52:17 +0800 [thread overview]
Message-ID: <20190523065217.7zf7vqf6zbbit6oo@gondor.apana.org.au> (raw)
In-Reply-To: <20190516142442.32537-1-s.hauer@pengutronix.de>
On Thu, May 16, 2019 at 04:24:42PM +0200, Sascha Hauer wrote:
> For encryption the destination pointer was still mapped, so the hex dump
> may be wrong. The IV still contained the input IV while printing instead
> of the output IV as intended.
>
> For decryption the destination pointer was still mapped, so the hex dump
> may be wrong. The IV dump was correct.
>
> Do the hex dumps consistenly after the buffers have been unmapped and
> in case of IV copied to their final destination.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
> ---
> drivers/crypto/caam/caamalg.c | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-05-23 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 14:24 [PATCH] crypto: caam: print debugging hex dumps after unmapping Sascha Hauer
2019-05-17 6:11 ` Horia Geanta
2019-05-23 6:52 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523065217.7zf7vqf6zbbit6oo@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).