* [PATCH 03/27] kbuild, KEYS: remove MODULE_LICENSE in non-modules
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
@ 2023-02-22 12:14 ` Nick Alcock
2023-02-22 12:14 ` [PATCH 16/27] kbuild, crypto: " Nick Alcock
2023-02-22 12:14 ` [PATCH 17/27] " Nick Alcock
2 siblings, 0 replies; 5+ messages in thread
From: Nick Alcock @ 2023-02-22 12:14 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, David Howells,
Herbert Xu, David S. Miller, keyrings, linux-crypto
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: keyrings@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
---
crypto/asymmetric_keys/asymmetric_type.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c
index 41a2f0eb4ce4..a5da8ccd353e 100644
--- a/crypto/asymmetric_keys/asymmetric_type.c
+++ b/crypto/asymmetric_keys/asymmetric_type.c
@@ -17,7 +17,6 @@
#include <keys/user-type.h>
#include "asymmetric_keys.h"
-MODULE_LICENSE("GPL");
const char *const key_being_used_for[NR__KEY_BEING_USED_FOR] = {
[VERIFYING_MODULE_SIGNATURE] = "mod sig",
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 16/27] kbuild, crypto: remove MODULE_LICENSE in non-modules
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 03/27] kbuild, KEYS: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-22 12:14 ` Nick Alcock
2023-02-23 10:18 ` Herbert Xu
2023-02-22 12:14 ` [PATCH 17/27] " Nick Alcock
2 siblings, 1 reply; 5+ messages in thread
From: Nick Alcock @ 2023-02-22 12:14 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Herbert Xu,
David S. Miller, linux-crypto
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
---
lib/crypto/blake2s-generic.c | 1 -
lib/crypto/blake2s.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/lib/crypto/blake2s-generic.c b/lib/crypto/blake2s-generic.c
index 75ccb3e633e6..4ffe3d927920 100644
--- a/lib/crypto/blake2s-generic.c
+++ b/lib/crypto/blake2s-generic.c
@@ -110,6 +110,5 @@ void blake2s_compress_generic(struct blake2s_state *state, const u8 *block,
EXPORT_SYMBOL(blake2s_compress_generic);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("BLAKE2s hash function");
MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
diff --git a/lib/crypto/blake2s.c b/lib/crypto/blake2s.c
index 98e688c6d891..71a316552cc5 100644
--- a/lib/crypto/blake2s.c
+++ b/lib/crypto/blake2s.c
@@ -67,6 +67,5 @@ static int __init blake2s_mod_init(void)
}
module_init(blake2s_mod_init);
-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("BLAKE2s hash function");
MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 17/27] kbuild, crypto: remove MODULE_LICENSE in non-modules
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 03/27] kbuild, KEYS: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-22 12:14 ` [PATCH 16/27] kbuild, crypto: " Nick Alcock
@ 2023-02-22 12:14 ` Nick Alcock
2023-02-23 10:21 ` Herbert Xu
2 siblings, 1 reply; 5+ messages in thread
From: Nick Alcock @ 2023-02-22 12:14 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Herbert Xu,
David S. Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86, linux-crypto
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: linux-crypto@vger.kernel.org
---
arch/x86/crypto/blake2s-glue.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/crypto/blake2s-glue.c b/arch/x86/crypto/blake2s-glue.c
index aaba21230528..0df9ec15643a 100644
--- a/arch/x86/crypto/blake2s-glue.c
+++ b/arch/x86/crypto/blake2s-glue.c
@@ -74,4 +74,3 @@ static int __init blake2s_mod_init(void)
module_init(blake2s_mod_init);
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 16/27] kbuild, crypto: remove MODULE_LICENSE in non-modules
2023-02-22 12:14 ` [PATCH 16/27] kbuild, crypto: " Nick Alcock
@ 2023-02-23 10:18 ` Herbert Xu
0 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2023-02-23 10:18 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
David S. Miller, linux-crypto
On Wed, Feb 22, 2023 at 12:14:42PM +0000, Nick Alcock wrote:
>
> diff --git a/lib/crypto/blake2s-generic.c b/lib/crypto/blake2s-generic.c
> index 75ccb3e633e6..4ffe3d927920 100644
> --- a/lib/crypto/blake2s-generic.c
> +++ b/lib/crypto/blake2s-generic.c
> @@ -110,6 +110,5 @@ void blake2s_compress_generic(struct blake2s_state *state, const u8 *block,
>
> EXPORT_SYMBOL(blake2s_compress_generic);
>
> -MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("BLAKE2s hash function");
> MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
Please remove all module-related code and the inclusion of
module.h.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 17/27] kbuild, crypto: remove MODULE_LICENSE in non-modules
2023-02-22 12:14 ` [PATCH 17/27] " Nick Alcock
@ 2023-02-23 10:21 ` Herbert Xu
0 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2023-02-23 10:21 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
David S. Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86, linux-crypto
On Wed, Feb 22, 2023 at 12:14:43PM +0000, Nick Alcock wrote:
>
> diff --git a/arch/x86/crypto/blake2s-glue.c b/arch/x86/crypto/blake2s-glue.c
> index aaba21230528..0df9ec15643a 100644
> --- a/arch/x86/crypto/blake2s-glue.c
> +++ b/arch/x86/crypto/blake2s-glue.c
> @@ -74,4 +74,3 @@ static int __init blake2s_mod_init(void)
>
> module_init(blake2s_mod_init);
>
> -MODULE_LICENSE("GPL v2");
Please change the module_init as well and remove module.h from
this file.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-23 10:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 03/27] kbuild, KEYS: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-22 12:14 ` [PATCH 16/27] kbuild, crypto: " Nick Alcock
2023-02-23 10:18 ` Herbert Xu
2023-02-22 12:14 ` [PATCH 17/27] " Nick Alcock
2023-02-23 10:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).