linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hwrng: mediatek: add mt7986 support
@ 2022-10-08 16:45 Frank Wunderlich
  2022-10-21 11:37 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Frank Wunderlich @ 2022-10-08 16:45 UTC (permalink / raw)
  To: linux-mediatek
  Cc: Mingming.Su, Sean Wang, Olivia Mackall, Herbert Xu,
	Matthias Brugger, linux-crypto, linux-arm-kernel, linux-kernel,
	Frank Wunderlich

From: "Mingming.Su" <Mingming.Su@mediatek.com>

1. Add trng compatible name for MT7986
2. Fix mtk_rng_wait_ready() function

Signed-off-by: Mingming.Su <Mingming.Su@mediatek.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 drivers/char/hw_random/mtk-rng.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/mtk-rng.c b/drivers/char/hw_random/mtk-rng.c
index 6c00ea008555..aa993753ab12 100644
--- a/drivers/char/hw_random/mtk-rng.c
+++ b/drivers/char/hw_random/mtk-rng.c
@@ -22,7 +22,7 @@
 #define RNG_AUTOSUSPEND_TIMEOUT		100
 
 #define USEC_POLL			2
-#define TIMEOUT_POLL			20
+#define TIMEOUT_POLL			60
 
 #define RNG_CTRL			0x00
 #define RNG_EN				BIT(0)
@@ -77,7 +77,7 @@ static bool mtk_rng_wait_ready(struct hwrng *rng, bool wait)
 		readl_poll_timeout_atomic(priv->base + RNG_CTRL, ready,
 					  ready & RNG_READY, USEC_POLL,
 					  TIMEOUT_POLL);
-	return !!ready;
+	return !!(ready & RNG_READY);
 }
 
 static int mtk_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
@@ -179,6 +179,7 @@ static const struct dev_pm_ops mtk_rng_pm_ops = {
 #endif	/* CONFIG_PM */
 
 static const struct of_device_id mtk_rng_match[] = {
+	{ .compatible = "mediatek,mt7986-rng" },
 	{ .compatible = "mediatek,mt7623-rng" },
 	{},
 };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwrng: mediatek: add mt7986 support
  2022-10-08 16:45 [PATCH] hwrng: mediatek: add mt7986 support Frank Wunderlich
@ 2022-10-21 11:37 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-10-21 11:37 UTC (permalink / raw)
  To: Frank Wunderlich
  Cc: linux-mediatek, Mingming.Su, Sean Wang, Olivia Mackall,
	Matthias Brugger, linux-crypto, linux-arm-kernel, linux-kernel,
	Frank Wunderlich

On Sat, Oct 08, 2022 at 06:45:53PM +0200, Frank Wunderlich wrote:
> From: "Mingming.Su" <Mingming.Su@mediatek.com>
> 
> 1. Add trng compatible name for MT7986
> 2. Fix mtk_rng_wait_ready() function
> 
> Signed-off-by: Mingming.Su <Mingming.Su@mediatek.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  drivers/char/hw_random/mtk-rng.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-21 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-08 16:45 [PATCH] hwrng: mediatek: add mt7986 support Frank Wunderlich
2022-10-21 11:37 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).