From: Nathan Chancellor <nathan@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Vladis Dronov <vdronov@redhat.com>,
Simo Sorce <ssorce@redhat.com>,
Eric Biggers <ebiggers@kernel.org>,
llvm@lists.linux.dev
Subject: Re: [v2 PATCH] crypto: api - Fix built-in testing dependency failures
Date: Tue, 5 Oct 2021 19:33:28 -0700 [thread overview]
Message-ID: <YV0K+EbrAqDdw2vp@archlinux-ax161> (raw)
In-Reply-To: <20211003002801.GA5435@gondor.apana.org.au>
On Sun, Oct 03, 2021 at 08:28:01AM +0800, Herbert Xu wrote:
> On Fri, Oct 01, 2021 at 11:01:59AM -0700, Nathan Chancellor wrote:
> >
> > I have attached the Kconfig file that I used to reproduce it. It is
> > still reproducible for me at your latest commit in cryptodev
> > (e42dff467ee688fe6b5a083f1837d06e3b27d8c0) with that exact command that
> > I gave you.
> >
> > It is possible that it could be crypto_boot_test_finished?
>
> I don't think that's the issue because algapi already depends on
> api. However, the softdep on cryptomgr in api looks suspicious,
> as it would always introduce a loop. Can you try removing that
> softdep from api.c and see if the problem resolves it self?
I assume this is the diff you mean? This does not resolve the issue. My
apologies if I am slow to respond, I am on vacation until the middle of
next week.
Cheers,
Nathan
diff --git a/crypto/api.c b/crypto/api.c
index ee5991fe11f8..e3e87c37f996 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -646,4 +646,3 @@ EXPORT_SYMBOL_GPL(crypto_req_done);
MODULE_DESCRIPTION("Cryptographic core API");
MODULE_LICENSE("GPL");
-MODULE_SOFTDEP("pre: cryptomgr");
next prev parent reply other threads:[~2021-10-06 2:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:12 [PATCH] crypto: api - Fix built-in testing dependency failures Herbert Xu
2021-09-13 18:16 ` Eric Biggers
2021-09-14 3:28 ` Herbert Xu
2021-09-17 0:26 ` [v2 PATCH] " Herbert Xu
2021-09-28 18:32 ` Nathan Chancellor
2021-10-01 5:50 ` Herbert Xu
2021-10-01 10:58 ` Naresh Kamboju
2021-10-01 18:01 ` Nathan Chancellor
2021-10-03 0:28 ` Herbert Xu
2021-10-06 2:33 ` Nathan Chancellor [this message]
2021-10-19 13:28 ` [PATCH] crypto: api - Do not create test larvals if manager is disabled Herbert Xu
2021-11-02 15:41 ` Geert Uytterhoeven
2021-11-04 7:28 ` Damien Le Moal
2021-11-04 7:58 ` Geert Uytterhoeven
2021-11-04 8:05 ` Damien Le Moal
2021-11-04 12:16 ` Herbert Xu
2021-11-04 13:11 ` Geert Uytterhoeven
2021-11-04 13:30 ` Herbert Xu
2021-11-04 15:18 ` Ido Schimmel
2021-11-05 7:26 ` crypto: api - Fix boot-up crash when crypto " Herbert Xu
2021-11-05 14:33 ` Ido Schimmel
2021-11-05 18:00 ` Geert Uytterhoeven
2021-10-26 16:33 ` [v2 PATCH] crypto: api - Fix built-in testing dependency failures Guenter Roeck
2021-10-27 2:59 ` Herbert Xu
2021-10-27 3:48 ` Guenter Roeck
2021-11-06 3:47 ` Herbert Xu
2021-11-06 14:55 ` Guenter Roeck
2021-12-22 10:22 ` Uwe Kleine-König
2021-12-22 10:37 ` Uwe Kleine-König
2021-12-29 2:05 ` Herbert Xu
2021-12-29 11:05 ` Uwe Kleine-König
2022-03-16 1:10 ` Herbert Xu
2022-03-16 16:37 ` Uwe Kleine-König
2022-03-16 21:44 ` Uwe Kleine-König
2022-03-16 22:38 ` Herbert Xu
2022-03-16 22:55 ` [PATCH] crypto: arm/aes-neonbs-cbc - Select generic cbc and aes Herbert Xu
2022-03-17 7:11 ` Uwe Kleine-König
2022-03-17 9:16 ` Philipp Zabel
2022-03-17 22:15 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV0K+EbrAqDdw2vp@archlinux-ax161 \
--to=nathan@kernel.org \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ssorce@redhat.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).