From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Herbert Xu" <herbert@gondor.apana.org.au>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Simo Sorce <ssorce@redhat.com>,
Eric Biggers <ebiggers@kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
kernel@pengutronix.de, Guenter Roeck <linux@roeck-us.net>,
Vladis Dronov <vdronov@redhat.com>,
Ard Biesheuvel <ardb@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: arm/aes-neonbs-cbc - Select generic cbc and aes
Date: Thu, 17 Mar 2022 10:16:16 +0100 [thread overview]
Message-ID: <c725d68e69dd7caf3ff6e78d11e41e2c4c3a05cc.camel@pengutronix.de> (raw)
In-Reply-To: <YjJq0RLIHvN7YWaT@gondor.apana.org.au>
On Do, 2022-03-17 at 10:55 +1200, Herbert Xu wrote:
> On Wed, Mar 16, 2022 at 05:37:19PM +0100, Uwe Kleine-König wrote:
> >
> > # CONFIG_CRYPTO_CBC is not set
>
> This was the issue. The failure occurs on registering __cbc_aes
> and the reason is that the neonbs cbc-aes requirs a fallback which
> isn't available due to CBC being disabled.
>
> I have no idea why this started occurring only with the testmgr
> change though as this should have been fatal all along.
I think this always failed and nobody that actually had CRYPTO_AES or
CRYPTO_CBC disabled noticed that aes-neonbs-cbc did not register.
What commit adad556efcdd caused was allowing the error path in
late_initcall(aes_init) to be hit before
late_initcall(crypto_algapi_init) would start the tests.
regards
Philipp
next prev parent reply other threads:[~2022-03-17 9:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:12 [PATCH] crypto: api - Fix built-in testing dependency failures Herbert Xu
2021-09-13 18:16 ` Eric Biggers
2021-09-14 3:28 ` Herbert Xu
2021-09-17 0:26 ` [v2 PATCH] " Herbert Xu
2021-09-28 18:32 ` Nathan Chancellor
2021-10-01 5:50 ` Herbert Xu
2021-10-01 10:58 ` Naresh Kamboju
2021-10-01 18:01 ` Nathan Chancellor
2021-10-03 0:28 ` Herbert Xu
2021-10-06 2:33 ` Nathan Chancellor
2021-10-19 13:28 ` [PATCH] crypto: api - Do not create test larvals if manager is disabled Herbert Xu
2021-11-02 15:41 ` Geert Uytterhoeven
2021-11-04 7:28 ` Damien Le Moal
2021-11-04 7:58 ` Geert Uytterhoeven
2021-11-04 8:05 ` Damien Le Moal
2021-11-04 12:16 ` Herbert Xu
2021-11-04 13:11 ` Geert Uytterhoeven
2021-11-04 13:30 ` Herbert Xu
2021-11-04 15:18 ` Ido Schimmel
2021-11-05 7:26 ` crypto: api - Fix boot-up crash when crypto " Herbert Xu
2021-11-05 14:33 ` Ido Schimmel
2021-11-05 18:00 ` Geert Uytterhoeven
2021-10-26 16:33 ` [v2 PATCH] crypto: api - Fix built-in testing dependency failures Guenter Roeck
2021-10-27 2:59 ` Herbert Xu
2021-10-27 3:48 ` Guenter Roeck
2021-11-06 3:47 ` Herbert Xu
2021-11-06 14:55 ` Guenter Roeck
2021-12-22 10:22 ` Uwe Kleine-König
2021-12-22 10:37 ` Uwe Kleine-König
2021-12-29 2:05 ` Herbert Xu
2021-12-29 11:05 ` Uwe Kleine-König
2022-03-16 1:10 ` Herbert Xu
2022-03-16 16:37 ` Uwe Kleine-König
2022-03-16 21:44 ` Uwe Kleine-König
2022-03-16 22:38 ` Herbert Xu
2022-03-16 22:55 ` [PATCH] crypto: arm/aes-neonbs-cbc - Select generic cbc and aes Herbert Xu
2022-03-17 7:11 ` Uwe Kleine-König
2022-03-17 9:16 ` Philipp Zabel [this message]
2022-03-17 22:15 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c725d68e69dd7caf3ff6e78d11e41e2c4c3a05cc.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ssorce@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).