* [PATCH] crypto: ccp - Ensure psp_ret is always init'd in __sev_platform_init_locked()
@ 2022-01-10 21:18 Peter Gonda
2022-01-28 6:22 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Peter Gonda @ 2022-01-10 21:18 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Gonda, Dan Carpenter, Tom Lendacky, Brijesh Singh,
Marc Orr, Herbert Xu, John Allen, David S. Miller, linux-crypto
Initialize psp_ret inside of __sev_platform_init_locked() because there
are many failure paths with PSP initialization that do not set
__sev_do_cmd_locked().
Fixes: e423b9d75e77: ("crypto: ccp - Move SEV_INIT retry for corrupted data")
Signed-off-by: Peter Gonda <pgonda@google.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Marc Orr <marcorr@google.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: John Allen <john.allen@amd.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/crypto/ccp/sev-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
index 8fd774a10edc..6ab93dfd478a 100644
--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -413,7 +413,7 @@ static int __sev_platform_init_locked(int *error)
{
struct psp_device *psp = psp_master;
struct sev_device *sev;
- int rc, psp_ret;
+ int rc, psp_ret = -1;
int (*init_function)(int *error);
if (!psp || !psp->sev_data)
--
2.34.1.575.g55b058a8bb-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: ccp - Ensure psp_ret is always init'd in __sev_platform_init_locked()
2022-01-10 21:18 [PATCH] crypto: ccp - Ensure psp_ret is always init'd in __sev_platform_init_locked() Peter Gonda
@ 2022-01-28 6:22 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-01-28 6:22 UTC (permalink / raw)
To: Peter Gonda
Cc: linux-kernel, Dan Carpenter, Tom Lendacky, Brijesh Singh,
Marc Orr, John Allen, David S. Miller, linux-crypto
On Mon, Jan 10, 2022 at 01:18:37PM -0800, Peter Gonda wrote:
> Initialize psp_ret inside of __sev_platform_init_locked() because there
> are many failure paths with PSP initialization that do not set
> __sev_do_cmd_locked().
>
> Fixes: e423b9d75e77: ("crypto: ccp - Move SEV_INIT retry for corrupted data")
>
> Signed-off-by: Peter Gonda <pgonda@google.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Marc Orr <marcorr@google.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: John Allen <john.allen@amd.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/crypto/ccp/sev-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-28 6:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10 21:18 [PATCH] crypto: ccp - Ensure psp_ret is always init'd in __sev_platform_init_locked() Peter Gonda
2022-01-28 6:22 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).