Re: mmotm 2022-04-25-17-59 uploaded (drivers/char/hw_random/mpfs-rng.c)

Re: mmotm 2022-04-25-17-59 uploaded (drivers/char/hw_random/mpfs-rng.c)

[Randy Dunlap]

[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]



On 4/25/22 17:59, Andrew Morton wrote:
> The mm-of-the-moment snapshot 2022-04-25-17-59 has been uploaded to
> 
>    https://www.ozlabs.org/~akpm/mmotm/
> 
> mmotm-readme.txt says
> 
> README for mm-of-the-moment:
> 
> https://www.ozlabs.org/~akpm/mmotm/
> 
> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> more than once a week.
> 
> You will need quilt to apply these patches to the latest Linus release (5.x
> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
> https://ozlabs.org/~akpm/mmotm/series
> 
> The file broken-out.tar.gz contains two datestamp files: .DATE and
> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
> followed by the base kernel version against which this patch series is to
> be applied.

on x86_64:

../drivers/char/hw_random/mpfs-rng.c: In function ‘mpfs_rng_read’:
../drivers/char/hw_random/mpfs-rng.c:49:9: error: implicit declaration of function ‘mpfs_blocking_transaction’ [-Werror=implicit-function-declaration]
   ret = mpfs_blocking_transaction(rng_priv->sys_controller, &msg);
         ^~~~~~~~~~~~~~~~~~~~~~~~~
  CC      net/bluetooth/hci_sock.o
  CC      lib/list-test.o
../drivers/char/hw_random/mpfs-rng.c: In function ‘mpfs_rng_probe’:
../drivers/char/hw_random/mpfs-rng.c:74:30: error: implicit declaration of function ‘mpfs_sys_controller_get’ [-Werror=implicit-function-declaration]
  rng_priv->sys_controller =  mpfs_sys_controller_get(&pdev->dev);
                              ^~~~~~~~~~~~~~~~~~~~~~~
../drivers/char/hw_random/mpfs-rng.c:74:27: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  rng_priv->sys_controller =  mpfs_sys_controller_get(&pdev->dev);
                           ^

CONFIG_HW_RANDOM_POLARFIRE_SOC=y
No other POLARFIRE kconfig symbols are set/enabled.
CONFIG_COMPILE_TEST=y

Full randconfig file is attached.


-- 
~Randy

[-- Attachment #2: config-r2719.gz --]
[-- Type: application/gzip, Size: 50038 bytes --]

Re: mmotm 2022-04-25-17-59 uploaded (drivers/char/hw_random/mpfs-rng.c)

[Conor.Dooley]

On 26/04/2022 04:19, Randy Dunlap wrote:
> 
> 
> On 4/25/22 17:59, Andrew Morton wrote:
>> The mm-of-the-moment snapshot 2022-04-25-17-59 has been uploaded to
>>
>>     https://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
>>
>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>> followed by the base kernel version against which this patch series is to
>> be applied.
> 
> on x86_64:
> 
> ../drivers/char/hw_random/mpfs-rng.c: In function ‘mpfs_rng_read’:
> ../drivers/char/hw_random/mpfs-rng.c:49:9: error: implicit declaration of function ‘mpfs_blocking_transaction’ [-Werror=implicit-function-declaration]
>     ret = mpfs_blocking_transaction(rng_priv->sys_controller, &msg);
>           ^~~~~~~~~~~~~~~~~~~~~~~~~
>    CC      net/bluetooth/hci_sock.o
>    CC      lib/list-test.o
> ../drivers/char/hw_random/mpfs-rng.c: In function ‘mpfs_rng_probe’:
> ../drivers/char/hw_random/mpfs-rng.c:74:30: error: implicit declaration of function ‘mpfs_sys_controller_get’ [-Werror=implicit-function-declaration]
>    rng_priv->sys_controller =  mpfs_sys_controller_get(&pdev->dev);
>                                ^~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/char/hw_random/mpfs-rng.c:74:27: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>    rng_priv->sys_controller =  mpfs_sys_controller_get(&pdev->dev);
>                             ^
> 
> CONFIG_HW_RANDOM_POLARFIRE_SOC=y
> No other POLARFIRE kconfig symbols are set/enabled.
> CONFIG_COMPILE_TEST=y
> 
> Full randconfig file is attached.
> 

Looks like a silly oversight on my part while reviewing 6a71277ce91e
("hwrng: mpfs - Enable COMPILE_TEST"), I forgot that the stubbed versions
of the system controller functions were removed during upstreaming.

@Herbert, would you rather revert the part of 6a71277ce91e that enables
compile test or I can send a patch for the stubbed versions now that
there is a user for them? (My preference would be to keep COMPILE_TEST)

Thanks,
Conor.

Re: mmotm 2022-04-25-17-59 uploaded (drivers/char/hw_random/mpfs-rng.c)

[Herbert Xu]

On Tue, Apr 26, 2022 at 06:36:27AM +0000, Conor.Dooley@microchip.com wrote:
>
> @Herbert, would you rather revert the part of 6a71277ce91e that enables
> compile test or I can send a patch for the stubbed versions now that
> there is a user for them? (My preference would be to keep COMPILE_TEST)

I'll just revert that patch because it turns out the underlying
option already supports COMPILE_TEST so this is redundant.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt