* [PATCH] crypto: sun8i-ss - Fix error codes for dma_mapping_error()
@ 2022-05-18 17:33 Dan Carpenter
2022-05-28 13:02 ` Corentin Labbe
2022-06-10 9:14 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-05-18 17:33 UTC (permalink / raw)
To: Corentin Labbe
Cc: Herbert Xu, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-crypto, linux-sunxi, kernel-janitors
If there is a dma_mapping_error() then return negative error codes.
Currently this code returns success.
Fixes: 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
index ac417a6b39e5..845019bd9591 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
@@ -586,7 +586,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
rctx->t_dst[k + 1].len = rctx->t_dst[k].len;
}
addr_xpad = dma_map_single(ss->dev, tfmctx->ipad, bs, DMA_TO_DEVICE);
- if (dma_mapping_error(ss->dev, addr_xpad)) {
+ err = dma_mapping_error(ss->dev, addr_xpad);
+ if (err) {
dev_err(ss->dev, "Fail to create DMA mapping of ipad\n");
goto err_dma_xpad;
}
@@ -612,7 +613,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)
goto err_dma_result;
}
addr_xpad = dma_map_single(ss->dev, tfmctx->opad, bs, DMA_TO_DEVICE);
- if (dma_mapping_error(ss->dev, addr_xpad)) {
+ err = dma_mapping_error(ss->dev, addr_xpad);
+ if (err) {
dev_err(ss->dev, "Fail to create DMA mapping of opad\n");
goto err_dma_xpad;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: sun8i-ss - Fix error codes for dma_mapping_error()
2022-05-18 17:33 [PATCH] crypto: sun8i-ss - Fix error codes for dma_mapping_error() Dan Carpenter
@ 2022-05-28 13:02 ` Corentin Labbe
2022-06-10 9:14 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2022-05-28 13:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Herbert Xu, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-crypto, linux-sunxi, kernel-janitors
Le Wed, May 18, 2022 at 08:33:54PM +0300, Dan Carpenter a écrit :
> If there is a dma_mapping_error() then return negative error codes.
> Currently this code returns success.
>
> Fixes: 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-on: sun8i-a83t-bananapi-m3
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: sun8i-ss - Fix error codes for dma_mapping_error()
2022-05-18 17:33 [PATCH] crypto: sun8i-ss - Fix error codes for dma_mapping_error() Dan Carpenter
2022-05-28 13:02 ` Corentin Labbe
@ 2022-06-10 9:14 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-06-10 9:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Corentin Labbe, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-crypto, linux-sunxi, kernel-janitors
On Wed, May 18, 2022 at 08:33:54PM +0300, Dan Carpenter wrote:
> If there is a dma_mapping_error() then return negative error codes.
> Currently this code returns success.
>
> Fixes: 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-10 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-18 17:33 [PATCH] crypto: sun8i-ss - Fix error codes for dma_mapping_error() Dan Carpenter
2022-05-28 13:02 ` Corentin Labbe
2022-06-10 9:14 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).