* [PATCH] crypto: sa2ul - Add CRYPTO_DES to CRYPTO_DEV_SA2UL
@ 2023-03-24 14:58 Jayesh Choudhary
2023-03-31 10:05 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Jayesh Choudhary @ 2023-03-24 14:58 UTC (permalink / raw)
To: herbert, davem; +Cc: j-keerthy, kristo, linux-crypto, linux-kernel, j-choudhary
From: Suman Anna <s-anna@ti.com>
The SA2UL Crypto driver provides support for couple of
DES3 algos "cbc(des3_ede)" and "ecb(des3_ede)", and enabling
the crypto selftest throws the following errors (as seen on
K3 J721E SoCs):
saul-crypto 4e00000.crypto: Error allocating fallback algo cbc(des3_ede)
alg: skcipher: failed to allocate transform for cbc-des3-sa2ul: -2
saul-crypto 4e00000.crypto: Error allocating fallback algo ecb(des3_ede)
alg: skcipher: failed to allocate transform for ecb-des3-sa2ul: -2
Fix this by selecting CRYPTO_DES which was missed while
adding base driver support.
Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 3b2516d1433f..20222e321a43 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -810,6 +810,7 @@ config CRYPTO_DEV_SA2UL
select CRYPTO_AES
select CRYPTO_ALGAPI
select CRYPTO_AUTHENC
+ select CRYPTO_DES
select CRYPTO_SHA1
select CRYPTO_SHA256
select CRYPTO_SHA512
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: sa2ul - Add CRYPTO_DES to CRYPTO_DEV_SA2UL
2023-03-24 14:58 [PATCH] crypto: sa2ul - Add CRYPTO_DES to CRYPTO_DEV_SA2UL Jayesh Choudhary
@ 2023-03-31 10:05 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2023-03-31 10:05 UTC (permalink / raw)
To: Jayesh Choudhary; +Cc: davem, j-keerthy, kristo, linux-crypto, linux-kernel
On Fri, Mar 24, 2023 at 08:28:12PM +0530, Jayesh Choudhary wrote:
> From: Suman Anna <s-anna@ti.com>
>
> The SA2UL Crypto driver provides support for couple of
> DES3 algos "cbc(des3_ede)" and "ecb(des3_ede)", and enabling
> the crypto selftest throws the following errors (as seen on
> K3 J721E SoCs):
> saul-crypto 4e00000.crypto: Error allocating fallback algo cbc(des3_ede)
> alg: skcipher: failed to allocate transform for cbc-des3-sa2ul: -2
> saul-crypto 4e00000.crypto: Error allocating fallback algo ecb(des3_ede)
> alg: skcipher: failed to allocate transform for ecb-des3-sa2ul: -2
>
> Fix this by selecting CRYPTO_DES which was missed while
> adding base driver support.
>
> Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-31 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 14:58 [PATCH] crypto: sa2ul - Add CRYPTO_DES to CRYPTO_DEV_SA2UL Jayesh Choudhary
2023-03-31 10:05 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).