* [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree()
@ 2023-08-02 9:14 Yang Yingliang
2023-08-03 9:19 ` Giovanni Cabiddu
2023-08-11 11:29 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2023-08-02 9:14 UTC (permalink / raw)
To: qat-linux, linux-crypto; +Cc: giovanni.cabiddu, herbert, davem, yangyingliang
Use kfree_sensitive() instead of memset() and kfree().
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/crypto/intel/qat/qat_common/qat_compression.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/crypto/intel/qat/qat_common/qat_compression.c b/drivers/crypto/intel/qat/qat_common/qat_compression.c
index 3f1f35283266..7842a9f22178 100644
--- a/drivers/crypto/intel/qat/qat_common/qat_compression.c
+++ b/drivers/crypto/intel/qat/qat_common/qat_compression.c
@@ -234,8 +234,7 @@ static void qat_free_dc_data(struct adf_accel_dev *accel_dev)
dma_unmap_single(dev, dc_data->ovf_buff_p, dc_data->ovf_buff_sz,
DMA_FROM_DEVICE);
- memset(dc_data->ovf_buff, 0, dc_data->ovf_buff_sz);
- kfree(dc_data->ovf_buff);
+ kfree_sensitive(dc_data->ovf_buff);
devm_kfree(dev, dc_data);
accel_dev->dc_data = NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree()
2023-08-02 9:14 [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree() Yang Yingliang
@ 2023-08-03 9:19 ` Giovanni Cabiddu
2023-08-11 11:29 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Giovanni Cabiddu @ 2023-08-03 9:19 UTC (permalink / raw)
To: Yang Yingliang; +Cc: qat-linux, linux-crypto, herbert, davem
On Wed, Aug 02, 2023 at 05:14:27PM +0800, Yang Yingliang wrote:
> Use kfree_sensitive() instead of memset() and kfree().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree()
2023-08-02 9:14 [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree() Yang Yingliang
2023-08-03 9:19 ` Giovanni Cabiddu
@ 2023-08-11 11:29 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2023-08-11 11:29 UTC (permalink / raw)
To: Yang Yingliang; +Cc: qat-linux, linux-crypto, giovanni.cabiddu, davem
On Wed, Aug 02, 2023 at 05:14:27PM +0800, Yang Yingliang wrote:
> Use kfree_sensitive() instead of memset() and kfree().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/crypto/intel/qat/qat_common/qat_compression.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-11 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-02 9:14 [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree() Yang Yingliang
2023-08-03 9:19 ` Giovanni Cabiddu
2023-08-11 11:29 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).