* [PATCH -next] crypto: hisilicon/sec - Do not check for 0 return after calling platform_get_irq()
@ 2023-08-03 9:29 Ruan Jinjie
2023-08-11 11:30 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Ruan Jinjie @ 2023-08-03 9:29 UTC (permalink / raw)
To: linux-crypto, Herbert Xu, David S. Miller; +Cc: ruanjinjie
Since commit ce753ad1549c ("platform: finally disallow IRQ0 in
platform_get_irq() and its ilk"), there is no possible for
platform_get_irq() to return 0. Use the return value
from platform_get_irq().
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/crypto/hisilicon/sec/sec_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/hisilicon/sec/sec_drv.c b/drivers/crypto/hisilicon/sec/sec_drv.c
index e75851326c1e..e1e08993de12 100644
--- a/drivers/crypto/hisilicon/sec/sec_drv.c
+++ b/drivers/crypto/hisilicon/sec/sec_drv.c
@@ -1107,8 +1107,8 @@ static int sec_queue_res_cfg(struct sec_queue *queue)
}
queue->task_irq = platform_get_irq(to_platform_device(dev),
queue->queue_id * 2 + 1);
- if (queue->task_irq <= 0) {
- ret = -EINVAL;
+ if (queue->task_irq < 0) {
+ ret = queue->task_irq;
goto err_free_ring_db;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] crypto: hisilicon/sec - Do not check for 0 return after calling platform_get_irq()
2023-08-03 9:29 [PATCH -next] crypto: hisilicon/sec - Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
@ 2023-08-11 11:30 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2023-08-11 11:30 UTC (permalink / raw)
To: Ruan Jinjie; +Cc: linux-crypto, David S. Miller
On Thu, Aug 03, 2023 at 05:29:33PM +0800, Ruan Jinjie wrote:
> Since commit ce753ad1549c ("platform: finally disallow IRQ0 in
> platform_get_irq() and its ilk"), there is no possible for
> platform_get_irq() to return 0. Use the return value
> from platform_get_irq().
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/crypto/hisilicon/sec/sec_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-11 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 9:29 [PATCH -next] crypto: hisilicon/sec - Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
2023-08-11 11:30 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).