* [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init()
@ 2024-01-09 2:19 Minjie Du
2024-01-09 16:25 ` Tom Zanussi
2024-01-26 9:01 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Minjie Du @ 2024-01-09 2:19 UTC (permalink / raw)
To: Tom Zanussi, Herbert Xu, David S. Miller,
open list:INTEL IAA CRYPTO DRIVER, open list
Cc: opensource.kernel, Minjie Du
This patch removes the debugfs_create_dir() error checking in
iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is developed
in a way that the caller can safely handle the errors that
occur during the creation of DebugFS nodes.
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
index 2e3b7b73af20..cbf87d0effe3 100644
--- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
+++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
@@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void)
return -ENODEV;
iaa_crypto_debugfs_root = debugfs_create_dir("iaa_crypto", NULL);
- if (!iaa_crypto_debugfs_root)
- return -ENOMEM;
debugfs_create_u64("max_comp_delay_ns", 0644,
iaa_crypto_debugfs_root, &max_comp_delay_ns);
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init()
2024-01-09 2:19 [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init() Minjie Du
@ 2024-01-09 16:25 ` Tom Zanussi
2024-01-26 9:01 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Tom Zanussi @ 2024-01-09 16:25 UTC (permalink / raw)
To: Minjie Du, Herbert Xu, David S. Miller,
open list:INTEL IAA CRYPTO DRIVER, open list
Cc: opensource.kernel
On Tue, 2024-01-09 at 10:19 +0800, Minjie Du wrote:
> This patch removes the debugfs_create_dir() error checking in
> iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is
> developed
> in a way that the caller can safely handle the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Thanks Minjie,
Tom
> ---
> drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> index 2e3b7b73af20..cbf87d0effe3 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> @@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void)
> return -ENODEV;
>
> iaa_crypto_debugfs_root = debugfs_create_dir("iaa_crypto",
> NULL);
> - if (!iaa_crypto_debugfs_root)
> - return -ENOMEM;
>
> debugfs_create_u64("max_comp_delay_ns", 0644,
> iaa_crypto_debugfs_root,
> &max_comp_delay_ns);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init()
2024-01-09 2:19 [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init() Minjie Du
2024-01-09 16:25 ` Tom Zanussi
@ 2024-01-26 9:01 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2024-01-26 9:01 UTC (permalink / raw)
To: Minjie Du
Cc: Tom Zanussi, David S. Miller, open list:INTEL IAA CRYPTO DRIVER,
open list, opensource.kernel
On Tue, Jan 09, 2024 at 10:19:14AM +0800, Minjie Du wrote:
> This patch removes the debugfs_create_dir() error checking in
> iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is developed
> in a way that the caller can safely handle the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-26 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-09 2:19 [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init() Minjie Du
2024-01-09 16:25 ` Tom Zanussi
2024-01-26 9:01 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).