* [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc()
@ 2024-01-21 15:34 Erick Archer
2024-01-22 17:53 ` Gustavo A. R. Silva
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Erick Archer @ 2024-01-21 15:34 UTC (permalink / raw)
To: Corentin Labbe, Herbert Xu, David S. Miller, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Jonathan Corbet,
Gustavo A. R. Silva
Cc: Erick Archer, linux-crypto, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-hardening
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.
So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.
Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
index d358334e5981..ee2a28c906ed 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
@@ -362,7 +362,7 @@ int sun8i_ce_hash_run(struct crypto_engine *engine, void *breq)
digestsize = SHA512_DIGEST_SIZE;
/* the padding could be up to two block. */
- buf = kzalloc(bs * 2, GFP_KERNEL | GFP_DMA);
+ buf = kcalloc(2, bs, GFP_KERNEL | GFP_DMA);
if (!buf) {
err = -ENOMEM;
goto theend;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc()
2024-01-21 15:34 [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc() Erick Archer
@ 2024-01-22 17:53 ` Gustavo A. R. Silva
2024-01-23 17:45 ` Jernej Škrabec
2024-01-26 9:06 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2024-01-22 17:53 UTC (permalink / raw)
To: Erick Archer, Corentin Labbe, Herbert Xu, David S. Miller,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Jonathan Corbet,
Gustavo A. R. Silva
Cc: linux-crypto, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-hardening
On 1/21/24 09:34, Erick Archer wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, use the purpose specific kcalloc() function instead of the argument
> size * count in the kzalloc() function.
>
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks!
--
Gustavo
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
> index d358334e5981..ee2a28c906ed 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c
> @@ -362,7 +362,7 @@ int sun8i_ce_hash_run(struct crypto_engine *engine, void *breq)
> digestsize = SHA512_DIGEST_SIZE;
>
> /* the padding could be up to two block. */
> - buf = kzalloc(bs * 2, GFP_KERNEL | GFP_DMA);
> + buf = kcalloc(2, bs, GFP_KERNEL | GFP_DMA);
> if (!buf) {
> err = -ENOMEM;
> goto theend;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc()
2024-01-21 15:34 [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc() Erick Archer
2024-01-22 17:53 ` Gustavo A. R. Silva
@ 2024-01-23 17:45 ` Jernej Škrabec
2024-01-26 9:06 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2024-01-23 17:45 UTC (permalink / raw)
To: Corentin Labbe, Herbert Xu, David S. Miller, Chen-Yu Tsai,
Samuel Holland, Jonathan Corbet, Gustavo A. R. Silva,
Erick Archer
Cc: Erick Archer, linux-crypto, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-hardening
Dne nedelja, 21. januar 2024 ob 16:34:07 CET je Erick Archer napisal(a):
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, use the purpose specific kcalloc() function instead of the argument
> size * count in the kzalloc() function.
>
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc()
2024-01-21 15:34 [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc() Erick Archer
2024-01-22 17:53 ` Gustavo A. R. Silva
2024-01-23 17:45 ` Jernej Škrabec
@ 2024-01-26 9:06 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2024-01-26 9:06 UTC (permalink / raw)
To: Erick Archer
Cc: Corentin Labbe, David S. Miller, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Jonathan Corbet, Gustavo A. R. Silva,
linux-crypto, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-hardening
On Sun, Jan 21, 2024 at 04:34:07PM +0100, Erick Archer wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, use the purpose specific kcalloc() function instead of the argument
> size * count in the kzalloc() function.
>
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-26 9:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-21 15:34 [PATCH] crypto: sun8i-ce - Use kcalloc() instead of kzalloc() Erick Archer
2024-01-22 17:53 ` Gustavo A. R. Silva
2024-01-23 17:45 ` Jernej Škrabec
2024-01-26 9:06 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).