* [PATCH] crypto: fix flexible_array.cocci warnings
@ 2021-06-29 11:48 Julia Lawall
2021-07-16 7:26 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2021-06-29 11:48 UTC (permalink / raw)
To: Megha Dey; +Cc: labuser, Tomasz Kantecki, Herbert Xu, linux-crypto, kbuild-all
From: kernel test robot <lkp@intel.com>
Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.
Generated by: scripts/coccinelle/misc/flexible_array.cocci
Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC: Megha Dey <megha.dey@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/meghadey/crypto for_crypto_avx512
head: a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
aesni-intel_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
u64 partial_block_len;
u64 unused;
/* Allocate space for hash_keys later */
- u8 hash_keys[0];
+ u8 hash_keys[];
};
asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: fix flexible_array.cocci warnings
2021-06-29 11:48 [PATCH] crypto: fix flexible_array.cocci warnings Julia Lawall
@ 2021-07-16 7:26 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-07-16 7:26 UTC (permalink / raw)
To: Julia Lawall
Cc: Megha Dey, labuser, Tomasz Kantecki, linux-crypto, kbuild-all
On Tue, Jun 29, 2021 at 01:48:01PM +0200, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
>
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>
> Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
> CC: Megha Dey <megha.dey@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree: https://github.com/meghadey/crypto for_crypto_avx512
> head: a89c5880f0d6260dd593bf579df26f2a2d56ac32
> commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 hours ago
> :::::: commit date: 7 hours ago
>
> aesni-intel_glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
> u64 partial_block_len;
> u64 unused;
> /* Allocate space for hash_keys later */
> - u8 hash_keys[0];
> + u8 hash_keys[];
Unfortunately this patch doesn't apply to the current crypto tree.
But the good news is that the current tree no longer has a zero-
length array in that struct.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: fix flexible_array.cocci warnings
2021-11-12 10:56 Julia Lawall
@ 2021-11-20 4:06 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-11-20 4:06 UTC (permalink / raw)
To: Julia Lawall
Cc: Megha Dey, kbuild-all, linux-kernel, Tomasz Kantecki,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, linux-crypto
On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
>
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
>
> tree: https://github.com/meghadey/crypto crypto-avx512
> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 weeks ago
> :::::: commit date: 7 weeks ago
>
> aesni-intel_glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
> u64 partial_block_len;
> u64 unused;
> /* Allocate space for hash_keys later */
> - u8 hash_keys[0];
> + u8 hash_keys[];
Which tree did this come from? Not only is this not zero in my
tree, but it seems to have never been zero in the git history.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] crypto: fix flexible_array.cocci warnings
@ 2021-11-12 10:56 Julia Lawall
2021-11-20 4:06 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2021-11-12 10:56 UTC (permalink / raw)
To: Megha Dey
Cc: kbuild-all, linux-kernel, Tomasz Kantecki, Herbert Xu,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin, linux-crypto, linux-kernel
From: kernel test robot <lkp@intel.com>
Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.
Generated by: scripts/coccinelle/misc/flexible_array.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/meghadey/crypto crypto-avx512
head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 weeks ago
:::::: commit date: 7 weeks ago
aesni-intel_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
u64 partial_block_len;
u64 unused;
/* Allocate space for hash_keys later */
- u8 hash_keys[0];
+ u8 hash_keys[];
};
asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-20 4:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 11:48 [PATCH] crypto: fix flexible_array.cocci warnings Julia Lawall
2021-07-16 7:26 ` Herbert Xu
2021-11-12 10:56 Julia Lawall
2021-11-20 4:06 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).