From: Paolo Bonzini <pbonzini@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>,
simon.guinot@sequanux.org, linux-efi@vger.kernel.org,
kvm@vger.kernel.org, rkrcmar@redhat.com,
matt@codeblueprint.co.uk, linux-pci@vger.kernel.org,
linus.walleij@linaro.org, gary.hook@amd.com, linux-mm@kvack.org,
paul.gortmaker@windriver.com, hpa@zytor.com, cl@linux.com,
dan.j.williams@intel.com, aarcange@redhat.com,
sfr@canb.auug.org.au, andriy.shevchenko@linux.intel.com,
herbert@gondor.apana.org.au, bhe@redhat.com, xemul@parallels.com,
joro@8bytes.org, x86@kernel.org, peterz@infradead.org,
piotr.luc@intel.com, mingo@redhat.com, msalter@redhat.com,
ross.zwisler@linux.intel.com, bp@suse.de, dyoung@redhat.com,
thomas.lendacky@amd.com, jroedel@suse.de, keescook@chromium.org,
arnd@arndb.de, toshi.kani@hpe.com,
mathieu.desnoyers@efficios.com, luto
Subject: Re: [RFC PATCH v2 29/32] kvm: svm: Add support for SEV DEBUG_DECRYPT command
Date: Fri, 17 Mar 2017 12:09:42 +0100 [thread overview]
Message-ID: <ca24bbc2-25cf-a5ca-cd39-5862036214bb__25132.5921774425$1489749165$gmane$org@redhat.com> (raw)
In-Reply-To: <d89ef60d-a97c-b712-fb0f-0242ebebb91a@amd.com>
On 16/03/2017 19:41, Brijesh Singh wrote:
>>
>> Please do add it, it doesn't seem very different from what you're doing
>> in LAUNCH_UPDATE_DATA. There's no need for a separate
>> __sev_dbg_decrypt_page function, you can just pin/unpin here and do a
>> per-page loop as in LAUNCH_UPDATE_DATA.
>
> I can certainly add support to handle crossing the page boundary cases.
> Should we limit the size to prevent user passing arbitrary long length
> and we end up looping inside the kernel? I was thinking to limit to a
> PAGE_SIZE.
I guess it depends on how it's used. PAGE_SIZE makes sense since you
only know if a physical address is encrypted when you reach it from a
visit of the page tables.
Paolo
next prev parent reply other threads:[~2017-03-17 11:12 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <148846752022.2349.13667498174822419498.stgit@brijesh-build-machine>
2017-03-02 15:12 ` [RFC PATCH v2 01/32] x86: Add the Secure Encrypted Virtualization CPU feature Brijesh Singh
2017-03-02 15:12 ` [RFC PATCH v2 02/32] x86: Secure Encrypted Virtualization (SEV) support Brijesh Singh
2017-03-02 15:12 ` [RFC PATCH v2 03/32] KVM: SVM: prepare for new bit definition in nested_ctl Brijesh Singh
2017-03-02 15:12 ` [RFC PATCH v2 04/32] KVM: SVM: Add SEV feature definitions to KVM Brijesh Singh
2017-03-02 15:12 ` [RFC PATCH v2 05/32] x86: Use encrypted access of BOOT related data with SEV Brijesh Singh
2017-03-02 15:13 ` [RFC PATCH v2 06/32] x86/pci: Use memremap when walking setup data Brijesh Singh
2017-03-02 15:13 ` [RFC PATCH v2 07/32] x86/efi: Access EFI data as encrypted when SEV is active Brijesh Singh
2017-03-02 15:13 ` [RFC PATCH v2 08/32] x86: Use PAGE_KERNEL protection for ioremap of memory page Brijesh Singh
2017-03-02 15:13 ` [RFC PATCH v2 09/32] x86: Change early_ioremap to early_memremap for BOOT data Brijesh Singh
2017-03-02 15:14 ` [RFC PATCH v2 10/32] x86: DMA support for SEV memory encryption Brijesh Singh
2017-03-02 15:14 ` [RFC PATCH v2 11/32] x86: Unroll string I/O when SEV is active Brijesh Singh
2017-03-02 15:14 ` [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active Brijesh Singh
2017-03-02 15:15 ` [RFC PATCH v2 13/32] KVM: SVM: Enable SEV by setting the SEV_ENABLE CPU feature Brijesh Singh
2017-03-02 15:15 ` [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages Brijesh Singh
2017-03-02 15:15 ` [RFC PATCH v2 15/32] x86: Add support for changing memory encryption attribute in early boot Brijesh Singh
2017-03-02 15:15 ` [RFC PATCH v2 16/32] x86: kvm: Provide support to create Guest and HV shared per-CPU variables Brijesh Singh
2017-03-02 15:15 ` [RFC PATCH v2 17/32] x86: kvmclock: Clear encryption attribute when SEV is active Brijesh Singh
2017-03-02 15:16 ` [RFC PATCH v2 18/32] kvm: svm: Use the hardware provided GPA instead of page walk Brijesh Singh
2017-03-02 15:16 ` [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device Brijesh Singh
2017-03-02 15:16 ` [RFC PATCH v2 20/32] crypto: ccp: Add Platform Security Processor (PSP) interface support Brijesh Singh
2017-03-02 15:16 ` [RFC PATCH v2 21/32] crypto: ccp: Add Secure Encrypted Virtualization (SEV) " Brijesh Singh
2017-03-02 15:16 ` [RFC PATCH v2 22/32] kvm: svm: prepare to reserve asid for SEV guest Brijesh Singh
2017-03-02 15:17 ` [RFC PATCH v2 23/32] kvm: introduce KVM_MEMORY_ENCRYPT_OP ioctl Brijesh Singh
2017-03-02 15:17 ` [RFC PATCH v2 24/32] kvm: x86: prepare for SEV guest management API support Brijesh Singh
2017-03-02 15:17 ` [RFC PATCH v2 25/32] kvm: svm: Add support for SEV LAUNCH_START command Brijesh Singh
2017-03-02 15:17 ` [RFC PATCH v2 26/32] kvm: svm: Add support for SEV LAUNCH_UPDATE_DATA command Brijesh Singh
2017-03-02 15:17 ` [RFC PATCH v2 27/32] kvm: svm: Add support for SEV LAUNCH_FINISH command Brijesh Singh
2017-03-02 15:18 ` [RFC PATCH v2 28/32] kvm: svm: Add support for SEV GUEST_STATUS command Brijesh Singh
2017-03-02 15:18 ` [RFC PATCH v2 29/32] kvm: svm: Add support for SEV DEBUG_DECRYPT command Brijesh Singh
2017-03-02 15:18 ` [RFC PATCH v2 30/32] kvm: svm: Add support for SEV DEBUG_ENCRYPT command Brijesh Singh
2017-03-02 15:18 ` [RFC PATCH v2 31/32] kvm: svm: Add support for SEV LAUNCH_MEASURE command Brijesh Singh
2017-03-02 15:18 ` [RFC PATCH v2 32/32] x86: kvm: Pin the guest memory when SEV is active Brijesh Singh
[not found] ` <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine>
2017-03-02 17:39 ` [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device Mark Rutland
2017-03-02 19:11 ` Brijesh Singh
2017-03-03 13:55 ` Andy Shevchenko
[not found] ` <148846752953.2349.17505492128445909591.stgit@brijesh-build-machine>
2017-03-03 16:59 ` [RFC PATCH v2 01/32] x86: Add the Secure Encrypted Virtualization CPU feature Borislav Petkov
2017-03-03 21:01 ` Brijesh Singh
2017-03-04 10:11 ` Borislav Petkov
2017-03-06 18:11 ` Brijesh Singh
2017-03-06 20:54 ` Borislav Petkov
2017-03-03 20:33 ` [RFC PATCH v2 00/32] x86: Secure Encrypted Virtualization (AMD) Bjorn Helgaas
2017-03-03 20:51 ` Borislav Petkov
2017-03-03 21:15 ` Brijesh Singh
[not found] ` <148846759008.2349.8274808454274279039.stgit@brijesh-build-machine>
2017-03-03 20:42 ` [RFC PATCH v2 06/32] x86/pci: Use memremap when walking setup data Bjorn Helgaas
2017-03-03 21:15 ` Tom Lendacky
2017-03-07 0:03 ` Bjorn Helgaas
2017-03-13 20:08 ` Tom Lendacky
[not found] ` <148846756856.2349.18360437323368784256.stgit@brijesh-build-machine>
2017-03-07 0:50 ` [RFC PATCH v2 04/32] KVM: SVM: Add SEV feature definitions to KVM Borislav Petkov
[not found] ` <148846757895.2349.561582698953591240.stgit@brijesh-build-machine>
2017-03-07 11:09 ` [RFC PATCH v2 05/32] x86: Use encrypted access of BOOT related data with SEV Borislav Petkov
2017-03-16 19:03 ` Tom Lendacky
[not found] ` <148846760142.2349.8522516472305792434.stgit@brijesh-build-machine>
2017-03-07 11:57 ` [RFC PATCH v2 07/32] x86/efi: Access EFI data as encrypted when SEV is active Borislav Petkov
[not found] ` <148846761276.2349.4899767672892365544.stgit@brijesh-build-machine>
2017-03-07 14:59 ` [RFC PATCH v2 08/32] x86: Use PAGE_KERNEL protection for ioremap of memory page Borislav Petkov
2017-03-16 20:04 ` Tom Lendacky
2017-03-17 14:32 ` Tom Lendacky
2017-03-17 14:55 ` Tom Lendacky
[not found] ` <148846763334.2349.9327692408737971533.stgit@brijesh-build-machine>
2017-03-08 8:46 ` [RFC PATCH v2 09/32] x86: Change early_ioremap to early_memremap for BOOT data Borislav Petkov
[not found] ` <148846766532.2349.4832844575566575886.stgit@brijesh-build-machine>
2017-03-08 10:56 ` [RFC PATCH v2 10/32] x86: DMA support for SEV memory encryption Borislav Petkov
[not found] ` <148846754069.2349.4698319264278045964.stgit@brijesh-build-machine>
2017-03-07 11:19 ` [RFC PATCH v2 02/32] x86: Secure Encrypted Virtualization (SEV) support Borislav Petkov
2017-03-08 15:06 ` Borislav Petkov
[not found] ` <148846768878.2349.15757532025749214650.stgit@brijesh-build-machine>
2017-03-09 14:07 ` [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active Borislav Petkov
2017-03-09 16:13 ` Paolo Bonzini
2017-03-09 16:29 ` Borislav Petkov
2017-03-10 16:35 ` Brijesh Singh
2017-03-16 10:16 ` Borislav Petkov
2017-03-16 14:28 ` Tom Lendacky
2017-03-16 15:09 ` Borislav Petkov
2017-03-16 16:11 ` Tom Lendacky
2017-03-16 16:29 ` Borislav Petkov
[not found] ` <148846770159.2349.16863375000963463500.stgit@brijesh-build-machine>
2017-03-09 19:29 ` [RFC PATCH v2 13/32] KVM: SVM: Enable SEV by setting the SEV_ENABLE CPU feature Borislav Petkov
[not found] ` <148846783136.2349.9362218518503742320.stgit@brijesh-build-machine>
2017-03-16 10:25 ` [RFC PATCH v2 23/32] kvm: introduce KVM_MEMORY_ENCRYPT_OP ioctl Paolo Bonzini
[not found] ` <148846784278.2349.17771314083820274411.stgit@brijesh-build-machine>
2017-03-16 10:33 ` [RFC PATCH v2 24/32] kvm: x86: prepare for SEV guest management API support Paolo Bonzini
[not found] ` <148846793743.2349.8478208161427437950.stgit@brijesh-build-machine>
2017-03-16 10:38 ` [RFC PATCH v2 32/32] x86: kvm: Pin the guest memory when SEV is active Paolo Bonzini
[not found] ` <453770c9-f9d7-4806-dbae-d19876f2a22e@redhat.com>
2017-03-16 18:17 ` Brijesh Singh
[not found] ` <148846786714.2349.17724971671841396908.stgit@brijesh-build-machine>
2017-03-16 10:48 ` [RFC PATCH v2 26/32] kvm: svm: Add support for SEV LAUNCH_UPDATE_DATA command Paolo Bonzini
[not found] ` <14021d2a-2a94-a0c8-88db-acbc04b4daac@redhat.com>
2017-03-16 18:20 ` Brijesh Singh
[not found] ` <148846789744.2349.167641684941925238.stgit@brijesh-build-machine>
2017-03-16 10:54 ` [RFC PATCH v2 29/32] kvm: svm: Add support for SEV DEBUG_DECRYPT command Paolo Bonzini
[not found] ` <4579cfdd-1797-8b47-8e00-254e3f6eb73f@redhat.com>
2017-03-16 18:41 ` Brijesh Singh
[not found] ` <d89ef60d-a97c-b712-fb0f-0242ebebb91a@amd.com>
2017-03-17 11:09 ` Paolo Bonzini [this message]
[not found] ` <148846790758.2349.16768762953657853550.stgit@brijesh-build-machine>
2017-03-16 11:03 ` [RFC PATCH v2 30/32] kvm: svm: Add support for SEV DEBUG_ENCRYPT command Paolo Bonzini
[not found] ` <05dbd756-e8e9-9384-2759-898e230a6909@redhat.com>
2017-03-16 18:34 ` Brijesh Singh
[not found] ` <148846773666.2349.9492983018843773590.stgit@brijesh-build-machine>
2017-03-16 11:06 ` [RFC PATCH v2 16/32] x86: kvm: Provide support to create Guest and HV shared per-CPU variables Paolo Bonzini
2017-03-28 18:39 ` Borislav Petkov
2017-03-29 15:21 ` Paolo Bonzini
2017-03-29 15:32 ` Borislav Petkov
[not found] ` <148846771545.2349.9373586041426414252.stgit@brijesh-build-machine>
2017-03-10 11:06 ` [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages Borislav Petkov
2017-03-10 22:41 ` Brijesh Singh
2017-03-16 13:15 ` Paolo Bonzini
2017-03-16 18:28 ` Borislav Petkov
2017-03-16 12:28 ` Paolo Bonzini
[not found] ` <148846772794.2349.1396854638510933455.stgit@brijesh-build-machine>
2017-03-24 17:12 ` [RFC PATCH v2 15/32] x86: Add support for changing memory encryption attribute in early boot Borislav Petkov
2017-03-27 15:07 ` Brijesh Singh
[not found] ` <148846776540.2349.3123530065053870721.stgit@brijesh-build-machine>
2017-03-29 15:14 ` [RFC PATCH v2 18/32] kvm: svm: Use the hardware provided GPA instead of page walk Borislav Petkov
2017-03-29 17:08 ` Brijesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ca24bbc2-25cf-a5ca-cd39-5862036214bb__25132.5921774425$1489749165$gmane$org@redhat.com' \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dyoung@redhat.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=msalter@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=piotr.luc@intel.com \
--cc=rkrcmar@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=simon.guinot@sequanux.org \
--cc=thomas.lendacky@amd.com \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).