* [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
@ 2022-09-28 18:45 Mario Limonciello
2022-09-28 21:05 ` Tom Lendacky
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Mario Limonciello @ 2022-09-28 18:45 UTC (permalink / raw)
To: mario.limonciello, Tom Lendacky, John Allen
Cc: stable, Rijo-john Thomas, Herbert Xu, David S. Miller,
linux-crypto, linux-kernel
SoCs containing 0x14CA are present both in datacenter parts that
support SEV as well as client parts that support TEE.
Cc: stable@vger.kernel.org # 5.15+
Tested-by: Rijo-john Thomas <Rijo-john.Thomas@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/crypto/ccp/sp-pci.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
index 792d6da7f0c0..084d052fddcc 100644
--- a/drivers/crypto/ccp/sp-pci.c
+++ b/drivers/crypto/ccp/sp-pci.c
@@ -381,6 +381,15 @@ static const struct psp_vdata pspv3 = {
.inten_reg = 0x10690,
.intsts_reg = 0x10694,
};
+
+static const struct psp_vdata pspv4 = {
+ .sev = &sevv2,
+ .tee = &teev1,
+ .feature_reg = 0x109fc,
+ .inten_reg = 0x10690,
+ .intsts_reg = 0x10694,
+};
+
#endif
static const struct sp_dev_vdata dev_vdata[] = {
@@ -426,7 +435,7 @@ static const struct sp_dev_vdata dev_vdata[] = {
{ /* 5 */
.bar = 2,
#ifdef CONFIG_CRYPTO_DEV_SP_PSP
- .psp_vdata = &pspv2,
+ .psp_vdata = &pspv4,
#endif
},
{ /* 6 */
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
2022-09-28 18:45 [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA Mario Limonciello
@ 2022-09-28 21:05 ` Tom Lendacky
2022-10-07 20:24 ` Limonciello, Mario
2022-10-21 11:34 ` Herbert Xu
2 siblings, 0 replies; 8+ messages in thread
From: Tom Lendacky @ 2022-09-28 21:05 UTC (permalink / raw)
To: Mario Limonciello, John Allen
Cc: stable, Rijo-john Thomas, Herbert Xu, David S. Miller,
linux-crypto, linux-kernel
On 9/28/22 13:45, Mario Limonciello wrote:
> SoCs containing 0x14CA are present both in datacenter parts that
> support SEV as well as client parts that support TEE.
>
> Cc: stable@vger.kernel.org # 5.15+
> Tested-by: Rijo-john Thomas <Rijo-john.Thomas@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 792d6da7f0c0..084d052fddcc 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -381,6 +381,15 @@ static const struct psp_vdata pspv3 = {
> .inten_reg = 0x10690,
> .intsts_reg = 0x10694,
> };
> +
> +static const struct psp_vdata pspv4 = {
> + .sev = &sevv2,
> + .tee = &teev1,
> + .feature_reg = 0x109fc,
> + .inten_reg = 0x10690,
> + .intsts_reg = 0x10694,
> +};
> +
> #endif
>
> static const struct sp_dev_vdata dev_vdata[] = {
> @@ -426,7 +435,7 @@ static const struct sp_dev_vdata dev_vdata[] = {
> { /* 5 */
> .bar = 2,
> #ifdef CONFIG_CRYPTO_DEV_SP_PSP
> - .psp_vdata = &pspv2,
> + .psp_vdata = &pspv4,
> #endif
> },
> { /* 6 */
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
2022-09-28 18:45 [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA Mario Limonciello
2022-09-28 21:05 ` Tom Lendacky
@ 2022-10-07 20:24 ` Limonciello, Mario
2022-10-12 9:31 ` Herbert Xu
2022-10-21 11:34 ` Herbert Xu
2 siblings, 1 reply; 8+ messages in thread
From: Limonciello, Mario @ 2022-10-07 20:24 UTC (permalink / raw)
To: Herbert Xu
Cc: stable, Thomas, Rijo-john, David S. Miller, linux-crypto,
linux-kernel, Lendacky, Thomas, Allen, John
[Public]
> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@amd.com>
> Sent: Wednesday, September 28, 2022 13:45
> To: Limonciello, Mario <Mario.Limonciello@amd.com>; Lendacky, Thomas
> <Thomas.Lendacky@amd.com>; Allen, John <John.Allen@amd.com>
> Cc: stable@vger.kernel.org; Thomas, Rijo-john <Rijo-
> john.Thomas@amd.com>; Herbert Xu <herbert@gondor.apana.org.au>;
> David S. Miller <davem@davemloft.net>; linux-crypto@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
>
> SoCs containing 0x14CA are present both in datacenter parts that
> support SEV as well as client parts that support TEE.
>
> Cc: stable@vger.kernel.org # 5.15+
> Tested-by: Rijo-john Thomas <Rijo-john.Thomas@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 792d6da7f0c0..084d052fddcc 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -381,6 +381,15 @@ static const struct psp_vdata pspv3 = {
> .inten_reg = 0x10690,
> .intsts_reg = 0x10694,
> };
> +
> +static const struct psp_vdata pspv4 = {
> + .sev = &sevv2,
> + .tee = &teev1,
> + .feature_reg = 0x109fc,
> + .inten_reg = 0x10690,
> + .intsts_reg = 0x10694,
> +};
> +
> #endif
>
> static const struct sp_dev_vdata dev_vdata[] = {
> @@ -426,7 +435,7 @@ static const struct sp_dev_vdata dev_vdata[] = {
> { /* 5 */
> .bar = 2,
> #ifdef CONFIG_CRYPTO_DEV_SP_PSP
> - .psp_vdata = &pspv2,
> + .psp_vdata = &pspv4,
> #endif
> },
> { /* 6 */
> --
> 2.34.1
Herbert,
I noticed you sent out the 6.1 PR already. So I Just wanted to make sure this
didn't get overlooked as it's already got a T-b/A-b.
Thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
2022-10-07 20:24 ` Limonciello, Mario
@ 2022-10-12 9:31 ` Herbert Xu
2022-10-12 12:42 ` Mario Limonciello
0 siblings, 1 reply; 8+ messages in thread
From: Herbert Xu @ 2022-10-12 9:31 UTC (permalink / raw)
To: Limonciello, Mario
Cc: stable, Thomas, Rijo-john, David S. Miller, linux-crypto,
linux-kernel, Lendacky, Thomas, Allen, John
On Fri, Oct 07, 2022 at 08:24:06PM +0000, Limonciello, Mario wrote:
>
> I noticed you sent out the 6.1 PR already. So I Just wanted to make sure this
> didn't get overlooked as it's already got a T-b/A-b.
Hi Mario:
This didn't make the deadline for inclusion in my 6.1 PR. Is there
any reason why it has to go in this merge window rather than the next?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
2022-10-12 9:31 ` Herbert Xu
@ 2022-10-12 12:42 ` Mario Limonciello
2022-10-13 1:55 ` Herbert Xu
0 siblings, 1 reply; 8+ messages in thread
From: Mario Limonciello @ 2022-10-12 12:42 UTC (permalink / raw)
To: Herbert Xu
Cc: stable, Thomas, Rijo-john, David S. Miller, linux-crypto,
linux-kernel, Lendacky, Thomas, Allen, John
On 10/12/22 04:31, Herbert Xu wrote:
> On Fri, Oct 07, 2022 at 08:24:06PM +0000, Limonciello, Mario wrote:
>>
>> I noticed you sent out the 6.1 PR already. So I Just wanted to make sure this
>> didn't get overlooked as it's already got a T-b/A-b.
>
> Hi Mario:
>
> This didn't make the deadline for inclusion in my 6.1 PR. Is there
> any reason why it has to go in this merge window rather than the next?
>
> Thanks,
Some other maintainers take new IDs as fixes. Particularly when they're
good candidates for cc stable.
The main reason I wanted to see it sooner is so that it has more time to
percolate to the various downstream distros so that errors stemming from
the lack of this ID declaration aren't prevalent when using this SOC.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
2022-10-12 12:42 ` Mario Limonciello
@ 2022-10-13 1:55 ` Herbert Xu
2022-10-13 4:01 ` Limonciello, Mario
0 siblings, 1 reply; 8+ messages in thread
From: Herbert Xu @ 2022-10-13 1:55 UTC (permalink / raw)
To: Mario Limonciello
Cc: stable, Thomas, Rijo-john, David S. Miller, linux-crypto,
linux-kernel, Lendacky, Thomas, Allen, John
On Wed, Oct 12, 2022 at 07:42:32AM -0500, Mario Limonciello wrote:
>
> Some other maintainers take new IDs as fixes. Particularly when they're
> good candidates for cc stable.
>
> The main reason I wanted to see it sooner is so that it has more time to
> percolate to the various downstream distros so that errors stemming from the
> lack of this ID declaration aren't prevalent when using this SOC.
Sorry but this is not persuasive enough for me. If you want a patch
to make a particular merge window, make sure that you get it in early
enough.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
2022-10-13 1:55 ` Herbert Xu
@ 2022-10-13 4:01 ` Limonciello, Mario
0 siblings, 0 replies; 8+ messages in thread
From: Limonciello, Mario @ 2022-10-13 4:01 UTC (permalink / raw)
To: Herbert Xu
Cc: stable, Thomas, Rijo-john, David S. Miller, linux-crypto,
linux-kernel, Lendacky, Thomas, Allen, John
[Public]
> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Wednesday, October 12, 2022 20:56
> To: Limonciello, Mario <Mario.Limonciello@amd.com>
> Cc: stable@vger.kernel.org; Thomas, Rijo-john <Rijo-
> john.Thomas@amd.com>; David S. Miller <davem@davemloft.net>; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Lendacky, Thomas
> <Thomas.Lendacky@amd.com>; Allen, John <John.Allen@amd.com>
> Subject: Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
>
> On Wed, Oct 12, 2022 at 07:42:32AM -0500, Mario Limonciello wrote:
> >
> > Some other maintainers take new IDs as fixes. Particularly when they're
> > good candidates for cc stable.
> >
> > The main reason I wanted to see it sooner is so that it has more time to
> > percolate to the various downstream distros so that errors stemming from
> the
> > lack of this ID declaration aren't prevalent when using this SOC.
>
> Sorry but this is not persuasive enough for me. If you want a patch
> to make a particular merge window, make sure that you get it in early
> enough.
OK thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA
2022-09-28 18:45 [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA Mario Limonciello
2022-09-28 21:05 ` Tom Lendacky
2022-10-07 20:24 ` Limonciello, Mario
@ 2022-10-21 11:34 ` Herbert Xu
2 siblings, 0 replies; 8+ messages in thread
From: Herbert Xu @ 2022-10-21 11:34 UTC (permalink / raw)
To: Mario Limonciello
Cc: Tom Lendacky, John Allen, stable, Rijo-john Thomas,
David S. Miller, linux-crypto, linux-kernel
On Wed, Sep 28, 2022 at 01:45:05PM -0500, Mario Limonciello wrote:
> SoCs containing 0x14CA are present both in datacenter parts that
> support SEV as well as client parts that support TEE.
>
> Cc: stable@vger.kernel.org # 5.15+
> Tested-by: Rijo-john Thomas <Rijo-john.Thomas@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/crypto/ccp/sp-pci.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-21 11:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 18:45 [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA Mario Limonciello
2022-09-28 21:05 ` Tom Lendacky
2022-10-07 20:24 ` Limonciello, Mario
2022-10-12 9:31 ` Herbert Xu
2022-10-12 12:42 ` Mario Limonciello
2022-10-13 1:55 ` Herbert Xu
2022-10-13 4:01 ` Limonciello, Mario
2022-10-21 11:34 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).