From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
"open list:GENERIC INCLUDE/A..." <linux-arch@vger.kernel.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Paul McKenney <paulmck@kernel.org>, X86 ML <x86@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
Russell King <linux@armlinux.org.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-xtensa@linux-xtensa.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ard Biesheuvel <ardb@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Vineet Gupta <vgupta@synopsys.com>,
arcml <linux-snps-arc@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>, Guo Ren <guoren@kernel.org>,
linux-csky@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, Nick Hu <nickhu@andestech.com>,
Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: Re: [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends
Date: Sat, 19 Sep 2020 12:37:53 +0200 [thread overview]
Message-ID: <CAKMK7uENFDANQKebS_H0bhHeQRijrp1aVHQqyZPute3KBZ+fVQ@mail.gmail.com> (raw)
In-Reply-To: <CAKMK7uHTVJL2jGtCg61zG=myiF1BSk+yDdRYikcm-Mq_1TQWMQ@mail.gmail.com>
On Sat, Sep 19, 2020 at 12:35 PM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Sat, Sep 19, 2020 at 11:50 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > First of all, sorry for the horribly big Cc list!
> >
> > Following up to the discussion in:
> >
> > https://lore.kernel.org/r/20200914204209.256266093@linutronix.de
> >
> > this provides a preemptible variant of kmap_atomic & related
> > interfaces. This is achieved by:
> >
> > - Consolidating all kmap atomic implementations in generic code
> >
> > - Switching from per CPU storage of the kmap index to a per task storage
> >
> > - Adding a pteval array to the per task storage which contains the ptevals
> > of the currently active temporary kmaps
> >
> > - Adding context switch code which checks whether the outgoing or the
> > incoming task has active temporary kmaps. If so, the outgoing task's
> > kmaps are removed and the incoming task's kmaps are restored.
> >
> > - Adding new interfaces k[un]map_temporary*() which are not disabling
> > preemption and can be called from any context (except NMI).
> >
> > Contrary to kmap() which provides preemptible and "persistant" mappings,
> > these interfaces are meant to replace the temporary mappings provided by
> > kmap_atomic*() today.
> >
> > This allows to get rid of conditional mapping choices and allows to have
> > preemptible short term mappings on 64bit which are today enforced to be
> > non-preemptible due to the highmem constraints. It clearly puts overhead on
> > the highmem users, but highmem is slow anyway.
> >
> > This is not a wholesale conversion which makes kmap_atomic magically
> > preemptible because there might be usage sites which rely on the implicit
> > preempt disable. So this needs to be done on a case by case basis and the
> > call sites converted to kmap_temporary.
> >
> > Note, that this is only lightly tested on X86 and completely untested on
> > all other architectures.
> >
> > The lot is also available from
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git highmem
>
> I think it should be the case, but I want to double check: Will
> copy_*_user be allowed within a kmap_temporary section? This would
> allow us to ditch an absolute pile of slowpaths.
(coffee just kicked in) copy_*_user is ofc allowed, but if you hit a
page fault you get a short read/write. This looks like it would remove
the need to handle these in a slowpath, since page faults can now be
served in this new kmap_temporary sections. But this sounds too good
to be true, so I'm wondering what I'm missing.
-Daniel
>
> >
> > Thanks,
> >
> > tglx
> > ---
> > a/arch/arm/mm/highmem.c | 121 ---------------------
> > a/arch/microblaze/mm/highmem.c | 78 -------------
> > a/arch/nds32/mm/highmem.c | 48 --------
> > a/arch/powerpc/mm/highmem.c | 67 -----------
> > a/arch/sparc/mm/highmem.c | 115 --------------------
> > arch/arc/Kconfig | 1
> > arch/arc/include/asm/highmem.h | 8 +
> > arch/arc/mm/highmem.c | 44 -------
> > arch/arm/Kconfig | 1
> > arch/arm/include/asm/highmem.h | 30 +++--
> > arch/arm/mm/Makefile | 1
> > arch/csky/Kconfig | 1
> > arch/csky/include/asm/highmem.h | 4
> > arch/csky/mm/highmem.c | 75 -------------
> > arch/microblaze/Kconfig | 1
> > arch/microblaze/include/asm/highmem.h | 6 -
> > arch/microblaze/mm/Makefile | 1
> > arch/microblaze/mm/init.c | 6 -
> > arch/mips/Kconfig | 1
> > arch/mips/include/asm/highmem.h | 4
> > arch/mips/mm/highmem.c | 77 -------------
> > arch/mips/mm/init.c | 3
> > arch/nds32/Kconfig.cpu | 1
> > arch/nds32/include/asm/highmem.h | 21 ++-
> > arch/nds32/mm/Makefile | 1
> > arch/powerpc/Kconfig | 1
> > arch/powerpc/include/asm/highmem.h | 6 -
> > arch/powerpc/mm/Makefile | 1
> > arch/powerpc/mm/mem.c | 7 -
> > arch/sparc/Kconfig | 1
> > arch/sparc/include/asm/highmem.h | 7 -
> > arch/sparc/mm/Makefile | 3
> > arch/sparc/mm/srmmu.c | 2
> > arch/x86/include/asm/fixmap.h | 1
> > arch/x86/include/asm/highmem.h | 12 +-
> > arch/x86/include/asm/iomap.h | 29 +++--
> > arch/x86/mm/highmem_32.c | 59 ----------
> > arch/x86/mm/init_32.c | 15 --
> > arch/x86/mm/iomap_32.c | 57 ----------
> > arch/xtensa/Kconfig | 1
> > arch/xtensa/include/asm/highmem.h | 9 +
> > arch/xtensa/mm/highmem.c | 44 -------
> > b/arch/x86/Kconfig | 3
> > include/linux/highmem.h | 141 +++++++++++++++---------
> > include/linux/io-mapping.h | 2
> > include/linux/sched.h | 9 +
> > kernel/sched/core.c | 10 +
> > mm/Kconfig | 3
> > mm/highmem.c | 192 ++++++++++++++++++++++++++++++++--
> > 49 files changed, 422 insertions(+), 909 deletions(-)
>
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-09-19 10:38 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 9:17 [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends Thomas Gleixner
2020-09-19 9:17 ` [patch RFC 01/15] mm/highmem: Un-EXPORT __kmap_atomic_idx() Thomas Gleixner
2020-09-21 6:23 ` Christoph Hellwig
2020-09-19 9:17 ` [patch RFC 02/15] highmem: Provide generic variant of kmap_atomic* Thomas Gleixner
2020-09-21 6:28 ` Christoph Hellwig
2020-09-19 9:17 ` [patch RFC 03/15] x86/mm/highmem: Use generic kmap atomic implementation Thomas Gleixner
2020-09-19 9:17 ` [patch RFC 04/15] arc/mm/highmem: " Thomas Gleixner
2020-09-19 9:17 ` [patch RFC 05/15] ARM: highmem: Switch to generic kmap atomic Thomas Gleixner
2020-09-19 9:17 ` [patch RFC 06/15] csky/mm/highmem: " Thomas Gleixner
2020-09-23 0:05 ` Guo Ren
2020-09-19 9:17 ` [patch RFC 07/15] microblaze/mm/highmem: " Thomas Gleixner
2020-09-19 9:17 ` [patch RFC 08/15] mips/mm/highmem: " Thomas Gleixner
2020-09-19 9:18 ` [patch RFC 09/15] nds32/mm/highmem: " Thomas Gleixner
2020-09-19 9:18 ` [patch RFC 10/15] powerpc/mm/highmem: " Thomas Gleixner
2020-09-19 9:18 ` [patch RFC 11/15] sparc/mm/highmem: " Thomas Gleixner
2020-09-19 9:18 ` [patch RFC 12/15] xtensa/mm/highmem: " Thomas Gleixner
2020-09-19 9:18 ` [patch RFC 13/15] mm/highmem: Remove the old kmap_atomic cruft Thomas Gleixner
2020-09-19 9:18 ` [patch RFC 14/15] sched: highmem: Store temporary kmaps in task struct Thomas Gleixner
2020-09-19 9:18 ` [patch RFC 15/15] mm/highmem: Provide kmap_temporary* Thomas Gleixner
2020-09-19 10:35 ` [patch RFC 00/15] mm/highmem: Provide a preemptible variant of kmap_atomic & friends Daniel Vetter
2020-09-19 10:37 ` Daniel Vetter [this message]
2020-09-20 6:23 ` Thomas Gleixner
2020-09-20 8:23 ` Daniel Vetter
2020-09-20 17:24 ` Thomas Gleixner
2020-09-19 17:18 ` Linus Torvalds
2020-09-19 17:39 ` Matthew Wilcox
2020-09-19 19:13 ` Linus Torvalds
2020-09-21 19:58 ` Ira Weiny
2020-09-20 6:41 ` Thomas Gleixner
2020-09-20 8:49 ` Thomas Gleixner
2020-09-20 16:57 ` Linus Torvalds
2020-09-20 17:40 ` Thomas Gleixner
2020-09-20 17:42 ` Linus Torvalds
2020-09-20 17:58 ` Linus Torvalds
2020-09-21 7:39 ` Thomas Gleixner
2020-09-21 16:24 ` Linus Torvalds
2020-09-21 19:27 ` Thomas Gleixner
2020-09-23 8:40 ` peterz
2020-09-23 13:35 ` Thomas Gleixner
2020-09-23 15:52 ` Steven Rostedt
2020-09-23 20:55 ` Thomas Gleixner
2020-09-23 21:12 ` Steven Rostedt
2020-09-24 6:57 ` Thomas Gleixner
2020-09-24 12:32 ` Steven Rostedt
2020-09-24 12:42 ` Peter Zijlstra
2020-09-24 13:51 ` Steven Rostedt
2020-09-24 13:58 ` Peter Zijlstra
2020-09-24 17:55 ` Thomas Gleixner
2020-09-24 18:58 ` Steven Rostedt
2020-09-24 8:27 ` peterz
2020-09-24 19:36 ` Daniel Bristot de Oliveira
2020-09-23 10:19 ` peterz
2020-09-23 12:33 ` Thomas Gleixner
2020-09-23 14:33 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uENFDANQKebS_H0bhHeQRijrp1aVHQqyZPute3KBZ+fVQ@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=juri.lelli@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=nickhu@andestech.com \
--cc=paulmck@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@synopsys.com \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).