* [PATCH] cxl/pci: Fix debug message
@ 2021-07-14 3:20 Ben Widawsky
2021-07-14 4:16 ` Ira Weiny
0 siblings, 1 reply; 2+ messages in thread
From: Ben Widawsky @ 2021-07-14 3:20 UTC (permalink / raw)
To: linux-cxl, Dan Williams; +Cc: Ben Widawsky, Ira Weiny
When mapping a register, the debug message should use the verb 'map' not
'probe'.
Cc: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
---
drivers/cxl/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
index 4cf351a3cf99..fe240e1504d5 100644
--- a/drivers/cxl/pci.c
+++ b/drivers/cxl/pci.c
@@ -1048,7 +1048,7 @@ static int cxl_map_regs(struct cxl_mem *cxlm, struct cxl_register_map *map)
break;
case CXL_REGLOC_RBI_MEMDEV:
cxl_map_device_regs(pdev, &cxlm->regs.device_regs, map);
- dev_dbg(dev, "Probing device registers...\n");
+ dev_dbg(dev, "Mapping device registers...\n");
break;
default:
break;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cxl/pci: Fix debug message
2021-07-14 3:20 [PATCH] cxl/pci: Fix debug message Ben Widawsky
@ 2021-07-14 4:16 ` Ira Weiny
0 siblings, 0 replies; 2+ messages in thread
From: Ira Weiny @ 2021-07-14 4:16 UTC (permalink / raw)
To: Ben Widawsky; +Cc: linux-cxl, Dan Williams
On Tue, Jul 13, 2021 at 08:20:54PM -0700, Widawsky, Ben wrote:
> When mapping a register, the debug message should use the verb 'map' not
> 'probe'.
>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
Yep... Thanks for catching that!
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/cxl/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 4cf351a3cf99..fe240e1504d5 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -1048,7 +1048,7 @@ static int cxl_map_regs(struct cxl_mem *cxlm, struct cxl_register_map *map)
> break;
> case CXL_REGLOC_RBI_MEMDEV:
> cxl_map_device_regs(pdev, &cxlm->regs.device_regs, map);
> - dev_dbg(dev, "Probing device registers...\n");
> + dev_dbg(dev, "Mapping device registers...\n");
> break;
> default:
> break;
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-14 4:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 3:20 [PATCH] cxl/pci: Fix debug message Ben Widawsky
2021-07-14 4:16 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).