From: Dan Williams <email@example.com>
To: Ben Widawsky <firstname.lastname@example.org>
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alison Schofield <email@example.com>,
Ira Weiny <firstname.lastname@example.org>,
Vishal Verma <email@example.com>
Subject: Re: [PATCH v2] cxl: Rename mem to pci
Date: Thu, 20 May 2021 12:39:21 -0700 [thread overview]
Message-ID: <CAPcyv4iUE7OyGmWJUnO-ONdNHB+i36m4OnkL0KQCO_Q2Ssz29g@mail.gmail.com> (raw)
On Thu, May 20, 2021 at 11:41 AM Ben Widawsky <firstname.lastname@example.org> wrote:
> As the driver has undergone development, it's become clear that the
> majority [entirety?] of the current functionality in mem.c is actually a
> layer encapsulating functionality exposed through PCI based
> interactions. This layer can be used either in isolation or to provide
> functionality for higher level functionality.
> CXL capabilities exist in a parallel domain to PCIe. CXL devices are
> enumerable and controllable via "legacy" PCIe mechanisms; however, their
> CXL capabilities are a superset of PCIe. For example, a CXL device may
> be connected to a non-CXL capable PCIe root port, and therefore will not
> be able to participate in CXL.mem or CXL.cache operations, but can still
> be accessed through PCIe mechanisms for CXL.io operations.
> To properly represent the PCI nature of this driver, and in preparation for
> introducing a new driver for the CXL.mem / HDM decoder (Host-managed Device
> Memory) capabilities of a CXL memory expander, rename mem.c to pci.c so that
> mem.c is available for this new driver.
> The result of the change is that there is a clear layering distinction
> in the driver, and a systems administrator may load only the cxl_pci
> module and gain access to such operations as, firmware update, offline
> provisioning of devices, and error collection. In addition to freeing up
> the file name for another purpose, there are two primary reasons this is
> 1. Acting upon devices which don't have full CXL capabilities. This
> may happen for instance if the CXL device is connected in a CXL
> unaware part of the platform topology.
> 2. Userspace-first provisioning for devices without kernel driver
> interference. This may be useful when provisioning a new device
> in a specific manner that might otherwise be blocked or prevented
> by the real CXL mem driver.
> Signed-off-by: Ben Widawsky <email@example.com>
> v2: Makes it clear that the main motivation for this patch is for proper
> layering and that administrative PCI-only activities is a secondary benefit.
> I'm proposing we take the hit now and merge this as our next patch for cxl/next.
Looks good to me, and I think low risk to expedite into cxl/next to
remove the burden on git to cope with other development touching these
Reviewed-by: Dan Williams <firstname.lastname@example.org>
next prev parent reply other threads:[~2021-05-20 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 18:57 [PATCH] cxl: Rename mem to pci Ben Widawsky
2021-05-10 17:29 ` Jonathan Cameron
2021-05-20 18:41 ` [PATCH v2] " Ben Widawsky
2021-05-20 19:39 ` Dan Williams [this message]
2021-05-26 17:44 ` [PATCH v3] " Ben Widawsky
2021-05-26 18:01 ` Ben Widawsky
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).