From: Dmitry Osipenko <digetx@gmail.com>
To: Richard Leitner <richard.leitner@skidata.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes
Date: Fri, 20 Dec 2019 17:00:46 +0300 [thread overview]
Message-ID: <01ac756c-1e51-5d62-ca45-9e0b4f106a29@gmail.com> (raw)
In-Reply-To: <20191219130431.30458-1-richard.leitner@skidata.com>
19.12.2019 16:04, Richard Leitner пишет:
> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
> to alias it from derived boards.
>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
> arch/arm/boot/dts/tegra20.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 9c58e7fcf5c0..e02f75757a7e 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -464,7 +464,7 @@
> clocks = <&tegra_car TEGRA20_CLK_RTC>;
> };
>
> - i2c@7000c000 {
> + i2c1: i2c@7000c000 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c000 0x100>;
> interrupts = <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>;
> @@ -494,7 +494,7 @@
> status = "disabled";
> };
>
> - i2c@7000c400 {
> + i2c2: i2c@7000c400 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c400 0x100>;
> interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> @@ -510,7 +510,7 @@
> status = "disabled";
> };
>
> - i2c@7000c500 {
> + i2c3: i2c@7000c500 {
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000c500 0x100>;
> interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
>
Hello Richard,
Why derived boards couldn't label nodes by themselves? That's what all
derived boards are doing already.
BTW, upstream should benefit from the submitted changes. This is not a
very useful change for upstream if you're not updating the actual DTs of
any of the boards in arch/arm/boot/dts/*.
next prev parent reply other threads:[~2019-12-20 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:04 [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes Richard Leitner
2019-12-19 13:04 ` [PATCH 2/2] ARM: dts: tegra20: add labels to host1x its subnodes Richard Leitner
2019-12-20 14:00 ` Dmitry Osipenko [this message]
2019-12-23 7:46 ` [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes Richard Leitner
2019-12-23 15:44 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ac756c-1e51-5d62-ca45-9e0b4f106a29@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).