From: Dmitry Osipenko <digetx@gmail.com>
To: Richard Leitner <richard.leitner@skidata.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes
Date: Mon, 23 Dec 2019 18:44:52 +0300 [thread overview]
Message-ID: <1a93a7a6-c3a1-0b94-ce3e-de8971487de5@gmail.com> (raw)
In-Reply-To: <27d4c933-8117-f38e-d4da-e58326fc6ee4@skidata.com>
23.12.2019 10:46, Richard Leitner пишет:
> Hi,
> thanks for the reply.
>
> On 20/12/2019 15:00, Dmitry Osipenko wrote:
>> 19.12.2019 16:04, Richard Leitner пишет:
>>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>>> to alias it from derived boards.
>>>
>>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>>> ---
>>> arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> ...
>
>>
>> Hello Richard,
>>
>> Why derived boards couldn't label nodes by themselves? That's what all
>> derived boards are doing already.
>
> Of course they can, but IMHO its more useful to have the same labels for
> all derived boards.
>
>>
>> BTW, upstream should benefit from the submitted changes. This is not a
>> very useful change for upstream if you're not updating the actual DTs of
>> any of the boards in arch/arm/boot/dts/*.
>
> That's true. I thought of also patching the actual DTs but wasn't sure
> if that should be in the same series...
> Based on your answer I guess it should be.
>
> Therefore I'll send a v2 soon.
>
> Thanks again & regards;richard.l
Seeing the full picture will be very helpful, thanks.
prev parent reply other threads:[~2019-12-23 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:04 [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes Richard Leitner
2019-12-19 13:04 ` [PATCH 2/2] ARM: dts: tegra20: add labels to host1x its subnodes Richard Leitner
2019-12-20 14:00 ` [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes Dmitry Osipenko
2019-12-23 7:46 ` Richard Leitner
2019-12-23 15:44 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a93a7a6-c3a1-0b94-ce3e-de8971487de5@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).