* [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-13 18:16 ` Krzysztof Kozlowski
2018-02-09 8:58 ` [PATCH 02/10] ARM: dts: omap: " Viresh Kumar
` (6 subsequent siblings)
7 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Rob Herring, Mark Rutland, Kukjin Kim,
Krzysztof Kozlowski
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Eduardo Valentin,
Zhang Rui, linux-arm-kernel, devicetree, daniel.lezcano,
linux-samsung-soc, linux-kernel
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm/boot/dts/exynos4210.dtsi | 2 --
arch/arm/boot/dts/exynos4412.dtsi | 2 --
arch/arm/boot/dts/exynos5250.dtsi | 2 --
arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ----------------
arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ----------------
5 files changed, 38 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index cc978cf28267..58ab34a233da 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -49,8 +49,6 @@
400000 975000
200000 950000
>;
- cooling-min-level = <4>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */
};
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e4ad2fc0329e..5f5cc12f2075 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -42,8 +42,6 @@
clocks = <&clock CLK_ARM_CLK>;
clock-names = "cpu";
operating-points-v2 = <&cpu0_opp_table>;
- cooling-min-level = <13>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
};
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 56626d1a4235..bb4180ef7885 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -77,8 +77,6 @@
300000 937500
200000 925000
>;
- cooling-min-level = <15>;
- cooling-max-level = <9>;
#cooling-cells = <2>; /* min followed by max */
};
cpu@1 {
diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi
index 123f0cef658d..a8e449471304 100644
--- a/arch/arm/boot/dts/exynos5420-cpus.dtsi
+++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi
@@ -30,8 +30,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -43,8 +41,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -56,8 +52,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -69,8 +63,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -83,8 +75,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -96,8 +86,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -109,8 +97,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -122,8 +108,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
diff --git a/arch/arm/boot/dts/exynos5422-cpus.dtsi b/arch/arm/boot/dts/exynos5422-cpus.dtsi
index c593809c7f08..7c130a00d1a8 100644
--- a/arch/arm/boot/dts/exynos5422-cpus.dtsi
+++ b/arch/arm/boot/dts/exynos5422-cpus.dtsi
@@ -29,8 +29,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -42,8 +40,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -55,8 +51,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -68,8 +62,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -82,8 +74,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -95,8 +85,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -108,8 +96,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -121,8 +107,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 ` [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes Viresh Kumar
@ 2018-02-13 18:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 36+ messages in thread
From: Krzysztof Kozlowski @ 2018-02-13 18:16 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Rob Herring, Mark Rutland, Kukjin Kim, linux-pm,
Vincent Guittot, Eduardo Valentin, Zhang Rui, linux-arm-kernel,
devicetree, daniel.lezcano, linux-samsung-soc, linux-kernel
On Fri, Feb 09, 2018 at 02:28:01PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm/boot/dts/exynos4210.dtsi | 2 --
> arch/arm/boot/dts/exynos4412.dtsi | 2 --
> arch/arm/boot/dts/exynos5250.dtsi | 2 --
> arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ----------------
> arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ----------------
> 5 files changed, 38 deletions(-)
>
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
2018-02-09 8:58 ` [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-12 17:17 ` Tony Lindgren
2018-02-09 8:58 ` [PATCH 03/10] ARM: dts: mt7623: " Viresh Kumar
` (5 subsequent siblings)
7 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Benoît Cousson, Tony Lindgren, Rob Herring,
Mark Rutland
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Eduardo Valentin,
Zhang Rui, linux-arm-kernel, devicetree, daniel.lezcano,
linux-omap, linux-kernel
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm/boot/dts/dra7.dtsi | 2 --
arch/arm/boot/dts/omap443x.dtsi | 2 --
arch/arm/boot/dts/omap4460.dtsi | 2 --
arch/arm/boot/dts/omap5.dtsi | 2 --
4 files changed, 8 deletions(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index e4a420f16800..f4ddd86f2c77 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -92,8 +92,6 @@
clock-latency = <300000>; /* From omap-cpufreq driver */
/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */
vbb-supply = <&abb_mpu>;
diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi
index 03c8ad91ddac..cbcdcb4e7d1c 100644
--- a/arch/arm/boot/dts/omap443x.dtsi
+++ b/arch/arm/boot/dts/omap443x.dtsi
@@ -24,8 +24,6 @@
clock-latency = <300000>; /* From legacy driver */
/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <3>;
#cooling-cells = <2>; /* min followed by max */
};
};
diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi
index c43f2a2d0a1e..ad97493e4e46 100644
--- a/arch/arm/boot/dts/omap4460.dtsi
+++ b/arch/arm/boot/dts/omap4460.dtsi
@@ -22,8 +22,6 @@
clock-latency = <300000>; /* From legacy driver */
/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */
};
};
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 35d4298da83d..511606c17a04 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -55,8 +55,6 @@
clock-latency = <300000>; /* From omap-cpufreq driver */
/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */
};
cpu@1 {
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 ` [PATCH 02/10] ARM: dts: omap: " Viresh Kumar
@ 2018-02-12 17:17 ` Tony Lindgren
2018-02-12 17:18 ` Tony Lindgren
0 siblings, 1 reply; 36+ messages in thread
From: Tony Lindgren @ 2018-02-12 17:17 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Benoît Cousson, Rob Herring, Mark Rutland,
linux-pm, Vincent Guittot, Eduardo Valentin, Zhang Rui,
linux-arm-kernel, devicetree, daniel.lezcano, linux-omap,
linux-kernel
* Viresh Kumar <viresh.kumar@linaro.org> [180209 00:59]:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
It seem this patch needs to wait before we can apply, right?
Regards,
Tony
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-12 17:17 ` Tony Lindgren
@ 2018-02-12 17:18 ` Tony Lindgren
0 siblings, 0 replies; 36+ messages in thread
From: Tony Lindgren @ 2018-02-12 17:18 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Benoît Cousson, Rob Herring, Mark Rutland,
linux-pm, Vincent Guittot, Eduardo Valentin, Zhang Rui,
linux-arm-kernel, devicetree, daniel.lezcano, linux-omap,
linux-kernel
* Tony Lindgren <tony@atomide.com> [180212 09:17]:
> * Viresh Kumar <viresh.kumar@linaro.org> [180209 00:59]:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of the kernel currently and the max cooling state of
> > a CPU cooling device is found by referring to the cpufreq table instead.
> >
> > Remove the unused properties from the CPU nodes.
>
> It seem this patch needs to wait before we can apply, right?
Oh sorry it's already unused :) Will pick this up for v4.17 thanks.
Tony
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 03/10] ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
2018-02-09 8:58 ` [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes Viresh Kumar
2018-02-09 8:58 ` [PATCH 02/10] ARM: dts: omap: " Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-18 23:26 ` Rob Herring
2018-02-09 8:58 ` [PATCH 04/10] ARM: dts: sun[4-7]i: " Viresh Kumar
` (4 subsequent siblings)
7 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Matthias Brugger, Rob Herring, Mark Rutland
Cc: devicetree, Vincent Guittot, linux-pm, Viresh Kumar,
daniel.lezcano, linux-kernel, Eduardo Valentin, linux-mediatek,
Zhang Rui, linux-arm-kernel
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ----
arch/arm/boot/dts/mt7623.dtsi | 2 --
2 files changed, 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
index f6403089edcf..d36f07e0a2bb 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
@@ -21,8 +21,6 @@ Binding for MediaTek's CPUFreq driver
flow is handled by hardware, hence no software "voltage tracking" is
needed.
- #cooling-cells:
-- cooling-min-level:
-- cooling-max-level:
Please refer to Documentation/devicetree/bindings/thermal/thermal.txt
for detail.
@@ -67,8 +65,6 @@ Binding for MediaTek's CPUFreq driver
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cpu_opp_table>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
};
cpu@1 {
device_type = "cpu";
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index b750da5362f7..8e7c65464c9d 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -87,8 +87,6 @@
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cpu_opp_table>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
clock-frequency = <1300000000>;
};
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 03/10] ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 ` [PATCH 03/10] ARM: dts: mt7623: " Viresh Kumar
@ 2018-02-18 23:26 ` Rob Herring
0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2018-02-18 23:26 UTC (permalink / raw)
To: Viresh Kumar
Cc: Mark Rutland, devicetree, Vincent Guittot, linux-pm,
daniel.lezcano, Rafael Wysocki, linux-kernel, Eduardo Valentin,
linux-mediatek, Matthias Brugger, Zhang Rui, linux-arm-kernel
On Fri, Feb 09, 2018 at 02:28:03PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ----
> arch/arm/boot/dts/mt7623.dtsi | 2 --
> 2 files changed, 6 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
` (2 preceding siblings ...)
2018-02-09 8:58 ` [PATCH 03/10] ARM: dts: mt7623: " Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-13 9:13 ` Maxime Ripard
2018-02-09 8:58 ` [PATCH 05/10] ARM64: dts: hi6220: " Viresh Kumar
` (3 subsequent siblings)
7 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Rob Herring, Mark Rutland, Maxime Ripard, Chen-Yu Tsai
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Eduardo Valentin,
Zhang Rui, linux-arm-kernel, devicetree, daniel.lezcano,
linux-kernel
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 1 -
arch/arm/boot/dts/sun4i-a10.dtsi | 2 --
arch/arm/boot/dts/sun5i-a13.dtsi | 2 --
arch/arm/boot/dts/sun6i-a31.dtsi | 2 --
arch/arm/boot/dts/sun7i-a20.dtsi | 2 --
5 files changed, 9 deletions(-)
diff --git a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
index 49247fbe6acd..e3d1d0f63caf 100644
--- a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
+++ b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
@@ -97,7 +97,6 @@
864000 1300000
624000 1250000
>;
- cooling-max-level = <2>;
};
&de {
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 4f2f2eea0755..77e8436beed4 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -123,8 +123,6 @@
624000 1250000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
};
};
diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
index 4e830f5cb7f1..b1d827765530 100644
--- a/arch/arm/boot/dts/sun5i-a13.dtsi
+++ b/arch/arm/boot/dts/sun5i-a13.dtsi
@@ -116,8 +116,6 @@
432000 1200000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <5>;
};
&pio {
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
index 72d3fe44ecaf..c72992556a86 100644
--- a/arch/arm/boot/dts/sun6i-a31.dtsi
+++ b/arch/arm/boot/dts/sun6i-a31.dtsi
@@ -113,8 +113,6 @@
480000 1000000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
};
cpu@1 {
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index bd0cd3204273..a3a6ce489fda 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -116,8 +116,6 @@
144000 1000000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <6>;
};
cpu@1 {
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 ` [PATCH 04/10] ARM: dts: sun[4-7]i: " Viresh Kumar
@ 2018-02-13 9:13 ` Maxime Ripard
2018-02-13 9:18 ` Chen-Yu Tsai
0 siblings, 1 reply; 36+ messages in thread
From: Maxime Ripard @ 2018-02-13 9:13 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Rob Herring, Mark Rutland, Chen-Yu Tsai,
linux-pm, Vincent Guittot, Eduardo Valentin, Zhang Rui,
linux-arm-kernel, devicetree, daniel.lezcano, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-13 9:13 ` Maxime Ripard
@ 2018-02-13 9:18 ` Chen-Yu Tsai
2018-02-14 3:12 ` Viresh Kumar
0 siblings, 1 reply; 36+ messages in thread
From: Chen-Yu Tsai @ 2018-02-13 9:18 UTC (permalink / raw)
To: Maxime Ripard, Rob Herring, Mark Rutland
Cc: Viresh Kumar, Rafael Wysocki, open list:THERMAL, Vincent Guittot,
Eduardo Valentin, Zhang Rui, linux-arm-kernel, devicetree,
Daniel Lezcano, linux-kernel
On Tue, Feb 13, 2018 at 5:13 PM, Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote:
>> The "cooling-min-level" and "cooling-max-level" properties are not
>> parsed by any part of the kernel currently and the max cooling state of
>> a CPU cooling device is found by referring to the cpufreq table instead.
That doesn't mean that other systems aren't using it. It's still part of
the device tree binding. Last I checked, while they are optional, they
aren't deprecated.
Any comments from the device tree maintainers?
>>
>> Remove the unused properties from the CPU nodes.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Applied, thanks!
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-13 9:18 ` Chen-Yu Tsai
@ 2018-02-14 3:12 ` Viresh Kumar
0 siblings, 0 replies; 36+ messages in thread
From: Viresh Kumar @ 2018-02-14 3:12 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Maxime Ripard, Rob Herring, Mark Rutland, Rafael Wysocki,
open list:THERMAL, Vincent Guittot, Eduardo Valentin, Zhang Rui,
linux-arm-kernel, devicetree, Daniel Lezcano, linux-kernel
On 13-02-18, 17:18, Chen-Yu Tsai wrote:
> On Tue, Feb 13, 2018 at 5:13 PM, Maxime Ripard
> <maxime.ripard@bootlin.com> wrote:
> > On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote:
> >> The "cooling-min-level" and "cooling-max-level" properties are not
> >> parsed by any part of the kernel currently and the max cooling state of
> >> a CPU cooling device is found by referring to the cpufreq table instead.
>
> That doesn't mean that other systems aren't using it.
Are you aware of any systems which are using them ?
> It's still part of
> the device tree binding. Last I checked, while they are optional, they
> aren't deprecated.
Yeah, it isn't deprecated yet. Though the last patches of this series
tries to do something similar.
> Any comments from the device tree maintainers?
None yet.
--
viresh
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 05/10] ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
` (3 preceding siblings ...)
2018-02-09 8:58 ` [PATCH 04/10] ARM: dts: sun[4-7]i: " Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-03-02 16:03 ` Wei Xu
[not found] ` <cover.1518166039.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
` (2 subsequent siblings)
7 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Wei Xu
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Eduardo Valentin,
Mark Rutland, Rob Herring, Zhang Rui, linux-arm-kernel,
devicetree, daniel.lezcano, linux-kernel
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.
Moreover, the entries are incorrect here as min level is 4 and the max
level is 0.
Remove the unused properties from the CPU nodes.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 6a180d1926e8..fca8e4ee98e7 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -88,8 +88,6 @@
next-level-cache = <&CLUSTER0_L2>;
clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
- cooling-min-level = <4>;
- cooling-max-level = <0>;
#cooling-cells = <2>; /* min followed by max */
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
dynamic-power-coefficient = <311>;
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 05/10] ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 ` [PATCH 05/10] ARM64: dts: hi6220: " Viresh Kumar
@ 2018-03-02 16:03 ` Wei Xu
0 siblings, 0 replies; 36+ messages in thread
From: Wei Xu @ 2018-03-02 16:03 UTC (permalink / raw)
To: Viresh Kumar, Rafael Wysocki
Cc: linux-pm, Vincent Guittot, Eduardo Valentin, Mark Rutland,
Rob Herring, Zhang Rui, linux-arm-kernel, devicetree,
daniel.lezcano, linux-kernel
Hi Viresh,
On 2018/2/9 8:58, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Moreover, the entries are incorrect here as min level is 4 and the max
> level is 0.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Applied into hisilicon dt tree.
Thanks!
BR,
Wei
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 6a180d1926e8..fca8e4ee98e7 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -88,8 +88,6 @@
> next-level-cache = <&CLUSTER0_L2>;
> clocks = <&stub_clock 0>;
> operating-points-v2 = <&cpu_opp_table>;
> - cooling-min-level = <4>;
> - cooling-max-level = <0>;
> #cooling-cells = <2>; /* min followed by max */
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> dynamic-power-coefficient = <311>;
>
^ permalink raw reply [flat|nested] 36+ messages in thread
[parent not found: <cover.1518166039.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
[not found] ` <cover.1518166039.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-09 9:03 ` Neil Armstrong
2018-03-20 1:37 ` Viresh Kumar
2018-02-09 8:58 ` [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node Viresh Kumar
2018-02-09 8:58 ` [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
2 siblings, 2 replies; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Carlo Caione, Kevin Hilman
Cc: Viresh Kumar, linux-pm-u79uwXL29TY76Z2rM5mHXA, Vincent Guittot,
Eduardo Valentin, Mark Rutland, Rob Herring, Zhang Rui,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused properties from the CPU nodes.
Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index 1448c3dba08e..658215c9822c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -209,14 +209,10 @@
};
&cpu0 {
- cooling-min-level = <0>;
- cooling-max-level = <6>;
#cooling-cells = <2>;
};
&cpu4 {
- cooling-min-level = <0>;
- cooling-max-level = <4>;
#cooling-cells = <2>;
};
--
2.15.0.194.g9af6a3dea062
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 ` [PATCH 06/10] ARM64: dts: meson: " Viresh Kumar
@ 2018-02-09 9:03 ` Neil Armstrong
2018-03-12 4:32 ` Viresh Kumar
2018-03-20 1:37 ` Viresh Kumar
1 sibling, 1 reply; 36+ messages in thread
From: Neil Armstrong @ 2018-02-09 9:03 UTC (permalink / raw)
To: Viresh Kumar, Rafael Wysocki, Carlo Caione, Kevin Hilman
Cc: Mark Rutland, devicetree, Vincent Guittot, linux-pm,
daniel.lezcano, linux-kernel, Eduardo Valentin, Rob Herring,
linux-amlogic, Zhang Rui, linux-arm-kernel
On 09/02/2018 09:58, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 1448c3dba08e..658215c9822c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -209,14 +209,10 @@
> };
>
> &cpu0 {
> - cooling-min-level = <0>;
> - cooling-max-level = <6>;
> #cooling-cells = <2>;
> };
>
> &cpu4 {
> - cooling-min-level = <0>;
> - cooling-max-level = <4>;
> #cooling-cells = <2>;
> };
>
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 9:03 ` Neil Armstrong
@ 2018-03-12 4:32 ` Viresh Kumar
0 siblings, 0 replies; 36+ messages in thread
From: Viresh Kumar @ 2018-03-12 4:32 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rafael Wysocki, Carlo Caione, Kevin Hilman, Mark Rutland,
devicetree, Vincent Guittot, linux-pm, daniel.lezcano,
linux-kernel, Eduardo Valentin, Rob Herring, linux-amlogic,
Zhang Rui, linux-arm-kernel
On 09-02-18, 10:03, Neil Armstrong wrote:
> On 09/02/2018 09:58, Viresh Kumar wrote:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of the kernel currently and the max cooling state of
> > a CPU cooling device is found by referring to the cpufreq table instead.
> >
> > Remove the unused properties from the CPU nodes.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> > index 1448c3dba08e..658215c9822c 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> > @@ -209,14 +209,10 @@
> > };
> >
> > &cpu0 {
> > - cooling-min-level = <0>;
> > - cooling-max-level = <6>;
> > #cooling-cells = <2>;
> > };
> >
> > &cpu4 {
> > - cooling-min-level = <0>;
> > - cooling-max-level = <4>;
> > #cooling-cells = <2>;
> > };
> >
> >
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Is Kevin going to apply these for 4.17 ?
--
viresh
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
2018-02-09 8:58 ` [PATCH 06/10] ARM64: dts: meson: " Viresh Kumar
2018-02-09 9:03 ` Neil Armstrong
@ 2018-03-20 1:37 ` Viresh Kumar
2018-03-27 12:29 ` Arnd Bergmann
1 sibling, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-03-20 1:37 UTC (permalink / raw)
To: arm, arnd.bergmann, Rafael Wysocki, Carlo Caione, Kevin Hilman
Cc: linux-pm, Vincent Guittot, Eduardo Valentin, Mark Rutland,
Rob Herring, Zhang Rui, linux-arm-kernel, devicetree,
daniel.lezcano, linux-amlogic, linux-kernel
On 09-02-18, 14:28, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
> 1 file changed, 4 deletions(-)
@Arnd: Can you please pick this and patch 8/10 from this series for 4.17 ? Both
are already Acked by Neil. I have just re-bounced both the messages to
arm@kernel.org. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
2018-03-20 1:37 ` Viresh Kumar
@ 2018-03-27 12:29 ` Arnd Bergmann
0 siblings, 0 replies; 36+ messages in thread
From: Arnd Bergmann @ 2018-03-27 12:29 UTC (permalink / raw)
To: Viresh Kumar
Cc: arm-soc, Arnd Bergmann, Rafael Wysocki, Carlo Caione,
Kevin Hilman, Linux PM list, Vincent Guittot, Eduardo Valentin,
Mark Rutland, Rob Herring, Zhang Rui, Linux ARM, DTML,
Daniel Lezcano, open list:ARM/Amlogic Meson SoC support,
Linux Kernel Mailing List
On Tue, Mar 20, 2018 at 2:37 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 09-02-18, 14:28, Viresh Kumar wrote:
>> The "cooling-min-level" and "cooling-max-level" properties are not
>> parsed by any part of the kernel currently and the max cooling state of
>> a CPU cooling device is found by referring to the cpufreq table instead.
>>
>> Remove the unused properties from the CPU nodes.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
>> 1 file changed, 4 deletions(-)
>
> @Arnd: Can you please pick this and patch 8/10 from this series for 4.17 ? Both
> are already Acked by Neil. I have just re-bounced both the messages to
> arm@kernel.org. Thanks.
Picked up patches 6, 7 and 8 now. For some reason I didn't see patch 8
in my arm@kernel.org inbox, but I found it on the mailing list.
Arnd
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
[not found] ` <cover.1518166039.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-09 8:58 ` [PATCH 06/10] ARM64: dts: meson: " Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-03-12 4:35 ` Viresh Kumar
2018-03-20 3:10 ` Linus Walleij
2018-02-09 8:58 ` [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
2 siblings, 2 replies; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Rob Herring, Mark Rutland
Cc: Viresh Kumar, linux-pm-u79uwXL29TY76Z2rM5mHXA, Vincent Guittot,
Eduardo Valentin, Zhang Rui,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
gpio-fan cooling device is found by referring to the
"gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
index 08568ce24d06..727d16eb02d9 100644
--- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
+++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
@@ -78,8 +78,6 @@
gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>,
<&gpio0 12 GPIO_ACTIVE_HIGH>;
gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>;
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>;
};
--
2.15.0.194.g9af6a3dea062
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
2018-02-09 8:58 ` [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node Viresh Kumar
@ 2018-03-12 4:35 ` Viresh Kumar
2018-03-20 1:43 ` Viresh Kumar
2018-03-20 3:10 ` Linus Walleij
1 sibling, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-03-12 4:35 UTC (permalink / raw)
To: Linus Walleij, Rafael Wysocki, Rob Herring, Mark Rutland
Cc: linux-pm, Vincent Guittot, Eduardo Valentin, Zhang Rui,
linux-arm-kernel, devicetree, daniel.lezcano, linux-kernel
On 09-02-18, 14:28, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> gpio-fan cooling device is found by referring to the
> "gpio-fan,speed-map" instead.
>
> Remove the unused properties from the gpio-fan node.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> index 08568ce24d06..727d16eb02d9 100644
> --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> @@ -78,8 +78,6 @@
> gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>,
> <&gpio0 12 GPIO_ACTIVE_HIGH>;
> gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>;
> - cooling-min-level = <0>;
> - cooling-max-level = <2>;
> #cooling-cells = <2>;
> };
>
@Linus: Can you please pick this one for 4.17 ?
--
viresh
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
2018-03-12 4:35 ` Viresh Kumar
@ 2018-03-20 1:43 ` Viresh Kumar
0 siblings, 0 replies; 36+ messages in thread
From: Viresh Kumar @ 2018-03-20 1:43 UTC (permalink / raw)
To: Linus Walleij, arnd.bergmann, arm, Rafael Wysocki, Rob Herring,
Mark Rutland
Cc: linux-pm, Vincent Guittot, Eduardo Valentin, Zhang Rui,
linux-arm-kernel, devicetree, daniel.lezcano, linux-kernel
On 12-03-18, 10:05, Viresh Kumar wrote:
> On 09-02-18, 14:28, Viresh Kumar wrote:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of the kernel currently and the max cooling state of
> > gpio-fan cooling device is found by referring to the
> > "gpio-fan,speed-map" instead.
> >
> > Remove the unused properties from the gpio-fan node.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> > index 08568ce24d06..727d16eb02d9 100644
> > --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> > +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> > @@ -78,8 +78,6 @@
> > gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>,
> > <&gpio0 12 GPIO_ACTIVE_HIGH>;
> > gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>;
> > - cooling-min-level = <0>;
> > - cooling-max-level = <2>;
> > #cooling-cells = <2>;
> > };
> >
>
> @Linus: Can you please pick this one for 4.17 ?
@Arnd/Olof: Can you please pick this one up as well ?
--
viresh
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
2018-02-09 8:58 ` [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node Viresh Kumar
2018-03-12 4:35 ` Viresh Kumar
@ 2018-03-20 3:10 ` Linus Walleij
2018-03-27 12:26 ` Arnd Bergmann
1 sibling, 1 reply; 36+ messages in thread
From: Linus Walleij @ 2018-03-20 3:10 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Rob Herring, Mark Rutland, Linux PM list,
Vincent Guittot, Eduardo Valentin, Zhang Rui, Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Daniel Lezcano, linux-kernel
On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> gpio-fan cooling device is found by referring to the
> "gpio-fan,speed-map" instead.
>
> Remove the unused properties from the gpio-fan node.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
I can queue it next week (different machine hosting the git tree)
but it is also OK if the ARM SoC maintainers want to pick it
directly for the ARM SoC DTS branch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
2018-03-20 3:10 ` Linus Walleij
@ 2018-03-27 12:26 ` Arnd Bergmann
2018-03-27 12:29 ` Linus Walleij
0 siblings, 1 reply; 36+ messages in thread
From: Arnd Bergmann @ 2018-03-27 12:26 UTC (permalink / raw)
To: Linus Walleij
Cc: Viresh Kumar, Rafael Wysocki, Rob Herring, Mark Rutland,
Linux PM list, Vincent Guittot, Eduardo Valentin, Zhang Rui,
Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Daniel Lezcano, linux-kernel
On Tue, Mar 20, 2018 at 4:10 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
>> The "cooling-min-level" and "cooling-max-level" properties are not
>> parsed by any part of the kernel currently and the max cooling state of
>> gpio-fan cooling device is found by referring to the
>> "gpio-fan,speed-map" instead.
>>
>> Remove the unused properties from the gpio-fan node.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> I can queue it next week (different machine hosting the git tree)
> but it is also OK if the ARM SoC maintainers want to pick it
> directly for the ARM SoC DTS branch.
I've picked it up directly now, as we're about to run out of time
before the merge window.
Arnd
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
2018-03-27 12:26 ` Arnd Bergmann
@ 2018-03-27 12:29 ` Linus Walleij
0 siblings, 0 replies; 36+ messages in thread
From: Linus Walleij @ 2018-03-27 12:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Viresh Kumar, Rafael Wysocki, Rob Herring, Mark Rutland,
Linux PM list, Vincent Guittot, Eduardo Valentin, Zhang Rui,
Linux ARM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Daniel Lezcano, linux-kernel
On Tue, Mar 27, 2018 at 2:26 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Mar 20, 2018 at 4:10 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>
>>> The "cooling-min-level" and "cooling-max-level" properties are not
>>> parsed by any part of the kernel currently and the max cooling state of
>>> gpio-fan cooling device is found by referring to the
>>> "gpio-fan,speed-map" instead.
>>>
>>> Remove the unused properties from the gpio-fan node.
>>>
>>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> I can queue it next week (different machine hosting the git tree)
>> but it is also OK if the ARM SoC maintainers want to pick it
>> directly for the ARM SoC DTS branch.
>
> I've picked it up directly now, as we're about to run out of time
> before the merge window.
Thanks, I was just about to queue it and send a pull request but now
I don't need to :)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
[not found] ` <cover.1518166039.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-09 8:58 ` [PATCH 06/10] ARM64: dts: meson: " Viresh Kumar
2018-02-09 8:58 ` [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-18 23:29 ` Rob Herring
2018-03-12 4:38 ` Viresh Kumar
2 siblings, 2 replies; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Zhang Rui, Eduardo Valentin
Cc: Viresh Kumar, linux-pm-u79uwXL29TY76Z2rM5mHXA, Vincent Guittot,
Mark Rutland, Rob Herring,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of kernel currently and the max cooling state of a
CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused bindings.
Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
index 1719d47a5e2f..cc553f0952c5 100644
--- a/Documentation/devicetree/bindings/thermal/thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/thermal.txt
@@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to
the different fan speeds possible. Cooling states are referred to by
single unsigned integers, where larger numbers mean greater heat
dissipation. The precise set of cooling states associated with a device
-(as referred to by the cooling-min-level and cooling-max-level
-properties) should be defined in a particular device's binding.
+should be defined in a particular device's binding.
For more examples of cooling devices, refer to the example sections below.
Required properties:
@@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below.
See Cooling device maps section below for more details
on how consumers refer to cooling devices.
-Optional properties:
-- cooling-min-level: An integer indicating the smallest
- Type: unsigned cooling state accepted. Typically 0.
- Size: one cell
-
-- cooling-max-level: An integer indicating the largest
- Type: unsigned cooling state accepted.
- Size: one cell
-
* Trip points
The trip node is a node to describe a point in the temperature domain
@@ -226,8 +216,6 @@ cpus {
396000 950000
198000 850000
>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
#cooling-cells = <2>; /* min followed by max */
};
...
@@ -241,8 +229,6 @@ cpus {
*/
fan0: fan@48 {
...
- cooling-min-level = <0>;
- cooling-max-level = <9>;
#cooling-cells = <2>; /* min followed by max */
};
};
--
2.15.0.194.g9af6a3dea062
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
2018-02-09 8:58 ` [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
@ 2018-02-18 23:29 ` Rob Herring
2018-02-19 3:43 ` Viresh Kumar
2018-03-12 4:38 ` Viresh Kumar
1 sibling, 1 reply; 36+ messages in thread
From: Rob Herring @ 2018-02-18 23:29 UTC (permalink / raw)
To: Viresh Kumar
Cc: Mark Rutland, devicetree, Vincent Guittot, linux-pm,
daniel.lezcano, Rafael Wysocki, linux-kernel, Eduardo Valentin,
Zhang Rui, linux-arm-kernel
On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of kernel currently and the max cooling state of a
> CPU cooling device is found by referring to the cpufreq table instead.
What about non-CPU devices? A fan for example.
>
> Remove the unused bindings.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index 1719d47a5e2f..cc553f0952c5 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to
> the different fan speeds possible. Cooling states are referred to by
> single unsigned integers, where larger numbers mean greater heat
> dissipation. The precise set of cooling states associated with a device
> -(as referred to by the cooling-min-level and cooling-max-level
> -properties) should be defined in a particular device's binding.
> +should be defined in a particular device's binding.
> For more examples of cooling devices, refer to the example sections below.
>
> Required properties:
> @@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below.
> See Cooling device maps section below for more details
> on how consumers refer to cooling devices.
>
> -Optional properties:
> -- cooling-min-level: An integer indicating the smallest
> - Type: unsigned cooling state accepted. Typically 0.
> - Size: one cell
> -
> -- cooling-max-level: An integer indicating the largest
> - Type: unsigned cooling state accepted.
> - Size: one cell
> -
> * Trip points
>
> The trip node is a node to describe a point in the temperature domain
> @@ -226,8 +216,6 @@ cpus {
> 396000 950000
> 198000 850000
> >;
> - cooling-min-level = <0>;
> - cooling-max-level = <3>;
> #cooling-cells = <2>; /* min followed by max */
> };
> ...
> @@ -241,8 +229,6 @@ cpus {
> */
> fan0: fan@48 {
> ...
> - cooling-min-level = <0>;
> - cooling-max-level = <9>;
> #cooling-cells = <2>; /* min followed by max */
> };
> };
> --
> 2.15.0.194.g9af6a3dea062
>
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
2018-02-18 23:29 ` Rob Herring
@ 2018-02-19 3:43 ` Viresh Kumar
2018-02-19 18:01 ` Rob Herring
0 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-19 3:43 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, Vincent Guittot, linux-pm,
daniel.lezcano, Rafael Wysocki, linux-kernel, Eduardo Valentin,
Zhang Rui, linux-arm-kernel
On 18-02-18, 17:29, Rob Herring wrote:
> On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of kernel currently and the max cooling state of a
> > CPU cooling device is found by referring to the cpufreq table instead.
>
> What about non-CPU devices? A fan for example.
Even they aren't using these properties. The gpio-fan binding[1] for
example uses the "gpio-fan,speed-map" property instead to find the
number of states it supports.
--
viresh
[1] Documentation/devicetree/bindings/gpio/gpio-fan.txt
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
2018-02-19 3:43 ` Viresh Kumar
@ 2018-02-19 18:01 ` Rob Herring
0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2018-02-19 18:01 UTC (permalink / raw)
To: Viresh Kumar
Cc: Mark Rutland, devicetree, Vincent Guittot, linux-pm,
daniel.lezcano, Rafael Wysocki, linux-kernel, Eduardo Valentin,
Zhang Rui, linux-arm-kernel
On Mon, Feb 19, 2018 at 09:13:38AM +0530, Viresh Kumar wrote:
> On 18-02-18, 17:29, Rob Herring wrote:
> > On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote:
> > > The "cooling-min-level" and "cooling-max-level" properties are not
> > > parsed by any part of kernel currently and the max cooling state of a
> > > CPU cooling device is found by referring to the cpufreq table instead.
> >
> > What about non-CPU devices? A fan for example.
>
> Even they aren't using these properties. The gpio-fan binding[1] for
> example uses the "gpio-fan,speed-map" property instead to find the
> number of states it supports.
Okay.
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
2018-02-09 8:58 ` [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
2018-02-18 23:29 ` Rob Herring
@ 2018-03-12 4:38 ` Viresh Kumar
2018-03-20 12:49 ` Zhang Rui
1 sibling, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-03-12 4:38 UTC (permalink / raw)
To: Rafael Wysocki, Zhang Rui, Eduardo Valentin
Cc: linux-pm, Vincent Guittot, Mark Rutland, Rob Herring,
linux-arm-kernel, devicetree, daniel.lezcano, linux-kernel
On 09-02-18, 14:28, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of kernel currently and the max cooling state of a
> CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused bindings.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
@Zhang/Eduardo: Can you please pick this patch (10/10) as almost everything else
is already lined up for 4.17 ?
--
viresh
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
2018-03-12 4:38 ` Viresh Kumar
@ 2018-03-20 12:49 ` Zhang Rui
2018-03-27 13:46 ` Eduardo Valentin
0 siblings, 1 reply; 36+ messages in thread
From: Zhang Rui @ 2018-03-20 12:49 UTC (permalink / raw)
To: Viresh Kumar, Rafael Wysocki, Eduardo Valentin
Cc: linux-pm, Vincent Guittot, Mark Rutland, Rob Herring,
linux-arm-kernel, devicetree, daniel.lezcano, linux-kernel
On 一, 2018-03-12 at 10:08 +0530, Viresh Kumar wrote:
> On 09-02-18, 14:28, Viresh Kumar wrote:
> >
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of kernel currently and the max cooling state of
> > a
> > CPU cooling device is found by referring to the cpufreq table
> > instead.
> >
> > Remove the unused bindings.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > Documentation/devicetree/bindings/thermal/thermal.txt | 16 +----
> > -----------
> > 1 file changed, 1 insertion(+), 15 deletions(-)
> @Zhang/Eduardo: Can you please pick this patch (10/10) as almost
> everything else
> is already lined up for 4.17 ?
I think Eduardo should have reviewed all the DT thermal patches in the
list, but I didn't see his response about this one.
Eduardo,
did you miss this one?
thanks,
rui
>
^ permalink raw reply [flat|nested] 36+ messages in thread* Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties
2018-03-20 12:49 ` Zhang Rui
@ 2018-03-27 13:46 ` Eduardo Valentin
0 siblings, 0 replies; 36+ messages in thread
From: Eduardo Valentin @ 2018-03-27 13:46 UTC (permalink / raw)
To: Zhang Rui
Cc: Viresh Kumar, Rafael Wysocki, linux-pm, Vincent Guittot,
Mark Rutland, Rob Herring, linux-arm-kernel, devicetree,
daniel.lezcano, linux-kernel
On Tue, Mar 20, 2018 at 08:49:50PM +0800, Zhang Rui wrote:
> On 一, 2018-03-12 at 10:08 +0530, Viresh Kumar wrote:
> > On 09-02-18, 14:28, Viresh Kumar wrote:
> > >
> > > The "cooling-min-level" and "cooling-max-level" properties are not
> > > parsed by any part of kernel currently and the max cooling state of
> > > a
> > > CPU cooling device is found by referring to the cpufreq table
> > > instead.
> > >
> > > Remove the unused bindings.
> > >
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > ---
> > > Documentation/devicetree/bindings/thermal/thermal.txt | 16 +----
> > > -----------
> > > 1 file changed, 1 insertion(+), 15 deletions(-)
> > @Zhang/Eduardo: Can you please pick this patch (10/10) as almost
> > everything else
> > is already lined up for 4.17 ?
>
> I think Eduardo should have reviewed all the DT thermal patches in the
> list, but I didn't see his response about this one.
>
> Eduardo,
> did you miss this one?
just applied and sending it in my pull request.
>
> thanks,
> rui
> >
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 08/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
` (5 preceding siblings ...)
[not found] ` <cover.1518166039.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-09 9:04 ` Neil Armstrong
2018-02-09 8:58 ` [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties Viresh Kumar
7 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki, Carlo Caione, Kevin Hilman
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Eduardo Valentin,
Mark Rutland, Rob Herring, Zhang Rui, linux-arm-kernel,
devicetree, daniel.lezcano, linux-amlogic, linux-kernel
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
gpio-fan cooling device is found by referring to the
"gpio-fan,speed-map" instead.
Remove the unused properties from the gpio-fan node.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index 658215c9822c..8ee4a693c438 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -59,8 +59,6 @@
1 1
2 2
3 3>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
#cooling-cells = <2>;
};
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 08/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node
2018-02-09 8:58 ` [PATCH 08/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node Viresh Kumar
@ 2018-02-09 9:04 ` Neil Armstrong
0 siblings, 0 replies; 36+ messages in thread
From: Neil Armstrong @ 2018-02-09 9:04 UTC (permalink / raw)
To: Viresh Kumar, Rafael Wysocki, Carlo Caione, Kevin Hilman
Cc: Mark Rutland, devicetree, Vincent Guittot, linux-pm,
daniel.lezcano, linux-kernel, Eduardo Valentin, Rob Herring,
linux-amlogic, Zhang Rui, linux-arm-kernel
On 09/02/2018 09:58, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> gpio-fan cooling device is found by referring to the
> "gpio-fan,speed-map" instead.
>
> Remove the unused properties from the gpio-fan node.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 658215c9822c..8ee4a693c438 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -59,8 +59,6 @@
> 1 1
> 2 2
> 3 3>;
> - cooling-min-level = <0>;
> - cooling-max-level = <3>;
> #cooling-cells = <2>;
> };
>
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties
2018-02-09 8:58 [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties Viresh Kumar
` (6 preceding siblings ...)
2018-02-09 8:58 ` [PATCH 08/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node Viresh Kumar
@ 2018-02-09 8:58 ` Viresh Kumar
2018-02-18 23:26 ` Rob Herring
7 siblings, 1 reply; 36+ messages in thread
From: Viresh Kumar @ 2018-02-09 8:58 UTC (permalink / raw)
To: Rafael Wysocki
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Eduardo Valentin,
Mark Rutland, Rob Herring, Zhang Rui, linux-arm-kernel,
devicetree, daniel.lezcano, linux-kernel
The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of kernel currently and the max cooling state of a
CPU cooling device is found by referring to the cpufreq table instead.
Remove the unused bindings.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
index dd3929e85dec..332aed8f4597 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
@@ -18,8 +18,6 @@ under node /cpus/cpu@0.
in unit of nanoseconds.
- voltage-tolerance: Specify the CPU voltage tolerance in percentage.
- #cooling-cells:
-- cooling-min-level:
-- cooling-max-level:
Please refer to Documentation/devicetree/bindings/thermal/thermal.txt.
Examples:
@@ -40,8 +38,6 @@ cpus {
>;
clock-latency = <61036>; /* two CLK32 periods */
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <2>;
};
cpu@1 {
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 36+ messages in thread* Re: [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties
2018-02-09 8:58 ` [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties Viresh Kumar
@ 2018-02-18 23:26 ` Rob Herring
0 siblings, 0 replies; 36+ messages in thread
From: Rob Herring @ 2018-02-18 23:26 UTC (permalink / raw)
To: Viresh Kumar
Cc: Mark Rutland, devicetree, Vincent Guittot, linux-pm,
daniel.lezcano, Rafael Wysocki, linux-kernel, Eduardo Valentin,
Zhang Rui, linux-arm-kernel
On Fri, Feb 09, 2018 at 02:28:09PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of kernel currently and the max cooling state of a
> CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused bindings.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 36+ messages in thread